aboutsummaryrefslogtreecommitdiff
path: root/utils
diff options
context:
space:
mode:
authorSteven Moreland <smoreland@google.com>2018-01-25 10:05:31 -0800
committerSteven Moreland <smoreland@google.com>2018-01-25 10:05:31 -0800
commit169a2d26015305d7425fe613d85d237517abebf7 (patch)
tree6d4ed530cd5f05fe8581c64ceafdebfc0c64afe8 /utils
parent2d3ff5c3a5f6e5d5f852dac8b39ff6c5ee6c5a5f (diff)
downloadhidl-169a2d26015305d7425fe613d85d237517abebf7.tar.gz
Remove std::vector constructor to FQName.
This is really just to construct the package itself, but it's pretty confusing to read in context and is only used once. Since we are moving FQName to not have an 'isValid' field, this is one less thing to worry about. Bug: 72125849 Test: hidl-gen's run_all_host_tests.sh Change-Id: Ie5500e0d0c4ce0c1548562cd4a96236e3223e1ec
Diffstat (limited to 'utils')
-rw-r--r--utils/FQName.cpp6
-rw-r--r--utils/include/hidl-util/FQName.h3
2 files changed, 0 insertions, 9 deletions
diff --git a/utils/FQName.cpp b/utils/FQName.cpp
index bb62244f..1fa61cfd 100644
--- a/utils/FQName.cpp
+++ b/utils/FQName.cpp
@@ -91,12 +91,6 @@ FQName::FQName(const FQName& other)
mValueName(other.mValueName) {
}
-FQName::FQName(const std::vector<std::string> &names)
- : mValid(false),
- mIsIdentifier(false) {
- setTo(StringHelper::JoinStrings(names, "."));
-}
-
bool FQName::isValid() const {
return mValid;
}
diff --git a/utils/include/hidl-util/FQName.h b/utils/include/hidl-util/FQName.h
index 3cfe61ac..d5bfc33d 100644
--- a/utils/include/hidl-util/FQName.h
+++ b/utils/include/hidl-util/FQName.h
@@ -32,9 +32,6 @@ struct FQName {
const std::string &name,
const std::string &valueName = "");
- // a synonym to FQName(names.join("."))
- FQName(const std::vector<std::string> &names);
-
FQName(const FQName& other);
bool isValid() const;