aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorOrion Hodson <oth@google.com>2021-03-08 09:34:10 +0000
committerAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2021-03-08 09:34:10 +0000
commitfe3b6e5ca6d4b79950992046a7d55011cca9f459 (patch)
tree082af47e99da7b4d375a98151fb699b4908eb631
parentd69b0fc8f4ec97015c71daf4c2b95c5096306950 (diff)
parentdc83ae34337eb2910f01058d945f40948bd29b09 (diff)
downloadxsdc-fe3b6e5ca6d4b79950992046a7d55011cca9f459.tar.gz
xsdc: emit explicit single argument constructor decls am: dc83ae3433
Original change: https://android-review.googlesource.com/c/platform/system/tools/xsdc/+/1622420 MUST ONLY BE SUBMITTED BY AUTOMERGER Change-Id: Ifc620536984d2bbac9232302559b878ea604d4b2
-rw-r--r--src/com/android/xsdc/cpp/CppCodeGenerator.java9
1 files changed, 8 insertions, 1 deletions
diff --git a/src/com/android/xsdc/cpp/CppCodeGenerator.java b/src/com/android/xsdc/cpp/CppCodeGenerator.java
index 561d3f5..432d510 100644
--- a/src/com/android/xsdc/cpp/CppCodeGenerator.java
+++ b/src/com/android/xsdc/cpp/CppCodeGenerator.java
@@ -734,7 +734,14 @@ public class CppCodeGenerator {
if (constructorArgsString.length() > 0) {
constructorArgsString = constructorArgsString.substring(2);
}
- parserHeaderFile.printf("%s(%s);\n", name, constructorArgsString);
+
+ boolean useExplicit =
+ !(constructorArgsString.isEmpty() || constructorArgsString.contains(","));
+ if (useExplicit) {
+ parserHeaderFile.printf("explicit %s(%s);\n", name, constructorArgsString);
+ } else {
+ parserHeaderFile.printf("%s(%s);\n", name, constructorArgsString);
+ }
parserCppFile.printf("\n%s::%s(%s) : ", fullName, name, constructorArgsString);
String parentArgsString = parentArgs.toString();