diff options
author | Christopher Ferris <cferris@google.com> | 2024-02-01 10:23:34 -0800 |
---|---|---|
committer | Christopher Ferris <cferris@google.com> | 2024-02-01 10:23:34 -0800 |
commit | a9a7faddda4f209e0df5ae73da706cbe39a40b8f (patch) | |
tree | 2bc242d226a451c5691370d53a09e2aeba75fcbe | |
parent | 59128b50b974d17ec64602d39dd42bf5f72805bb (diff) | |
download | unwinding-a9a7faddda4f209e0df5ae73da706cbe39a40b8f.tar.gz |
Make Regs*::Read parameter const.
In order to make it explicit that this value is not an out parameter,
make the values const.
Test: Builds.
Change-Id: If34ecedf367c22b9470f3bcba883707f6cf10dca
-rw-r--r-- | libunwindstack/RegsArm.cpp | 4 | ||||
-rw-r--r-- | libunwindstack/RegsArm64.cpp | 4 | ||||
-rw-r--r-- | libunwindstack/RegsRiscv64.cpp | 4 | ||||
-rw-r--r-- | libunwindstack/RegsX86.cpp | 4 | ||||
-rw-r--r-- | libunwindstack/RegsX86_64.cpp | 4 | ||||
-rw-r--r-- | libunwindstack/include/unwindstack/RegsArm.h | 2 | ||||
-rw-r--r-- | libunwindstack/include/unwindstack/RegsArm64.h | 2 | ||||
-rw-r--r-- | libunwindstack/include/unwindstack/RegsRiscv64.h | 2 | ||||
-rw-r--r-- | libunwindstack/include/unwindstack/RegsX86.h | 2 | ||||
-rw-r--r-- | libunwindstack/include/unwindstack/RegsX86_64.h | 2 |
10 files changed, 15 insertions, 15 deletions
diff --git a/libunwindstack/RegsArm.cpp b/libunwindstack/RegsArm.cpp index 302f659..7258058 100644 --- a/libunwindstack/RegsArm.cpp +++ b/libunwindstack/RegsArm.cpp @@ -80,8 +80,8 @@ void RegsArm::IterateRegisters(std::function<void(const char*, uint64_t)> fn) { fn("pc", regs_[ARM_REG_PC]); } -Regs* RegsArm::Read(void* remote_data) { - arm_user_regs* user = reinterpret_cast<arm_user_regs*>(remote_data); +Regs* RegsArm::Read(const void* remote_data) { + const arm_user_regs* user = reinterpret_cast<const arm_user_regs*>(remote_data); RegsArm* regs = new RegsArm(); memcpy(regs->RawData(), &user->regs[0], ARM_REG_LAST * sizeof(uint32_t)); diff --git a/libunwindstack/RegsArm64.cpp b/libunwindstack/RegsArm64.cpp index cf19454..85da806 100644 --- a/libunwindstack/RegsArm64.cpp +++ b/libunwindstack/RegsArm64.cpp @@ -131,8 +131,8 @@ void RegsArm64::IterateRegisters(std::function<void(const char*, uint64_t)> fn) fn("pst", regs_[ARM64_REG_PSTATE]); } -Regs* RegsArm64::Read(void* remote_data) { - arm64_user_regs* user = reinterpret_cast<arm64_user_regs*>(remote_data); +Regs* RegsArm64::Read(const void* remote_data) { + const arm64_user_regs* user = reinterpret_cast<const arm64_user_regs*>(remote_data); RegsArm64* regs = new RegsArm64(); memcpy(regs->RawData(), &user->regs[0], (ARM64_REG_R30 + 1) * sizeof(uint64_t)); diff --git a/libunwindstack/RegsRiscv64.cpp b/libunwindstack/RegsRiscv64.cpp index 63070e4..6e796a2 100644 --- a/libunwindstack/RegsRiscv64.cpp +++ b/libunwindstack/RegsRiscv64.cpp @@ -97,8 +97,8 @@ void RegsRiscv64::IterateRegisters(std::function<void(const char*, uint64_t)> fn fn("a7", regs_[RISCV64_REG_A7]); } -Regs* RegsRiscv64::Read(void* remote_data) { - riscv64_user_regs* user = reinterpret_cast<riscv64_user_regs*>(remote_data); +Regs* RegsRiscv64::Read(const void* remote_data) { + const riscv64_user_regs* user = reinterpret_cast<const riscv64_user_regs*>(remote_data); RegsRiscv64* regs = new RegsRiscv64(); memcpy(regs->RawData(), &user->regs[0], RISCV64_REG_MAX * sizeof(uint64_t)); diff --git a/libunwindstack/RegsX86.cpp b/libunwindstack/RegsX86.cpp index 48e8de6..4452699 100644 --- a/libunwindstack/RegsX86.cpp +++ b/libunwindstack/RegsX86.cpp @@ -74,8 +74,8 @@ void RegsX86::IterateRegisters(std::function<void(const char*, uint64_t)> fn) { fn("eip", regs_[X86_REG_EIP]); } -Regs* RegsX86::Read(void* user_data) { - x86_user_regs* user = reinterpret_cast<x86_user_regs*>(user_data); +Regs* RegsX86::Read(const void* user_data) { + const x86_user_regs* user = reinterpret_cast<const x86_user_regs*>(user_data); RegsX86* regs = new RegsX86(); (*regs)[X86_REG_EAX] = user->eax; diff --git a/libunwindstack/RegsX86_64.cpp b/libunwindstack/RegsX86_64.cpp index c8a3a21..ac29302 100644 --- a/libunwindstack/RegsX86_64.cpp +++ b/libunwindstack/RegsX86_64.cpp @@ -83,8 +83,8 @@ void RegsX86_64::IterateRegisters(std::function<void(const char*, uint64_t)> fn) fn("rip", regs_[X86_64_REG_RIP]); } -Regs* RegsX86_64::Read(void* remote_data) { - x86_64_user_regs* user = reinterpret_cast<x86_64_user_regs*>(remote_data); +Regs* RegsX86_64::Read(const void* remote_data) { + const x86_64_user_regs* user = reinterpret_cast<const x86_64_user_regs*>(remote_data); RegsX86_64* regs = new RegsX86_64(); (*regs)[X86_64_REG_RAX] = user->rax; diff --git a/libunwindstack/include/unwindstack/RegsArm.h b/libunwindstack/include/unwindstack/RegsArm.h index 5596605..eba0927 100644 --- a/libunwindstack/include/unwindstack/RegsArm.h +++ b/libunwindstack/include/unwindstack/RegsArm.h @@ -49,7 +49,7 @@ class RegsArm : public RegsImpl<uint32_t> { Regs* Clone() override final; - static Regs* Read(void* data); + static Regs* Read(const void* data); static Regs* CreateFromUcontext(void* ucontext); }; diff --git a/libunwindstack/include/unwindstack/RegsArm64.h b/libunwindstack/include/unwindstack/RegsArm64.h index d12a043..71b3605 100644 --- a/libunwindstack/include/unwindstack/RegsArm64.h +++ b/libunwindstack/include/unwindstack/RegsArm64.h @@ -62,7 +62,7 @@ class RegsArm64 : public RegsImpl<uint64_t> { Regs* Clone() override final; - static Regs* Read(void* data); + static Regs* Read(const void* data); static Regs* CreateFromUcontext(void* ucontext); diff --git a/libunwindstack/include/unwindstack/RegsRiscv64.h b/libunwindstack/include/unwindstack/RegsRiscv64.h index 2876ca4..711bdb3 100644 --- a/libunwindstack/include/unwindstack/RegsRiscv64.h +++ b/libunwindstack/include/unwindstack/RegsRiscv64.h @@ -49,7 +49,7 @@ class RegsRiscv64 : public RegsImpl<uint64_t> { Regs* Clone() override final; - static Regs* Read(void* data); + static Regs* Read(const void* data); static Regs* CreateFromUcontext(void* ucontext); }; diff --git a/libunwindstack/include/unwindstack/RegsX86.h b/libunwindstack/include/unwindstack/RegsX86.h index d8245ee..5079067 100644 --- a/libunwindstack/include/unwindstack/RegsX86.h +++ b/libunwindstack/include/unwindstack/RegsX86.h @@ -52,7 +52,7 @@ class RegsX86 : public RegsImpl<uint32_t> { Regs* Clone() override final; - static Regs* Read(void* data); + static Regs* Read(const void* data); static Regs* CreateFromUcontext(void* ucontext); }; diff --git a/libunwindstack/include/unwindstack/RegsX86_64.h b/libunwindstack/include/unwindstack/RegsX86_64.h index 90fee93..c4422e2 100644 --- a/libunwindstack/include/unwindstack/RegsX86_64.h +++ b/libunwindstack/include/unwindstack/RegsX86_64.h @@ -52,7 +52,7 @@ class RegsX86_64 : public RegsImpl<uint64_t> { Regs* Clone() override final; - static Regs* Read(void* data); + static Regs* Read(const void* data); static Regs* CreateFromUcontext(void* ucontext); }; |