Age | Commit message (Collapse) | Author |
|
Some shared libraries seem to be putting a dynamic symbol table
at the end of the shared library. Modify the GetMaxSize()
function to read the PT_LOAD values and if that is larger
than the computed elf size, use that value instead.
Added new offline test to expose this problem.
Bug: 268566992
Test: All unit tests pass.
Change-Id: I9c240e83d6090417fc1f642f049175def908be32
(cherry picked from commit 55a088e31bbfb5ffa23e48cb25ff1b72a8f64207)
|
|
am: 5458702d07 am: 291b5c3926
Original change: https://android-review.googlesource.com/c/platform/system/unwinding/+/2070169
Change-Id: I3ed4c04bd0446b5ab4b2ffae7003a2f2e2a5c9af
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
am: 5458702d07
Original change: https://android-review.googlesource.com/c/platform/system/unwinding/+/2070169
Change-Id: Ib9d8bf2c68b9a32c9c76a8160c99679d769384e9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Original change: https://android-review.googlesource.com/c/platform/system/unwinding/+/2070169
Change-Id: I7631d60d2ca6e0dd2d6dedb1c4ae8efb8b1ad19f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Original change: https://android-review.googlesource.com/c/platform/system/unwinding/+/2070169
Change-Id: I83d1e52e882df83a73f394e3013f51cf99c60f38
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Original change: https://android-review.googlesource.com/c/platform/system/unwinding/+/2070169
Change-Id: If07dfd8d749c6830008f2bd417e71c3c14422afa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
7d76ac3305 am: 422b01c9de am: 1654af4eea
Original change: https://android-review.googlesource.com/c/platform/system/unwinding/+/2029306
Change-Id: I007bd3ea1ee28b18fc8328264846da01c01be2f9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
7d76ac3305 am: 422b01c9de
Original change: https://android-review.googlesource.com/c/platform/system/unwinding/+/2029306
Change-Id: I59ffdd078f9d74e28d6c209fcaa1a3bdde5c228b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Original change: https://android-review.googlesource.com/c/platform/system/unwinding/+/2029306
Change-Id: Ie3dc5eb5d6416caf386ee180c3113b15343267ec
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Original change: https://android-review.googlesource.com/c/platform/system/unwinding/+/2029306
Change-Id: Ifb04510ead2ad7382574c132a45c1cef3fd69f05
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Move to using the #pragma once header guard instead of the #ifndef
construct since it's cleaner.
Test: Compiles.
Change-Id: I0bd76b53cfc78df7465029ef34783f85651a9c74
|
|
Original change: https://android-review.googlesource.com/c/platform/system/unwinding/+/2029306
Change-Id: Ic8f49a3cf3bfd2abb579083ca902c48c7b04f97a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Create two different objects (AndroidLocalUnwinder and
AndroidRemoteUnwinder) that encapsulate all Android related
knowledge. This makes it simple for other code to create one
of these objects and not need to add all of the Android specific
code themselves.
Add new unit tests to cover these new objects.
New unit tests uncovered a small bug in the Unwinder object, namely
that if you are skipping libraries, the suffixes to ignore still
looks at the ignored frames. Fixed to only apply ignore suffixes to
only non-ignored frames.
Rewrote all of the places that attach to remote processes and
created a single function to handle all of the different cases.
Bug: 120606663
Test: All unit tests pass.
Test: Ran the tests hundreds of times on host and target.
Test: There are still some failures, but only 1 in 800 and 1 in 300.
Change-Id: I9d0732e33695af20b3c3f87c625e623f6b7f9ef2
|
|
am: bcd5fb2f35 -s ours am: 65687a3ec0 -s ours am: 2eb7e50b9b -s ours
am skip reason: Merged-In I65981e444b884c780c1274c3a42be163842a7c44 with SHA-1 abc6659791 is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/unwinding/+/17544602
Change-Id: Ife2366abea0cc2723146cff4c759d5616eda7112
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
am: bcd5fb2f35 -s ours am: 65687a3ec0 -s ours
am skip reason: Merged-In I65981e444b884c780c1274c3a42be163842a7c44 with SHA-1 abc6659791 is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/unwinding/+/17544602
Change-Id: Ida1ed7a414b0f38ec470f74821029b312875f0e4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
am: bcd5fb2f35 -s ours
am skip reason: Merged-In I65981e444b884c780c1274c3a42be163842a7c44 with SHA-1 abc6659791 is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/unwinding/+/17544602
Change-Id: I7c88b1fe218c5e4afae20fd15ba7de442949ebbd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
am skip reason: Merged-In I65981e444b884c780c1274c3a42be163842a7c44 with SHA-1 abc6659791 is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/unwinding/+/17544602
Change-Id: I8daa65d5f446ee9dd8beca0d4433461397dc5bf9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Bug: 226662282
Merged-In: I65981e444b884c780c1274c3a42be163842a7c44
Change-Id: If7da0d31275087df439813011f91111215413ca5
|
|
Original change: https://android-review.googlesource.com/c/platform/system/unwinding/+/2048663
Change-Id: I5316a52dc8db769d55c9a2ae6ebc5d4aff8f4b46
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Original change: https://android-review.googlesource.com/c/platform/system/unwinding/+/2048663
Change-Id: I65981e444b884c780c1274c3a42be163842a7c44
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Original change: https://android-review.googlesource.com/c/platform/system/unwinding/+/2048663
Change-Id: I57203976a269c05c3e7deac60b720a08b682bde2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
|
|
Remove mips support from register getting functions since this
is untestable.
Add unit tests for RemoteGetArch and RemoteGet.
Test: All unit tests pass on x86 (host), x86_64 (host), arm, arm64.
Change-Id: I42842e518851b69a5c2f0b824c3811f7034cfc67
|
|
3fb6550d29 am: 57049e6ff4 am: bfd857285d
Original change: https://android-review.googlesource.com/c/platform/system/unwinding/+/2044008
Change-Id: If368551fe93b5442fc0c194053c62b29c6cf9d49
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
3fb6550d29 am: 57049e6ff4
Original change: https://android-review.googlesource.com/c/platform/system/unwinding/+/2044008
Change-Id: I50ed5c74359107c2ec4bc836d2004f7447a6b4af
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Original change: https://android-review.googlesource.com/c/platform/system/unwinding/+/2044008
Change-Id: I0855ef9455c61adc0e0b6a3fe3d1d6f5d6d7fcf3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
For convenience, builds against musl libc currently use the
linux_glibc properties because they are almost always linux-specific
and not glibc-specific. In preparation for removing this hack,
tweak the linux_glibc properties by either moving them to host_linux,
which will apply to linux_glibc, linux_musl and linux_bionic, or
by setting appropriate musl or linux_musl properties. Properties
that must not be repeated while musl uses linux_musl and also still
uses the linux_glibc properties are moved to glibc properties, which
don't apply to musl. Whether these stay as glibc properties or get
moved back to linux_glibc later once the musl hack is removed is TBD.
Bug: 223257095
Test: m checkbuild
Test: m USE_HOST_MUSL=true host-native
Change-Id: I058b62b0d333f1c41e7c1a4c77de63c5a6fe56c7
|
|
am: 08cc2174fb am: f0425d6554 am: fc1a172ea6 -s ours
am skip reason: Merged-In Iefcec5c017d35334fd5b71b5820cfc3383dba59b with SHA-1 367ef4645d is already in history
Original change: https://android-review.googlesource.com/c/platform/system/unwinding/+/2031923
Change-Id: Ib63015d8ecbe4386a50d3208eac6f638522f590c
|
|
f0425d6554
Original change: https://android-review.googlesource.com/c/platform/system/unwinding/+/2031923
Change-Id: Ib4aae726aca9268d6c912df2bbc7588f2b541fea
|
|
Original change: https://android-review.googlesource.com/c/platform/system/unwinding/+/2031923
Change-Id: I92ea117db2dc1a9262477808cb2c7efa711b8515
|
|
|
|
Change-Id: Iefcec5c017d35334fd5b71b5820cfc3383dba59b
Merged-In: Iefcec5c017d35334fd5b71b5820cfc3383dba59b
|
|
Change-Id: Iefcec5c017d35334fd5b71b5820cfc3383dba59b
Merged-In: Iefcec5c017d35334fd5b71b5820cfc3383dba59b
|
|
am: e99edcb115
Original change: https://android-review.googlesource.com/c/platform/system/unwinding/+/2025803
Change-Id: Ib92083a60dcf8d26a2a3c3e50ef529ad95bfc95b
|
|
Original change: https://android-review.googlesource.com/c/platform/system/unwinding/+/2025803
Change-Id: Icd5608ce8b40d5b9d7cc3c72733f27f78558d99e
|
|
Original change: https://android-review.googlesource.com/c/platform/system/unwinding/+/2025803
Change-Id: Ibd41eac69dfdec432869e324a5b3e5c8036340ab
|
|
This value isn't really needed and slows down unwinds for no real
reason. Move this function to the MapInfo object so it can be
queried when needed.
Add new unit tests to cover this.
Test: All unit tests pass.
Change-Id: Ibce0ae7f92f39ca44aefce5fb465181818671952
|
|
312a6a714f
Original change: https://android-review.googlesource.com/c/platform/system/unwinding/+/2015575
Change-Id: I808f811c0a62665e85bfe639a02b0c69739aad5d
|
|
Original change: https://android-review.googlesource.com/c/platform/system/unwinding/+/2015575
Change-Id: Ideba387c9765cb26b987526f09fabd227d7ec334
|
|
Original change: https://android-review.googlesource.com/c/platform/system/unwinding/+/2015575
Change-Id: I452b6faa786681cc70891b2f90bd93d8f8992a84
|
|
|
|
The new directory is added as a new visibility rules
instead of replacing the old one to avoid an automerger
conflict. The old path will be removed in a following CL.
Test: m root-canal
Change-Id: Ic6489b57d0b03cf6f0c7cd400b578394cdea300d
|
|
Original change: https://android-review.googlesource.com/c/platform/system/unwinding/+/2008230
Change-Id: I789d64e8571158668052fdfab3bba66e71ebafbe
|
|
Original change: https://android-review.googlesource.com/c/platform/system/unwinding/+/2008230
Change-Id: I4c8e734b188747be7859b14ffd43724bb1514029
|
|
Original change: https://android-review.googlesource.com/c/platform/system/unwinding/+/2008230
Change-Id: I205c4a311eea94509a94f90d0e261dae0c0487ff
|
|
This object is no longer needed, and is actually slower than
using the Unwinder object.
Bug: 120606663
Test: All unit tests pass.
Change-Id: I1b0e53b1f12fc5ac92c6b0e167ded5e906c7962d
|
|
am: 5fbe373dde
Original change: https://android-review.googlesource.com/c/platform/system/unwinding/+/2004761
Change-Id: Ia62743daf6edfd5ed267d1661b6d586a4dc820b6
|
|
Original change: https://android-review.googlesource.com/c/platform/system/unwinding/+/2004761
Change-Id: I13a68a5bbf68ec4be9e99f295ef5c44c3a312639
|
|
Original change: https://android-review.googlesource.com/c/platform/system/unwinding/+/2004761
Change-Id: Id1d57d1e703458bd4b059997ccff0ed96e3b4095
|
|
The check in ThreadUnwinder was overly aggressive, it should only
disallow unwinding itself. Unfortunately, it only disallowed
unwinding the main thread.
Add new unit tests to verify this behavior.
Test: New unit tests pass that verify thread unwinding behavior.
Signed-off-by: Sim Sun <simsun@fb.com>
Change-Id: If75399911f2f98f3155592fc292341d7b9e5e023
|