Fix variable type in for loop to match type comparison am: fa6befc915 am: 1b56331b15 am: 61a560945eandroid-14.0.0_r45android-14.0.0_r44android-14.0.0_r43android-14.0.0_r42android-14.0.0_r41android-14.0.0_r40android-14.0.0_r39android-14.0.0_r38android-14.0.0_r27android-14.0.0_r26android-14.0.0_r25android-14.0.0_r24android-14.0.0_r23android-14.0.0_r22android-14.0.0_r21android-14.0.0_r20android-14.0.0_r19android-14.0.0_r18android-14.0.0_r17android-14.0.0_r16aml_wif_341711020aml_wif_341610000aml_wif_341510000aml_wif_341410080aml_wif_341310010aml_wif_341110010aml_wif_341011010aml_wif_340913010aml_uwb_341710010aml_uwb_341513070aml_uwb_341511050aml_uwb_341310300aml_uwb_341310030aml_uwb_341111010aml_uwb_341011000aml_tz5_341510070aml_tz5_341510050aml_tz5_341510010aml_tet_341712060aml_tet_341610020aml_tet_341511010aml_tet_341411060aml_tet_341310230aml_tet_341112070aml_tet_341010040aml_tet_340913030aml_swc_341711000aml_swc_341619000aml_swc_341513600aml_swc_341312300aml_swc_341312020aml_swc_341111000aml_swc_341011020aml_swc_340922010aml_sta_341710000aml_sta_341615000aml_sta_341511040aml_sta_341410000aml_sta_341311010aml_sta_341114000aml_sta_341111000aml_sta_341010020aml_sta_340912000aml_sta_340911000aml_sdk_341710000aml_sdk_341510000aml_sdk_341410000aml_sdk_341110080aml_sdk_341110000aml_sdk_341010000aml_sdk_340912010aml_sch_341510000aml_rkp_341510000aml_rkp_341311000aml_rkp_341114000aml_rkp_341015010aml_rkp_341012000aml_res_341510000aml_res_341410010aml_res_341311030aml_res_341110000aml_res_340912000aml_per_341711000aml_per_341614000aml_per_341510010aml_per_341410020aml_per_341311000aml_per_341110020aml_per_341110010aml_per_341011100aml_per_341011020aml_per_340916010aml_odp_341717000aml_odp_341610000aml_neu_341510000aml_neu_341010080aml_neu_341010000aml_net_341710020aml_net_341610030aml_net_341510050aml_net_341510000aml_net_341411030aml_net_341311010aml_net_341310020aml_net_341111030aml_net_341014000aml_net_340913000aml_mpr_341713020aml_mpr_341614010aml_mpr_341511070aml_mpr_341411070aml_mpr_341313030aml_mpr_341111030aml_mpr_341111020aml_mpr_341015090aml_mpr_341015030aml_mpr_340919000aml_med_341711000aml_med_341619000aml_med_341513600aml_med_341312300aml_med_341312020aml_med_341111000aml_med_341011000aml_med_340922010aml_ips_341611000aml_ips_341510000aml_ips_340914280aml_ips_340914200aml_ips_340914000aml_hef_341717050aml_hef_341613000aml_hef_341512030aml_hef_341415040aml_hef_341311010aml_hef_341114030aml_ext_341716000aml_ext_341620040aml_ext_341518010aml_ext_341414010aml_ext_341317010aml_ext_341131030aml_ext_341027030aml_doc_341713000aml_doc_341610010aml_doc_341510050aml_doc_341312010aml_doc_341112000aml_doc_341012000aml_doc_340916000aml_con_341614000aml_con_341511080aml_con_341410300aml_con_341310090aml_con_341110000aml_cfg_341510000aml_cbr_341710000aml_cbr_341610000aml_cbr_341510010aml_cbr_341410010aml_cbr_341311010aml_cbr_341110000aml_cbr_341011000aml_cbr_340914000aml_ase_341510000aml_ase_341410000aml_ase_341310010aml_ase_341113000aml_ase_340913000aml_art_341711000aml_art_341615020aml_art_341514450aml_art_341514410aml_art_341411300aml_art_341311100aml_art_341110110aml_art_341110060aml_art_341010050aml_art_340915060aml_ads_341720000aml_ads_341615050aml_ads_341517040aml_ads_341413000aml_ads_341316030aml_ads_341131050aml_ads_341027030aml_ads_340915050aml_adb_341520010aml_adb_341517070aml_adb_340912530aml_adb_340912350aml_adb_340912200aml_adb_340912000android14-qpr1-s2-releaseandroid14-qpr1-releaseandroid14-mainline-wifi-releaseandroid14-mainline-uwb-releaseandroid14-mainline-tethering-releaseandroid14-mainline-sdkext-releaseandroid14-mainline-resolv-releaseandroid14-mainline-permission-releaseandroid14-mainline-os-statsd-releaseandroid14-mainline-networking-releaseandroid14-mainline-mediaprovider-releaseandroid14-mainline-media-swcodec-releaseandroid14-mainline-media-releaseandroid14-mainline-healthfitness-releaseandroid14-mainline-extservices-releaseandroid14-mainline-conscrypt-releaseandroid14-mainline-cellbroadcast-releaseandroid14-mainline-art-releaseandroid14-mainline-appsearch-releaseandroid14-mainline-adservices-releaseandroid14-mainline-adbd-releaseandroid14-devandroid14-d2-s5-releaseandroid14-d2-s4-releaseandroid14-d2-s3-releaseandroid14-d2-s2-releaseandroid14-d2-s1-releaseandroid14-d2-releaseaml_tz5_341510010

Original change: https://android-review.googlesource.com/c/platform/test/dittosuite/+/2393134

Change-Id: I5f4010e44a9973b9246611f65db12cddda9a85e5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

8 files changed, 10 insertions, 9 deletions

diff --git a/Android.bp b/Android.bp
index f713cb8..c2324fb 100644
--- a/Android.bp
+++ b/Android.bp
@@ -27,6 +27,7 @@ cc_defaults {
       "-Wall",
       "-Werror",
       "-Wextra",
+      "-Wsign-compare",
     ],
     tidy: true,
     /*
diff --git a/dittotrace.cpp b/dittotrace.cpp
index 98a0e31..47a1bc2 100644
--- a/dittotrace.cpp
+++ b/dittotrace.cpp
@@ -89,7 +89,7 @@ std::map<int, std::vector<Syscall>> ProcessLines(
   std::map<int, std::vector<Syscall>> processed_syscalls_by_pid;
 
   for (const auto& [pid, lines] : lines_by_pid) {
-    for (unsigned int i = 0; i < lines.size(); ++i) {
+    for (std::size_t i = 0; i < lines.size(); ++i) {
       auto line = lines[i];
 
       // If only the resumed part of the syscall was found, ignore it
diff --git a/src/instruction_set.cpp b/src/instruction_set.cpp
index aeb14ab..1da105c 100644
--- a/src/instruction_set.cpp
+++ b/src/instruction_set.cpp
@@ -66,7 +66,7 @@ void InstructionSet::RunSingle() {
     std::visit(overloaded{[&](const std::vector<std::string>& list) {
                             std::uniform_int_distribution<> uniform_distribution(0,
                                                                                  list.size() - 1);
-                            for (unsigned int i = 0; i < list.size(); ++i) {
+                            for (std::size_t i = 0; i < list.size(); ++i) {
                               switch (access_order_) {
                                 case Order::kSequential: {
                                   SharedVariables::Set(item_key_, list[i]);
@@ -115,7 +115,7 @@ std::unique_ptr<Result> InstructionSet::CollectResults(const std::string& prefix
       duration.resize(samples.size() / repeat);
     }
 
-    for (unsigned int i = 0; i < samples.size() / repeat; ++i) {
+    for (std::size_t i = 0; i < samples.size() / repeat; ++i) {
       for (int j = 0; j < repeat; ++j) {
         duration[i] += samples[i * repeat + j];
       }
diff --git a/src/multithreading.cpp b/src/multithreading.cpp
index 0ec8875..ed8dcf7 100644
--- a/src/multithreading.cpp
+++ b/src/multithreading.cpp
@@ -52,7 +52,7 @@ void Multithreading::TearDownSingle() {
 std::unique_ptr<Result> Multithreading::CollectResults(const std::string& prefix) {
   auto result = std::make_unique<Result>(prefix + name_, repeat_);
   result->AddMeasurement("duration", TimespecToDoubleNanos(time_sampler_.GetSamples()));
-  for (unsigned int i = 0; i < instructions_.size(); ++i) {
+  for (std::size_t i = 0; i < instructions_.size(); ++i) {
     result->AddSubResult(instructions_[i]->CollectResults(std::to_string(i) + "/"));
   }
   return result;
diff --git a/src/parser.cpp b/src/parser.cpp
index 98f1db9..f0e98ec 100644
--- a/src/parser.cpp
+++ b/src/parser.cpp
@@ -50,7 +50,7 @@ void Parser::Parse(const std::string& file_path, const std::vector<std::string>&
   std::string file_contents((std::istreambuf_iterator<char>(file)),
                             (std::istreambuf_iterator<char>()));
 
-  for (unsigned int i = 0; i < parameters.size(); i++) {
+  for (std::size_t i = 0; i < parameters.size(); i++) {
     std::string to_replace("$PARAMETER_" + std::to_string(i + 1) + "$");
     auto position = file_contents.find(to_replace);
     if (position == std::string::npos) {
diff --git a/src/result.cpp b/src/result.cpp
index 702de49..e154700 100644
--- a/src/result.cpp
+++ b/src/result.cpp
@@ -194,7 +194,7 @@ void Result::PrintHistogramHeader(const std::string& measurement_name) {
 void Result::MakeHistogramFromVector(const std::vector<int>& freq_vector, const int min_value) {
   int sum = 0;
   int max_frequency = *std::max_element(freq_vector.begin(), freq_vector.end());
-  for (unsigned int i = 0; i < freq_vector.size(); i++) {
+  for (std::size_t i = 0; i < freq_vector.size(); i++) {
     std::cout.width(kSampleDisplayWidth);
     std::cout << min_value + bin_size * i << kTableDivider;
 
diff --git a/src/shared_variables.cpp b/src/shared_variables.cpp
index 5080d6a..b27c2b6 100644
--- a/src/shared_variables.cpp
+++ b/src/shared_variables.cpp
@@ -36,7 +36,7 @@ int SharedVariables::GetKey(const std::list<int>& thread_ids, const std::string&
   }
 
   // If the key does not exist, create it for the current thread
-  int key = variables_.size();
+  std::size_t key = variables_.size();
   keys_[thread_ids.back()].insert({variable_name, key});
   variables_.resize(variables_.size() + 1);
   return key;
diff --git a/test/timespec_utils_test.cpp b/test/timespec_utils_test.cpp
index c870cf8..8805b20 100644
--- a/test/timespec_utils_test.cpp
+++ b/test/timespec_utils_test.cpp
@@ -26,13 +26,13 @@ std::vector<int64_t> tss_ns = {0,          1,          1000000000, 1000000001,
                                1999999999, 2000000002, 2000000003, 3000000001};
 
 TEST(TimespecUtilsTest, TimespecToNanos) {
-  for (unsigned int i = 0; i < tss.size(); ++i) {
+  for (std::size_t i = 0; i < tss.size(); ++i) {
     ASSERT_EQ(TimespecToNanos(tss[i]), tss_ns[i]);
   }
 }
 
 TEST(TimespecUtilsTest, NanosToTimespec) {
-  for (unsigned int i = 0; i < tss.size(); ++i) {
+  for (std::size_t i = 0; i < tss.size(); ++i) {
     ASSERT_EQ(tss[i], NanosToTimespec(tss_ns[i]));
   }
 }