summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTreeHugger Robot <treehugger-gerrit@google.com>2020-07-23 22:58:13 +0000
committerAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2020-07-23 22:58:13 +0000
commit85d2ae2e7b25e8d78fea2d173ddc34313ae120db (patch)
treebce38672653a26dd62aec06c4f5578489a8edddd
parent1be0b426b4b666d08e43537e15ca1a118f0f4770 (diff)
parentfac3396f9c3611b3f126f2d8a9ff95a1b156dd09 (diff)
downloadsuite_harness-85d2ae2e7b25e8d78fea2d173ddc34313ae120db.tar.gz
Merge "Fix Crash Parser appending signals/patterns" into pi-dev am: fac3396f9c
Original change: https://googleplex-android-review.googlesource.com/c/platform/test/suite_harness/+/11558331 Change-Id: Ifa70e6e1b88546bc335f6769f315682908705a67
-rw-r--r--common/util/src/com/android/compatibility/common/util/CrashUtils.java20
1 files changed, 14 insertions, 6 deletions
diff --git a/common/util/src/com/android/compatibility/common/util/CrashUtils.java b/common/util/src/com/android/compatibility/common/util/CrashUtils.java
index 657708d9..b3977944 100644
--- a/common/util/src/com/android/compatibility/common/util/CrashUtils.java
+++ b/common/util/src/com/android/compatibility/common/util/CrashUtils.java
@@ -17,6 +17,7 @@
package com.android.compatibility.common.util;
import java.io.File;
+import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
@@ -203,10 +204,17 @@ public class CrashUtils {
}
public static class Config {
- private boolean checkMinAddress = true;
- private BigInteger minCrashAddress = MIN_CRASH_ADDR;
- private List<String> signals = Arrays.asList(SIGSEGV, SIGBUS);
- private List<Pattern> processPatterns = Collections.emptyList();
+ private boolean checkMinAddress;
+ private BigInteger minCrashAddress;
+ private List<String> signals;
+ private List<Pattern> processPatterns;
+
+ public Config() {
+ checkMinAddress = true;
+ minCrashAddress = MIN_CRASH_ADDR;
+ setSignals(SIGSEGV, SIGBUS);
+ processPatterns = new ArrayList();
+ }
public Config setMinAddress(BigInteger minCrashAddress) {
this.minCrashAddress = minCrashAddress;
@@ -219,7 +227,7 @@ public class CrashUtils {
}
public Config setSignals(String... signals) {
- this.signals = Arrays.asList(signals);
+ this.signals = new ArrayList(Arrays.asList(signals));
return this;
}
@@ -237,7 +245,7 @@ public class CrashUtils {
}
public Config setProcessPatterns(Pattern... processPatterns) {
- this.processPatterns = Arrays.asList(processPatterns);
+ this.processPatterns = new ArrayList(Arrays.asList(processPatterns));
return this;
}