summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorWenshan Fu <wenshan@google.com>2023-08-22 10:39:37 +0800
committerWenshan Fu <wenshan@google.com>2023-08-22 10:52:42 +0800
commit6ede4f47c711306f30a1fc1c848e78eefc5acee1 (patch)
tree52d699b542c3fe2589f011b5b2b48420caaa7a97
parentf0bd526cf872bc80c7b7e2d49abdb11748d337a3 (diff)
downloadsuite_harness-6ede4f47c711306f30a1fc1c848e78eefc5acee1.tar.gz
Add an option 'has-server-side-config'
Some tests have no server side dynamic configs. If this option is set false, this target preparer won't call the service and will just read the config locally. Test: atest DynamicConfigPusherTest Bug: 292152522 Change-Id: Ic0aec16c5ccbec9ce08c436f0ff00223da78710a
-rw-r--r--common/host-side/tradefed/src/com/android/compatibility/common/tradefed/targetprep/DynamicConfigPusher.java8
-rw-r--r--common/host-side/tradefed/tests/src/com/android/compatibility/common/tradefed/targetprep/DynamicConfigPusherTest.java6
2 files changed, 9 insertions, 5 deletions
diff --git a/common/host-side/tradefed/src/com/android/compatibility/common/tradefed/targetprep/DynamicConfigPusher.java b/common/host-side/tradefed/src/com/android/compatibility/common/tradefed/targetprep/DynamicConfigPusher.java
index 594df02e..7a99c0f6 100644
--- a/common/host-side/tradefed/src/com/android/compatibility/common/tradefed/targetprep/DynamicConfigPusher.java
+++ b/common/host-side/tradefed/src/com/android/compatibility/common/tradefed/targetprep/DynamicConfigPusher.java
@@ -77,6 +77,11 @@ public class DynamicConfigPusher extends BaseTargetPreparer
private String mConfigUrl = "https://androidpartner.googleapis.com/v1/dynamicconfig/" +
"suites/{suite-name}/modules/{module}/version/{version}?key={api-key}";
+ @Option(
+ name = "has-server-side-config",
+ description = "Whether there exists a service side dynamic config.")
+ private boolean mHasServerSideConfig = true;
+
@Option(name="config-filename", description = "The module name for module-level " +
"configurations, or the suite name for suite-level configurations")
private String mModuleName = null;
@@ -281,6 +286,9 @@ public class DynamicConfigPusher extends BaseTargetPreparer
@VisibleForTesting
String resolveUrl(String suiteName) throws TargetSetupError {
+ if (!mHasServerSideConfig) {
+ return null;
+ }
try {
String configUrl =
UrlReplacement.getDynamicConfigServerUrl() == null
diff --git a/common/host-side/tradefed/tests/src/com/android/compatibility/common/tradefed/targetprep/DynamicConfigPusherTest.java b/common/host-side/tradefed/tests/src/com/android/compatibility/common/tradefed/targetprep/DynamicConfigPusherTest.java
index 55b8e20f..06968ae3 100644
--- a/common/host-side/tradefed/tests/src/com/android/compatibility/common/tradefed/targetprep/DynamicConfigPusherTest.java
+++ b/common/host-side/tradefed/tests/src/com/android/compatibility/common/tradefed/targetprep/DynamicConfigPusherTest.java
@@ -248,13 +248,9 @@ public class DynamicConfigPusherTest {
return super.mergeConfigFiles(
localConfigFile, apfeConfigInJson, moduleName, device);
}
-
- @Override
- String resolveUrl(String suiteName) throws TargetSetupError {
- return null;
- }
};
OptionSetter setter = new OptionSetter(mPreparer);
+ setter.setOptionValue("has-server-side-config", "false");
setter.setOptionValue("config-filename", "moduleName");
setter.setOptionValue("extract-from-resource", "true");
// Look up the file under that name instead of the config-filename