summaryrefslogtreecommitdiff
path: root/src/main/webapp
diff options
context:
space:
mode:
authorRyan Campbell <ryanjcampbell@google.com>2017-09-27 12:34:57 -0700
committerRyan Campbell <ryanjcampbell@google.com>2017-09-27 12:34:57 -0700
commit677cb4ccb8212131a3daaaba17ac758f7a39b24d (patch)
tree1e6783f0d1c76f906e9d7b03aa7eb9e48f215806 /src/main/webapp
parent4f8d7b9a8e50fcc2c1a459e4ebfaee3978e4dd85 (diff)
downloaddashboard-677cb4ccb8212131a3daaaba17ac758f7a39b24d.tar.gz
Prevent acknowledgment of non-existent test.
Prevent the user from creating a test acknowledgment for a test that doesn't exist. Test: staging Bug: 67002174 Change-Id: Ib3e5bb048165f1a22e84d1e3bd68b9e55b124569
Diffstat (limited to 'src/main/webapp')
-rw-r--r--src/main/webapp/js/test_acknowledgments.js3
1 files changed, 3 insertions, 0 deletions
diff --git a/src/main/webapp/js/test_acknowledgments.js b/src/main/webapp/js/test_acknowledgments.js
index da47870..9732297 100644
--- a/src/main/webapp/js/test_acknowledgments.js
+++ b/src/main/webapp/js/test_acknowledgments.js
@@ -18,6 +18,7 @@
var _isModalOpen = false;
var _isReadOnly = true;
+ var _allTestsSet = new Set();
var _allBranches = [];
var _allDevices = [];
@@ -381,6 +382,7 @@
$.fn.testAcknowledgments = function(
allTests, allBranches, allDevices, testAcknowledgments, readOnly) {
var self = $(this);
+ _allTestsSet = new Set(allTests);
_allBranches = allBranches;
_allDevices = allDevices;
_isReadOnly = readOnly;
@@ -407,6 +409,7 @@
btn.appendTo(btnWrapper);
btnWrapper.appendTo(searchRow);
btn.click(function() {
+ if (!_allTestsSet.has(input.val())) return;
var ack = createAcknowledgment(undefined, input.val());
ack.hide().prependTo(acks);
showModal(ack, undefined, input.val());