diff options
author | Young Gyu Park <younggyu@google.com> | 2018-04-25 17:19:50 +0900 |
---|---|---|
committer | Young Gyu Park <younggyu@google.com> | 2018-04-25 17:19:50 +0900 |
commit | 7fd2dc253e185933d762b1b5f437023c4149d768 (patch) | |
tree | 764d8cd68486f51ca00bb37203d36f8e4bf1bb3c /src/main | |
parent | cee84c5938fed8110fed69ddb4b7f9ca0ab4486f (diff) | |
download | dashboard-7fd2dc253e185933d762b1b5f437023c4149d768.tar.gz |
Infra log download bug fix.
Test: go/vts-web-staging/show_plan_release?plan=vts&type=suite&page=1
Bug: 78430670
Change-Id: I292f5b7cbf42bcae172feac932af1cb21f65c13d
Diffstat (limited to 'src/main')
-rw-r--r-- | src/main/java/com/android/vts/servlet/ShowGcsLogServlet.java | 3 | ||||
-rw-r--r-- | src/main/webapp/WEB-INF/jsp/show_suite_release.jsp | 23 |
2 files changed, 15 insertions, 11 deletions
diff --git a/src/main/java/com/android/vts/servlet/ShowGcsLogServlet.java b/src/main/java/com/android/vts/servlet/ShowGcsLogServlet.java index 121493a..340edfe 100644 --- a/src/main/java/com/android/vts/servlet/ShowGcsLogServlet.java +++ b/src/main/java/com/android/vts/servlet/ShowGcsLogServlet.java @@ -117,9 +117,10 @@ public class ShowGcsLogServlet extends BaseServlet { } else { String pathInfo = request.getPathInfo(); if (Objects.nonNull(pathInfo)) { - if (pathInfo.equalsIgnoreCase("download")) { + if (pathInfo.equalsIgnoreCase("/download")) { downloadHandler(request, response); } else { + logger.log(Level.INFO, "Path Info => " + pathInfo); logger.log(Level.WARNING, "Unknown path access!"); } } else { diff --git a/src/main/webapp/WEB-INF/jsp/show_suite_release.jsp b/src/main/webapp/WEB-INF/jsp/show_suite_release.jsp index 65c08a1..8cf9500 100644 --- a/src/main/webapp/WEB-INF/jsp/show_suite_release.jsp +++ b/src/main/webapp/WEB-INF/jsp/show_suite_release.jsp @@ -137,6 +137,11 @@ "> <c:out value="${testSuiteResultEntity.passedTestCaseCount}"></c:out>/<c:out value="${testSuiteResultEntity.passedTestCaseCount + testSuiteResultEntity.failedTestCaseCount}"></c:out> </span> + <c:if test="${!testSuiteResultEntity.bootSuccess}"> + <span class="indicator right center red"> + Infra Error + </span> + </c:if> </div> <div class="col s5"> <span class="suite-test-run-metadata"> @@ -153,18 +158,16 @@ <div class="col s12"> <span class="suite-test-run-metadata"> <b>Result Log Path: </b> - <c:set var="logPath" value="${fn:replace(testSuiteResultEntity.resultPath, 'gs://vts-report/', '')}"/> - <a href="show_gcs_log?path=${logPath}"> - <c:out value="${logPath}"></c:out> - </a> + <c:set var="logPath" value="${fn:replace(testSuiteResultEntity.resultPath, 'gs://vts-report/', '')}"/> + <a href="show_gcs_log?path=${logPath}"> + <c:out value="${logPath}"></c:out> + </a> <br> <b>Infra Log Path: </b> - <c:if test="${!testSuiteResultEntity.bootSuccess}"> - <c:set var="infraLogPath" value="${fn:replace(testSuiteResultEntity.infraLogPath, 'gs://vts-report/', '')}"/> - <a href="show_gcs_log/download?file=${infraLogPath}"> - <c:out value="${infraLogPath}"></c:out> - </a> - </c:if> + <c:set var="infraLogPath" value="${fn:replace(testSuiteResultEntity.infraLogPath, 'gs://vts-report/', '')}"/> + <a href="show_gcs_log/download?file=${infraLogPath}"> + <c:out value="${infraLogPath}"></c:out> + </a> <br> </span> </div> |