diff options
| author | Siva Velusamy <vsiva@google.com> | 2015-08-03 18:43:03 -0700 |
|---|---|---|
| committer | Siva Velusamy <vsiva@google.com> | 2015-08-03 18:43:06 -0700 |
| commit | f60d841470d66803d06eac6ccabd7738b3bcf67e (patch) | |
| tree | 550e353a9273fefacca0df25845ca2a93fd86de6 /android | |
| parent | a8293775d548da831993be955249a60fea8c5984 (diff) | |
| download | idea-f60d841470d66803d06eac6ccabd7738b3bcf67e.tar.gz | |
Pass in throwable when calling Log.error
Log.error without a throwable simply creates a new throwable.
But if we do that, all the stack traces point to a location
in Logger.java. Instead, we create the Throwable where the
error is logged.
Change-Id: Iccb3940f10ad3c8b5603e868025efe6fd23a75a3
Diffstat (limited to 'android')
| -rw-r--r-- | android/src/com/android/tools/idea/databinding/BrUtil.java | 2 | ||||
| -rw-r--r-- | android/src/com/android/tools/idea/npw/TemplateParameterStep2.java | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/android/src/com/android/tools/idea/databinding/BrUtil.java b/android/src/com/android/tools/idea/databinding/BrUtil.java index 2dd27b0c4ca..14314807a4f 100644 --- a/android/src/com/android/tools/idea/databinding/BrUtil.java +++ b/android/src/com/android/tools/idea/databinding/BrUtil.java @@ -56,7 +56,7 @@ public class BrUtil { } else if (isBooleanGetter(psiMethod)) { propertyName = name.subSequence(2, name.length()); } else { - LOG.error("@Bindable associated with method must follow JavaBeans convention %s", psiMethod.getName()); + LOG.error("@Bindable associated with method must follow JavaBeans convention %s", new Throwable(), psiMethod.getName()); return null; } char firstChar = propertyName.charAt(0); diff --git a/android/src/com/android/tools/idea/npw/TemplateParameterStep2.java b/android/src/com/android/tools/idea/npw/TemplateParameterStep2.java index fdb7925e4d3..b8b189dd451 100644 --- a/android/src/com/android/tools/idea/npw/TemplateParameterStep2.java +++ b/android/src/com/android/tools/idea/npw/TemplateParameterStep2.java @@ -762,9 +762,9 @@ public class TemplateParameterStep2 extends DynamicWizardStepWithDescription { } } catch (CircularParameterDependencyException exception) { - LOG.error("Circular dependency between parameters in template %1$s, participating parameters: %2$s", myCurrentTemplate.getTitle(), + LOG.error("Circular dependency between parameters in template %1$s, participating parameters: %2$s", exception, + myCurrentTemplate.getTitle(), Joiner.on(", ").join(exception.getParameterIds())); - LOG.error(exception); } } finally { |