diff options
| author | Charlie Tsai <chartsai@google.com> | 2022-07-25 12:13:01 +0100 |
|---|---|---|
| committer | Charlie Tsai <chartsai@google.com> | 2022-07-25 12:20:01 +0100 |
| commit | 8ca2b856e199353bda4f9a2b0e060023dd0dd306 (patch) | |
| tree | 461c93fac6c42f5cc36be442f159e9ffa9719687 /designer | |
| parent | a4a279555d4154ee96eaa0d84dc70ead76e138de (diff) | |
| download | idea-8ca2b856e199353bda4f9a2b0e060023dd0dd306.tar.gz | |
Make shared issue panel tab not pinnable
Follow the behaviours of current file tab and project errors tab,
remove the pinnable option from shared issue panel tab.
Fixes: 239966145
Test: Add regression test
Change-Id: I3fb1cccb17310f759092020a74372f600d177dfb
Diffstat (limited to 'designer')
| -rw-r--r-- | designer/src/com/android/tools/idea/common/error/IssuePanelService.kt | 1 | ||||
| -rw-r--r-- | designer/testSrc/com/android/tools/idea/common/error/IssuePanelServiceTest.kt | 9 |
2 files changed, 10 insertions, 0 deletions
diff --git a/designer/src/com/android/tools/idea/common/error/IssuePanelService.kt b/designer/src/com/android/tools/idea/common/error/IssuePanelService.kt index 0d967c7c8d6..c069f4443e3 100644 --- a/designer/src/com/android/tools/idea/common/error/IssuePanelService.kt +++ b/designer/src/com/android/tools/idea/common/error/IssuePanelService.kt @@ -124,6 +124,7 @@ class IssuePanelService(private val project: Project) { sharedIssuePanel = issuePanel contentFactory.createContent(issuePanel.getComponent(), "Design Issue", true).apply { + isPinnable = false sharedIssueTab = this isCloseable = false contentManager.addContent(this@apply) diff --git a/designer/testSrc/com/android/tools/idea/common/error/IssuePanelServiceTest.kt b/designer/testSrc/com/android/tools/idea/common/error/IssuePanelServiceTest.kt index 023bb342221..3b06fd54ab4 100644 --- a/designer/testSrc/com/android/tools/idea/common/error/IssuePanelServiceTest.kt +++ b/designer/testSrc/com/android/tools/idea/common/error/IssuePanelServiceTest.kt @@ -254,6 +254,15 @@ class IssuePanelServiceTest { FileEditorManager.getInstance(rule.project).openFile(layoutFile.virtualFile, true) assertEquals("Layout and Qualifiers", service.getSharedIssuePanelTabTitle()) } + + @Test + fun testIssuePanelNotPinnable() { + service.setSharedIssuePanelVisibility(true) + + val manager = toolWindow.contentManager + val tab = manager.getContent(manager.contentCount - 1)!! + assertFalse(tab.isPinnable) + } } class TestToolWindowManager(private val project: Project) |