summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-06-29Merge cherrypicks of ['googleplex-android-review.googlesource.com/23852331'] ↵studio-2022.3.1studio-mainAndroid Build Coastguard Worker
into studio-giraffe-release. Change-Id: Id99b13dfbf7e52848be216f16d6cd29d70f1ad49
2023-06-29Add new Giraffe features to the Update DialogSaurabh Chaudhary
Bug: 289045661 (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:2fa535c21fc25b05760b3d5f180b83729d6c95b0) Merged-In: I311c16eab5cf0441884de0a8a00a67d192c154bf Change-Id: I311c16eab5cf0441884de0a8a00a67d192c154bf
2023-06-29Snap for 10406761 from 29e4d4b1b472818cf3f40df648051aed74ce828e to ↵Android Build Coastguard Worker
studio-giraffe-release Change-Id: I1ad68c2393e3848f7651d0562f2027d617822a40
2023-06-28Updated WNA config for Giraffe Stable.Saurabh Chaudhary
Bug: 289045661 Change-Id: I95f2cd58ab999ee406617e4856b1b08e1adb3415
2023-06-27Update WNA Configs for Giraffe Stable.Saurabh Chaudhary
Bug: 289045661 Change-Id: I0623aed563dcd6525037ec945336861fadd094a6 Test: N/A
2023-06-27Update BUILD version to Giraffe StableSaurabh Chaudhary
Bug: b/289045661 Change-Id: I52d5ef077a17851fa2ff04deff13afde8932fde8 Test: na
2023-06-15Amend Live Edit doc URLChester Hsieh
Fixes: 278779839 Test: manual Change-Id: I56bb58afab96096941e3d1fd63640d4e6a12dcb2 (cherry picked from commit 02a0eb1c30b1b26b1c559a0b4332c0a6e094b432)
2023-06-14Snap for 10318363 from 386c598c870bd675be09b375012c712a59d7e1b3 to ↵studio-2022.3.1-rc1Android Build Coastguard Worker
studio-giraffe-release Change-Id: I64f6c228899b120ada6ecfce8a4037c9bc508bff
2023-06-14Bump Android Studio Version and BUILD to AS 2022.3.1 RC 1Shilpa Bambore Ramachandrarao
Bug: b/285195710 Test: na Change-Id: Iab411728785cecc2eefde1028ec04786e693c780
2023-06-13Snap for 10306948 from cd1e4ead771a042a8e2cf61375dd422f6e815230 to ↵Android Build Coastguard Worker
studio-giraffe-release Change-Id: I52d558bca600b43d73378b3d3ce240cb1c73f5e3
2023-06-08LE: Detect R8 min-api misreadFabien Sanglard
R8 returns -1 when a dex file contains markers containing no min-api. We need to filter these out. Test: LiveEditAppTest Bug: 283737440 Change-Id: I22eddfcf93497a67d94fb946f22fbc6b7653bc54
2023-06-06Merge cherrypicks of ['googleplex-android-review.googlesource.com/23503056', ↵Android Build Coastguard Worker
'googleplex-android-review.googlesource.com/23570402'] into studio-giraffe-release. Change-Id: I1c524cdf730938d9725b6838bc7321a5a425af46
2023-06-06Workaround for compose uiPeter Xu
This allows compose inspector to pull compose-ui libraries with the correct artifact id "ui-android" when the version is greater than or equal to "1.5.0-beta01". Test: added new test. Bug: 284998242 (cherry picked from commit fa92d337e45253bc8bf1c9f498becf67c551acc9) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:1384fbf75eb850b8d29a1f265fdd33064da0b03e) Merged-In: I87411cbfc02128dd49ea2b0755fbdba07aa1c5d4 Change-Id: I87411cbfc02128dd49ea2b0755fbdba07aa1c5d4
2023-06-06Update Kotlinc in JPS to version 1.8.21Matthew Gharrity
Bug: 283858241 Test: JPS build ("Build Project" in the IDE) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:b6c5365bc2b9b69342b6b0895cf062adaab3b9dd) Merged-In: Ic95b9c3f15bd148b5077e2369f0ca17c8eee8732 Change-Id: Ic95b9c3f15bd148b5077e2369f0ca17c8eee8732
2023-06-06Workaround for compose uiPeter Xu
This allows compose inspector to pull compose-ui libraries with the correct artifact id "ui-android" when the version is greater than or equal to "1.5.0-beta01". Test: added new test. Bug: 284998242 Change-Id: I87411cbfc02128dd49ea2b0755fbdba07aa1c5d4 (cherry picked from commit fa92d337e45253bc8bf1c9f498becf67c551acc9)
2023-06-02Update Kotlinc in JPS to version 1.8.21Matthew Gharrity
Bug: 283858241 Test: JPS build ("Build Project" in the IDE) Change-Id: Ic95b9c3f15bd148b5077e2369f0ca17c8eee8732
2023-06-01Update test expectations after commit a2da5eaRaluca Sauciuc
Bug: 285195710 Test: N/A Change-Id: I4f6c7108687a65a4c0734ce7bf0bb53aa7389e00
2023-05-31Snap for 10233704 from 052d9e4ea5407ebfaf80ed67d6be44a9eff0e1ee to ↵Android Build Coastguard Worker
studio-giraffe-release Change-Id: I6eaeb03eebe089bd26e1776783ed2e0a9d78e5fb
2023-05-31Remove checkConfiguration in BaseActionPolina Koval
checkConfiguration can be potentially long operation and because update of ApplyChangesAction was moved to BGT in I15ff410f245b1ad294786b7697142840eae2b8d1 it has conflict with UI thread over read lock. We didn't have checkConfiguration in BaseAction before Flamingo, it was introduced to make AC and ACC more accurate than they used to be. But benefits it provides are outweighed by the UI freeze. This commit reverts back to the old system where AC and ACC are not blocked if the configuration is invalid. Instead, when the user tries to execute them, a popup with an error message is displayed. Fixes: 284169566 Test: make configuration invalid and try to AC, observe notification with exception Change-Id: I10cf71994872207460e15c1c2446d92f7fac75e8
2023-05-31[lint] Use comments for suppression in Kotlin ScriptChristophe Rhodes
Using annotations has problems both regarding where to apply the annotation, and also for importing it. Bug: 284086015 Test: probably should add one Change-Id: Ibb99c9a530fa71024ec361a42642dbd817eddf9d
2023-05-31Disable privacy sandbox SDK support in AGP 8.1.xHakan Mehmed
To avoid confusion. Bug: 284150391 Test: Updated integration tests Change-Id: I7886e5f3365bdcf9a7f78abe925dd45c4fa61113
2023-05-30LE: Improve error condition detectionFabien Sanglard
The current implementation fails if an apk contains no min-api marker. But that could be the case of a split app with multiple apks. Solution: Don't fail if an apk features no min-api marker. Instead, inspect the whole app markers at the end of the scannning process. Bug: 283737440 Test: NA Change-Id: Id56dee30d0b0058aad04b49b18f8ca15f1e00330 (cherry picked from commit e57688ccec0c55f832c67a59f6f3a82333923fba)
2023-05-30Bump Android Studio Version and BUILD to AS 2022.3.1 Beta 5Shilpa Bambore Ramachandrarao
Bug: b/284308247 Test: na Change-Id: I5e3190579d70b19d55d29b9667a3f6061d07ec85
2023-05-30LE: Improve error message for multiple min-apiFabien Sanglard
We have received bug report containing only vaguealy actionable info. Adding all the minAPI detected should help a little bit. Test: NA Bug: 283737440 Change-Id: I5d145870c8ce6284708bd453d16bdbc7ba51a56e
2023-05-26Fix UpdateTestAdam Damiano
After restarting Android Studio, the test tries re-attaching to the Android Studio process. This was taking longer than 30 seconds. As a result, I increased the timeout to 120 seconds. This brought the failure rate from ~95% to 0%. Strangely, the test always succeeded for me locally even with the original timeout, although I couldn't run anywhere near the same number of times locally. Fixes: 284193142 Test: UpdateTest Change-Id: I6351d2db0b21d53b3b255db2b0ca806d936c7b93 (cherry picked from commit 5c9890c670da4b6585fbe2510c371181b16b5596)
2023-05-20Snap for 10162340 from 2f8bf6c300b0be9847ece7f2f8e742b0a0a86405 to ↵Android Build Coastguard Worker
studio-giraffe-release Change-Id: Id63b004cad0f6a3bbeca85d2992c069df1b0a952
2023-05-19Snap for 10155421 from a98cd4a6b9ffe66aae044906b878185452bded2c to ↵Android Build Coastguard Worker
studio-giraffe-release Change-Id: I9d635a1e294618416de9b8f755034b43976c1f29
2023-05-18Remove mask in SVGs to improve tool window iconsChris Sinco
Test: Visual inspection of build generated by presubmit Bug: n/a Change-Id: Ie908be8cd10332e8880bd6b709227ae6e0e4ae8e (cherry picked from commit daa2321a42a06d83814ec6cb5714ce4caf212d25)
2023-05-15Fix Live Edit indicator for non-debuggable appsChester Hsieh
AGP is setting the debuggability of the APK to false when we launch with "Profile with low overhead". This change is not reflected in the AndroidModel. And since parsing the APK is too big of a change at the current time, we are just going to work around the Profiler for now, and will follow up with a proper refactor to use the manifest as source of truth (as tracked by the TODO). TODO: 281742972 Fixes: 280460949 Test: run with "Profile with low overhead" or in Release Change-Id: I4f572c1e25964775d269ce762fc328c9835050dc
2023-05-15Remove the Settings Sync pluginMatthew Gharrity
This plugin does not work in Android Studio because it requires JetBrains login services. Bug: 267070185 Change-Id: I0a1c668c079ed88b7561ddcab031f3082d0bd6d0
2023-05-15Snap for 10129055 from 3910f1083caaf224bab7068309fac4fb45fc9c57 to ↵Android Build Coastguard Worker
studio-giraffe-release Change-Id: Ie54d90b796f6eee2d109ff8c95e016c464e0708b
2023-05-12Update Giraffe branch name project for the IDEChristophe Rhodes
Change-Id: I1b8c314c1689644aa7e1a21b82b89f93d2692bda
2023-05-12Add parenthesis for shortcut in Live Edit reminderChester Hsieh
Fixes: 275383412 Test: visual inspection Change-Id: I8ca27420a77022517aac9d09418c4c6b366c3497 (cherry picked from commit e2eae2d03801f8b13774433d55af9af879b4c144)
2023-05-11Add `constraintlayout` to the bundled Android dictionaryChristophe Rhodes
Bug: 279113773 Test: manual Change-Id: Ie8b46a2dd19ed905aa20541e05121cf885b2a8fa
2023-05-10Clear toRunTrampolinedFedor Kudasov
to prevent retaining the classloader through the static object Bug: 280302860 Test: SingleComposePreviewElementRendererTest Change-Id: I21b098827fe7a454d57fdf264428d1eeedc1b540 (cherry picked from commit 027c44020e4718996f69d975ecb8becc881fce8c)
2023-05-10Increasing JAR cache file size to 20MbDiego Perez
This is to allow for enough space to cache regular R.jar in medium sized projects while we work on a better way of handling this cache. Test: N/A Bug: 278783531 (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:25dd5f5350c75f0a711031efc550688794b76100) Merged-In: Id9bd693386a89ca004967a60f192141feff04e88 Change-Id: Id9bd693386a89ca004967a60f192141feff04e88
2023-05-10Add a quick check for glance preview annotationsFedor Kudasov
Bug: 281132834 Test: GlancePreviewElementFinderTest Change-Id: I9132d3257fe112ed89cdefb3c78c30fd8ab834de (cherry picked from commit ceebe2ec2c7e0cb4b0ba4f27ff7ff3380baf4cb7)
2023-05-09[AUA] Fix crash in upgrading pluginsChristophe Rhodes
It's possible to have dependency definitions that, for whatever reason, not only have unresolvable versions but have those versions be entirely missing from the dependency's model. That state is probably not entirely valid (though there are indications in the referenced bug that it is somehow working for some people) but we should not allow that state to cause the upgrader for GradlePlugins to crash. How does it crash? An innocuous-looking toString() on a GradlePropertyModel can return `null` if the model is missing, which we can cause to happen if we have a map-style dependency (as naturally comes from using Version Catalogs with missing fields). Defend against this by checking that the model's ValueType is STRING, which will be the case if we resolve it to a String value (whereupon toString() will return that String). If we don't resolve it to a String value, it is correct for us to ignore that dependency as we cannot know what to do with it. Bug: 278102583 Test: added Change-Id: I0ef24565ec738fe0f077cce7709ab35dcd1185a5
2023-05-04Bump Android Studio Version and BUILD to AS 2022.3.1 Beta 4Shilpa Bambore Ramachandrarao
Bug: b/280613575 Test: na Change-Id: Ifddb2725e394edd9ba421c35da2a85bcc0dcbf41
2023-05-04Snap for 10062547 from a9293e222f0a04b7e184608b85b3bdefd8721d61 to ↵Android Build Coastguard Worker
studio-giraffe-release Change-Id: I6fdbb88604f3765d376df69ee36ba3f381290807
2023-05-03Use StudioIcons in sync downloads UIMaksim Lazeba
The icon used originally, AllIcons.RunConfigurations.TestPassed, provides "Test passed" tooltip automatically which is unwanted. Bug: 275359429 Test: N/A Change-Id: Ia9b8c2c584f46a0f9617e86d996c1cd4d79898f5 (cherry picked from commit f925d879c1c4aa20355f276a994513cae936095d)
2023-05-02Don't attempt to send very long clipboard text to deviceSergey Prigogin
Test: no new tests because asserting that the clipboard synchronization message was not sent requires waiting for few seconds, which is undesirable. Bug: 279975549 Change-Id: I0dc9b0e42ff21b14877e2b6d48798209562e46f5 (cherry picked from commit 585dac399321c2cc69c7f136f6683749c859e2ef)
2023-05-01Check if project supports compose before notifyingChester Hsieh
Fixes: 279225979 Test: manual Change-Id: I14f4d91536af35d6ad010aaba5c41702c3a9fd99 (cherry picked from commit 5438ec95b9f0bc42cd86ec520b569370ff316b68)
2023-05-01Fix Live Edit notification linksChester Hsieh
Live Edit notification was not showing the "Configure Settings" option. Fixes: 275383412 Test: visual inspection Change-Id: I76e96f0be212294f3f961bb5087617f1d0d6171e (cherry picked from commit ac83814bc16762a7070b504abb9e778fed8ad76d)
2023-04-28Use JTextArea with plain text to show licenses textEugene Yakavets
Replace JLabel and HTML content, that is slow for large text. ALso minor cleanup of (soon to be) deprecated stuff Test: Manually verified Bug: 278928452 Change-Id: Ie93105231b54f836313e6cc2bfd14cafe5ecc438 (cherry picked from commit 37b5f8b80d8943047bb2b9d6aad8bf041b5c4820)
2023-04-28Disable Android Gutter Icons in Essentials modeJacob Logsdon
These aren't an essential part of the editor and are expensive to calculate and display. Fixes: 275239567 Change-Id: I614ca6b946ebdbfa96b9635d3c6f4459520ac1f7 (cherry picked from commit ecd3e3e5b50065aec1bde750905503ffce671603)
2023-04-28Handle containerized annotations in Compose PreviewLuis Santiago Re
MultiPreviews imported from a library will put repeated annotations of a given class (e.g. Previews) inside a container. These change makes the Preview finding logic aware of such cases. Bug: 279162835 Test: AnnotationFileComposePreviewElementFinderGradleTest Change-Id: Ifb68a25cf93ec48c630cefae2095ad6e29381edc (cherry picked from commit fc25a4345412d54cb8d8d46dc2ac89d693dacdac)
2023-04-27Bump Android Studio Version and BUILD to AS 2022.3.1 Beta 3Shilpa Bambore Ramachandrarao
Bug: b/279666712 Test: na Change-Id: I45920aa8c75dbe614a193d46076cac06ae966c8a
2023-04-27Snap for 10022809 from 50f63067d5b31091bad085c7d75d7c1f1de128f4 to ↵studio-2022.3.1-beta2Android Build Coastguard Worker
studio-giraffe-release Change-Id: Ia998b09851e80c15b06d06c26319df15573d4818
2023-04-27Distinguish between any Kotlin file and Kotlin sourceChristophe Rhodes
Our custom editor has special, additional behaviours for Kotlin (and Java) files as part of Android Source. However, Kotlin Script build files also have a fileType of KotlinFileType.INSTANCE, and so are potentially accepted by the custom editor provider. Restrict isSourceFileType() to return true on Kotlin files with an extension of the default Kotlin extension (only) as well as all Java files in the project. Bug: 278839073 Test: manual Change-Id: Ie8ec69995288ee72e9de974b8c8468ddbc164c1c (cherry picked from commit b1282150d8bc91af897bb7e88fdb5bc330e848d3)
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-21 18:43:58 +0000