Age | Commit message (Collapse) | Author |
|
This CL adds quickfixes for various lint checks. There is one new
quickfix implementation, which takes a regular expression and a new
value, and searches the lint error location for the given regular
expression and if found, replaces the regular expression group with
the given value. This quickfix implementation is used to implement 25
lint checks, since a lot of lint checks are very simple (e.g. for "you
should use 5sp instead of 5dp for this textSize" the lint check just
has to replace sp with dp). This CL also replaces some existing lint
quickfixes, such as the deprecated plugin name quickfix (which had its
own custom implementation) with a usage of the new regexp lint fix.
There are a couple of other notable special cases:
- As part of our migration to remove dynamic gradle versions by default,
the quickfix for dynamic gradle version will look up the currently
implied verison from a dynamic version and insert that
- The deprecated lint fix had been disabled a long time ago with a comment
that IntelliJ already handles deprecation warnings, but these do different
things (IntelliJ flags deprecated Java code, the lint one flags deprecated
XML tags and attributes) so I restored it.
Change-Id: Ie5b35c3c99d839224716a5296956fadf7622abe2
|
|
The severity of the wrong id detector increased from warning to
error recently, so update the unit test. Also register the recently
added NFC detector in lint as an IntelliJ inspection.
Change-Id: If938ac9a0ea204657803c50948ffcaa0d199063a
|
|
Change-Id: I3aab4c6fe90c8ddef14c2ffd12250e0a34701725
|
|
|
|
Change-Id: Id4d0b5092844f1da42ea8bd70e8133467a1043ea
|
|
|
|
This lint check flags activity/service/content provider classes
that are not abstract or anonymous and have not been registered
in the manifest.
Change-Id: Id46b858510df044bdd32aa324b3fd52cef1c6a2e
|
|
This changeset adds a replacement detector for lint's API check.
This check will replace the basic lint one and operates on Java
source rather than .class files, using the PSI directly.
Change-Id: I202835c5ace31e8580bd8a69dce57ad88648784b
|
|
This avoids using the slower lint command line XML parser
(which is there because lint needs character offsets for
elements and attributes, which normal XML parsers don't provide).
Also some other cleanup; hook up the lint log messages to
the IntelliJ log, remove some API workarounds, etc.
Change-Id: I906b81d21fbf880eccb4d5fee9ebeb6a6bf90a15
|
|
Adds a new bridge from IntelliJ's PSI to Lombok AST. This lets us drop
the much slower default LombokParser and indirectly use the PSI data
for lint checks instead, which is a lot faster.
Because of that, this check also adds Java checks back into the
background annotator. It also fixes the routine which determines
whether a lint check requires batch mode to consider lint's analysis
scopes, and it tweaks the error output to use HTML markup (for keyword
highlighting, URLs etc).
It also tweaks the R file header comment.
Change-Id: I04f45d5f318cb5459daec34c5ff49b5b628fb5c4
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|