summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-06-29Snap for 10406761 from 840699e770d4a4c57a871a0d51790df8918e433c to ↵studio-2022.3.1studio-mainAndroid Build Coastguard Worker
studio-giraffe-release Change-Id: I0d091b84c28f4f8b06507dab99809159179923dc
2023-06-27Update tools/base versions for Giraffe FinalSaurabh Chaudhary
Bug: 289045661 Change-Id: Id7e8bb117550f7127a24344dcfc73fa27be7e32d Test: na
2023-06-21Update sort for locale configMicah Jo
The sorting of the locales should be done earlier in the task to produce deterministic output. Bug: 281825213 Test: LocaleConfigGenerationTest Change-Id: Icab8509ad1e4ce4f6ab732b787bcf5cdfeda791a (cherry picked from commit 7e49702cfcdfae5a87cf36bdc2f6a0f0752ee32c)
2023-06-14Make lint + KAPT compatible with configuration cachingScott Pollom
ModelBuilder::getGeneratedSourceFoldersFileCollectionForUnitTests was resolving files in some cases. Fixes: 285320724 Test: LintConfigurationCacheTest Change-Id: Icf3aa27eaae2e781fc8799ea0976e3f449c45b93
2023-06-13Snap for 10306948 from ca9f48daa0b99dcedbe741d9c69475fa3951b59a to ↵studio-2022.3.1-rc1Android Build Coastguard Worker
studio-giraffe-release Change-Id: I019e6487519e64d235dc127c78cb5072a991dc87
2023-06-06Merge cherrypicks of ['googleplex-android-review.googlesource.com/23502723', ↵Android Build Coastguard Worker
'googleplex-android-review.googlesource.com/23502724', 'googleplex-android-review.googlesource.com/23586004'] into studio-giraffe-release. Change-Id: Id77ac0fd95098feae0088fb464d38303a2f104d2
2023-06-06Always add the task provider in variant api operations output pathsAmr Afifiy
Not having the task provider in the output path of the `toAppend` operation meant that all of the directory will be an input to the next operation. Meanwhile, `toTransform` operation will also output to the same directory that is used as an input, which creates a case where the output of a task is an input to the same task on the next run, and also incorrect clean runs since some files will be processed as an input after they were just been created. This caused an issue with plugins that use the transform APIs (like Hilt) and plugins that use the toAppend variant API. Fixes: 285170632 Test: AsmTransformApiInstrumentationTest.testInteractionWithVariantApi (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:4b894b3d7a78b06f08b860aeeb223e058adeac06) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:ca9f48daa0b99dcedbe741d9c69475fa3951b59a) Merged-In: Iee3a81b66d2057f2d3c821e3e6a02e252a5b9600 Change-Id: Iee3a81b66d2057f2d3c821e3e6a02e252a5b9600
2023-06-06Adapt DependenciesAnalyzerTest to Kotlinc 1.8.21Matthew Gharrity
Bug: 283858241 Test: DependenciesAnalyzerTest (cherry picked from commit 7e517cc3d16a0797af4bc385c5b965e5206a8293) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:5b331e3c0a48403cf3a1e765cd5be707edf439c6) Merged-In: Ic28b89210bf1fd05786f223dae6bcb160925244e Change-Id: Ic28b89210bf1fd05786f223dae6bcb160925244e
2023-06-06Update Kotlinc in Bazel to version 1.8.21Matthew Gharrity
Bug: 283858241 Test: bazel build (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:99c519ea1a54f20924de1e68bbe13a9ca30eca76) Merged-In: I1355dc1250c348ce2e621e3779741d50da98b09f Change-Id: I1355dc1250c348ce2e621e3779741d50da98b09f
2023-06-06Always add the task provider in variant api operations output pathsAmr Afifiy
Not having the task provider in the output path of the `toAppend` operation meant that all of the directory will be an input to the next operation. Meanwhile, `toTransform` operation will also output to the same directory that is used as an input, which creates a case where the output of a task is an input to the same task on the next run, and also incorrect clean runs since some files will be processed as an input after they were just been created. This caused an issue with plugins that use the transform APIs (like Hilt) and plugins that use the toAppend variant API. Fixes: 285170632 Test: AsmTransformApiInstrumentationTest.testInteractionWithVariantApi (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:4b894b3d7a78b06f08b860aeeb223e058adeac06) Merged-In: Iee3a81b66d2057f2d3c821e3e6a02e252a5b9600 Change-Id: Iee3a81b66d2057f2d3c821e3e6a02e252a5b9600
2023-06-02Adapt DependenciesAnalyzerTest to Kotlinc 1.8.21Matthew Gharrity
Bug: 283858241 Test: DependenciesAnalyzerTest Change-Id: Ic28b89210bf1fd05786f223dae6bcb160925244e (cherry picked from commit 7e517cc3d16a0797af4bc385c5b965e5206a8293)
2023-06-02Update Kotlinc in Bazel to version 1.8.21Matthew Gharrity
Bug: 283858241 Test: bazel build Change-Id: I1355dc1250c348ce2e621e3779741d50da98b09f
2023-05-31Update tools/base versions for Giraffe RC 1Shilpa Bambore Ramachandrarao
Bug: b/285195710 Test: na Change-Id: I1cd90147fb40fc1374098a101525f4a28b4914c6
2023-05-31Snap for 10233704 from 376f4210fcc034e583b4a6bf7d2ba82b2c5b3b1d to ↵Android Build Coastguard Worker
studio-giraffe-release Change-Id: Ia7a8762e0225e158aa2595a590511be744230f4a
2023-05-31[lint] Define the commentPrefix for .kts filesChristophe Rhodes
Needed in order to suppress issues in Kotlin Script Gradle build configuration files. Bug: 284086015 Test: n/a Change-Id: Id0f759b231b96adad4d3e22558a4f9d637877fb9
2023-05-31Disable privacy sandbox SDK support in AGP 8.1.xChris Warrington
To avoid confusion. Bug: 284150391 Test: Updated integration tests Change-Id: I0a66afc94f4ac38f12124fb788cc89f730257408
2023-05-26Update tools/base versions for Giraffe Beta 5Shilpa Bambore Ramachandrarao
Bug: b/284308247 Test: na Change-Id: I69eb2064311c17f86b37c6ffcf1282ed8d209857
2023-05-24Snap for 10190289 from 3e3c1070f1ba9aca3fe4d8010275175da546fcad to ↵Android Build Coastguard Worker
studio-giraffe-release Change-Id: Id034b22be5de0160a9536184542e1ca0d6e90b58
2023-05-23Hide emulator control behind a proeprty flagErwin Jansen
Add new BooleanOption ENABLE_EMULATOR_CONTROL, the property: android.experimental.enableEmulatorControl=true needs to be present for the feature to be enabled. This indicates that a user understand it is an experimental feature. * EmulatorControlConfig is enabled only if both emulatorControl.enable and ENABLE_EMULATOR_CONTROL are true * Add new test cases for EmulatorControlConfig Test: Additional unit tests Test: Starting a Gradle Daemon, 4 incompatible and 2 stopped Daemons could not be reused, use --status for details FAILURE: Build failed with an exception. * What went wrong: Could not determine the dependencies of task ':app:connectedAndroidTest'. > Could not create task ':app:connectedDebugAndroidTest'. > EmulatorControl is an experimental feature and it is disabled by default. Please add android.experimental.androidTest.enableEmulatorControl=true in your gradle.properties to opt-in to this feature. Bug: 276981739 Change-Id: I8c17c12fe71329f48c449194d62293d2da416cab
2023-05-23Fix file creation issue during configuration timebingran
This CL uses ValueSource to help us create file or directory during configuration time without causing configuration cache miss. Bug: 278767328 Test: existing Change-Id: I9066834a315171f0dc424a5a66009e785c898ba2
2023-05-23Don't warn about UpsideDownCakePrivacySandboxChris Warrington
Bug: 283007771 Bug: 283930471 Test: Manual for now (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:8cf5aacab7a0007a9a847663e9fb842ef156407a) Merged-In: If473641f2710e9dc257b05729b8ec27102fd1298 Change-Id: If473641f2710e9dc257b05729b8ec27102fd1298
2023-05-19Snap for 10155421 from c1bfe5c0ce1758dd321ea673b3750bc019a0ee1d to ↵Android Build Coastguard Worker
studio-giraffe-release Change-Id: I7c08a9690f2dc95cc0ed285483c40d16b5a301f7
2023-05-16Update wording for KAPT/KSP lint warningMárton Braun
Test: GradleDetectorTest Bug: 279954562 Change-Id: I778e8832b64763d7f9f7de52a562a3fdf396ee94 (cherry picked from commit 4f8ab8c96bc1865b9981064ec4326eee270a859b)
2023-05-15Snap for 10129055 from fe237b0f6cadfc638e51e9cace6c1eee5dab4940 to ↵Android Build Coastguard Worker
studio-giraffe-release Change-Id: Ic5093099cd39c9e31d397f1a47d45cc4fa652c50
2023-05-12Disallow resourceConfigurations withMicah Jo
automatic locale generation. There is an issue when both are enabled where languages not specified in resConfig but generated in locale config will use the default language instead of the specified one. Bug: 277901729 Test: LocaleConfigGenerationTest Change-Id: I66f510c05977fc147bf78e3da9843e816acbb854 (cherry picked from commit f8a2cbbc3258ff6412fc11e1bace98fe944f2b35)
2023-05-12Remove SDK extension check for warningMicah Jo
The SDK extension should not be considered when displaying a warning about the compileSdk and maxSdk version mismatch. Bug: 276807774 Test: SdkParsingUtilsTest (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:170d88148ee984165e646ea8a795a95b6320dfe3) Merged-In: Iea3ca37f9f95ee2a35c0b65a428f94bb4b36089a Change-Id: Iea3ca37f9f95ee2a35c0b65a428f94bb4b36089a
2023-05-11Stop using android.enableGlobalSyntheticsGenerationbingran
This is a follow up CL for ag/22930592 which didn't fully move us to using the new optional flag. Bug: 254510065 Test: existing Change-Id: Ibf2d466feb69345338079372edf5642639b5ab59 (cherry picked from commit d97d6ab38122580e87d017c97a46f68442416020)
2023-05-11Mitigate perf regression caused by globals for debug buildbingran
This CL introduces an optional boolean flag to control both api modeling and global synthetics. When flag is set, we fully respect the flag. When the flag is not set, which is the default mode, api modeling and global synthetics are enabled in release build. For debug build, api modeling is disabled and global synthetics is only enabled when java language level is 14+. In this way, release build can benefits from api modeling and the debug build can avoid unnecessary performance penalty. To address the performance issue completely, b/279930074 is filed. Bug: 254510065 Test: GlobalSyntheticsFeatureTest, etc Change-Id: Ie813e4d16a340f28ed3fb3fd2f1dc666738ebc89
2023-05-08revert turning on profile rewriting.Jerome Dochez
Since wildcards expansion is not happening in Giraffe, we should not have R8 profile rewriting turned on by default. Bug: 280740818 Test: Existing Change-Id: Icdb9c1b718e0d8bc909d3698e22c7136bde68de6
2023-05-05Merge cherrypicks of ['googleplex-android-review.googlesource.com/23035156', ↵Android Build Coastguard Worker
'googleplex-android-review.googlesource.com/23046996'] into studio-giraffe-release. Change-Id: Id701f8a2a71e7c2ca953204f27af633a69dd8857
2023-05-05Fix grammaticalGender handling in the Layout InspectorJens Ole Lauridsen
A field named grammaticalGender was in fake-android. The real android has a Java "getGrammaticalGender" function. The byte code for calling that method is different from accessing a field with the same name. This caused Android U apps to crash when using the Layout Inspector. Fix this. Fixes: 280847078 Test: N/A (cherry picked from commit 1ec5103d4ddeeee4f5311a5c5f237c1eefa828b6) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:831c25e7dff2656172662af1ec42983276e84442) Merged-In: Ibb9fd1fb2230e1a1b1c0cfc633d26813a7683ca9 Change-Id: Ibb9fd1fb2230e1a1b1c0cfc633d26813a7683ca9
2023-05-05Limit number of parallel AndroidLintTask tasksScott Pollom
Previously, AGP limited the number of parallel AndroidLintAnalysisTask tasks to prevent OOMs, but AndroidX continues to get OOMs. This change also limits the number of parallel AndroidLintTask tasks. Bug: 280110060 Test: existing (cherry picked from commit cf571ff516a04f1a2d39d328cde80b4771c8b9cd) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:0e3878b87663eafd744ea67388ce78e43f4b3073) Merged-In: I01584ecf505c9495be32049699dc80d206d4337a Change-Id: I01584ecf505c9495be32049699dc80d206d4337a
2023-05-04Fix grammaticalGender handling in the Layout InspectorJens Ole Lauridsen
A field named grammaticalGender was in fake-android. The real android has a Java "getGrammaticalGender" function. The byte code for calling that method is different from accessing a field with the same name. This caused Android U apps to crash when using the Layout Inspector. Fix this. Fixes: 280847078 Test: N/A Change-Id: Ibb9fd1fb2230e1a1b1c0cfc633d26813a7683ca9 (cherry picked from commit 1ec5103d4ddeeee4f5311a5c5f237c1eefa828b6)
2023-05-04Limit number of parallel AndroidLintTask tasksScott Pollom
Previously, AGP limited the number of parallel AndroidLintAnalysisTask tasks to prevent OOMs, but AndroidX continues to get OOMs. This change also limits the number of parallel AndroidLintTask tasks. Bug: 280110060 Test: existing Change-Id: I01584ecf505c9495be32049699dc80d206d4337a (cherry picked from commit cf571ff516a04f1a2d39d328cde80b4771c8b9cd)
2023-05-04Snap for 10062547 from 022d76ceb9c0f3575c12e5c76db7e5b82a7c311a to ↵Android Build Coastguard Worker
studio-giraffe-release Change-Id: Ifc7f22921ad7895323783f49cb4a49f63bc8a3e7
2023-05-03Update tools/base versions for Giraffe Beta 4Shilpa Bambore Ramachandrarao
Bug: b/280613575 Test: na Change-Id: Ib04e477cabb86fd3f882ec1103dadfc0e2260104
2023-04-28Don't pass mapping file to profgen when profiles are rewritten by R8Jerome Dochez
When art profiles are rewritten by r8, AGP should not pass the obfuscation mapping file to profgen as it is already optimized. Bug: 271549736 Test: Added unit test Change-Id: I984c3adf708d8569d9a0733b6c92036eb7b43a84 (cherry picked from commit beec81af38d58d8bd5f10ee82b5802dd4e14fee3)
2023-04-27Snap for 10022809 from 7b80ccb622378b8f3c98ef65ff6013418a2b18ab to ↵studio-2022.3.1-beta2Android Build Coastguard Worker
studio-giraffe-release Change-Id: I9a84d534ad19cf805ab7d26ca365fac8cb0b40b4
2023-04-26Update tools/base versions for Giraffe Beta 3Shilpa Bambore Ramachandrarao
Bug: b/278921192 Test: na Change-Id: I4440655e767975fd765b6086c23952a1db120048
2023-04-25Add const that links to the Kotlin DSL migration pageTakeshi Hagikura
Fixes: 276496681 Test: Manually verified Change-Id: I6020e1742f86e7d2f1e2bc617d23a5e0a7ed4478
2023-04-19Update tools/base versions for Giraffe Beta 2Shilpa Bambore Ramachandrarao
Bug: b/278921192 Test: na Change-Id: If18d779969318501d29b3b4c2aeded681f31f892
2023-04-17Adapt to Kotlin 1.8.20Matthew Gharrity
Note: K2 code paths are removed instead of adapted, since K2 is disabled in Giraffe anyway. Bug: 277382383 Change-Id: Icddf17ba2fbb0a39edd7d45828a3c07f92e52fe4
2023-04-13[AAKB] Add missing More Info link for UnsafeImplicitIntentLaunch lint and ↵Bessie Jiang
remove two obsolete links When we drafted the list of lints to map to AAKB articles, this lint check was added afterwards. It neatly ties to the Implicit Intent Hijacking article, hence why we are adding it in now since it was incorrectly missed. This is also removing two moreInfo links that will not have AAKB articles written for them (AuthLeak, BidiSpoofing) and thus should be removed as they are obsolete. Bug: 265266604 Fixes: 265287976 Fixes: 265287977 Test: manual Change-Id: Ie0452a8e1b604cac23192b8f2ae42305baba2333
2023-04-12Merge cherrypicks of ['googleplex-android-review.googlesource.com/22579695'] ↵Android Build Coastguard Worker
into studio-giraffe-release. Change-Id: I12551c5e0778b45f638aab6f74588e2325ab6b70
2023-04-12Hide emulator control behind a proeprty flagErwin Jansen
Add new BooleanOption ENABLE_EMULATOR_CONTROL, the property: android.experimental.enableEmulatorControl=true needs to be present for the feature to be enabled. This indicates that a user understand it is an experimental feature. * EmulatorControlConfig is enabled only if both emulatorControl.enable and ENABLE_EMULATOR_CONTROL are true * Add new test cases for EmulatorControlConfig Test: Additional unit tests Test: Starting a Gradle Daemon, 4 incompatible and 2 stopped Daemons could not be reused, use --status for details FAILURE: Build failed with an exception. * What went wrong: Could not determine the dependencies of task ':app:connectedAndroidTest'. > Could not create task ':app:connectedDebugAndroidTest'. > EmulatorControl is an experimental feature and it is disabled by default. Please add android.experimental.androidTest.enableEmulatorControl=true in your gradle.properties to opt-in to this feature. Bug: 276981739 (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:1d1df569c8ba8916bb98426e85f0898028f6c1ef) Merged-In: I8c17c12fe71329f48c449194d62293d2da416cab Change-Id: I8c17c12fe71329f48c449194d62293d2da416cab
2023-04-12Snap for 9922117 from 6ee8c911d804154ae89139325eb1ed0c0c627626 to ↵Android Build Coastguard Worker
studio-giraffe-release Change-Id: I8e17f639c9670dfcdf294d5a62e97ca269908a2f
2023-04-11 Update tools/base versions for Giraffe Beta 1Shilpa Bambore Ramachandrarao
Bug: b/276922248 Test: na Change-Id: I87873c7bf2ffaba1da1fcc0cd077f0b4bdd5d69e
2023-04-06Deprecate getAvdPathJuan C Nuno
Bug: Not applicable Test: Not applicable Change-Id: Iede5af28dc535883e28077a05e5065931f8ed915
2023-04-05Add ResponseWriter testVidish Naik
Bug: 244740956 Test: Added Change-Id: Ief8aeb167f068d507968d5eb602a6acac0f6fae9
2023-04-05change newly added API to include dimension.Jerome Dochez
Last week, a new API in VariantSelector was added to only use the flavor name to select variants. This worked fine because today we do not allow to reuse the same flavor name in different dimension since they are part of the same NamedDomainObjectContainer. However in the future, this may change so we should not make such assumptions. Added the dimension parameter so Groovy users are not forced into using a Pair<> which is clumsy. Test: unit test. Bug: N/A Change-Id: I17be7fe66556aafceb804a25097a3d334a52b250
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-21 07:41:31 +0000