summaryrefslogtreecommitdiff
path: root/build-system/integration-test/application/src/test/java/com/android/build/gradle/integration/application/LocaleConfigGenerationTest.kt
blob: f52a654492b299b7dfb3b4c75f8dce01ceccfa31 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
/*
 * Copyright (C) 2022 The Android Open Source Project
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *      http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

package com.android.build.gradle.integration.application

import com.android.build.gradle.integration.common.fixture.GradleTestProject
import com.android.build.gradle.integration.common.fixture.GradleTestProject.Companion.builder
import com.android.build.gradle.integration.common.fixture.app.MinimalSubProject
import com.android.build.gradle.integration.common.fixture.app.MultiModuleTestProject
import com.android.build.gradle.integration.common.truth.ScannerSubject
import com.android.build.gradle.integration.common.utils.TestFileUtils
import com.android.build.gradle.tasks.LOCALE_CONFIG_FILE_NAME
import com.android.testutils.truth.PathSubject
import com.android.testutils.truth.ZipFileSubject
import com.android.utils.FileUtils
import com.google.common.truth.IterableSubject
import com.google.common.truth.Truth
import org.junit.Rule
import org.junit.Test
import java.io.File

private val DEFAULT = null // default locale
private val ES = Locale("b+es+ES", "es-ES")
private val ZH = Locale("b+zh+Hans+SG", "zh-Hans-SG")
private val EN_GB = Locale("en-rGB", "en-GB")
private val EN_US = Locale("b+en+US", "en-US")
private val RU = Locale("b+ru+RU", "ru-RU")
private val PT = Locale("b+pt+BR", "pt-BR")
private val JP = Locale("b+jp+JP", "jp-JP")

private data class Locale(
    val code: String,
    val text: String
)

class LocaleConfigGenerationTest {

    private val localeListPath = "build/intermediates/supported_locale_list"
    private val localeConfigPath = "build/generated/res/localeConfig"
    private val mergedManifestPath = "build/intermediates/merged_manifest"

    private val app =
        MinimalSubProject.app("com.example.app")
            .withFile(
                "src/main/res/xml/user_locale_config.xml",
                // language=xml
                """
                    <locale-config xmlns:android="http://schemas.android.com/apk/res/android">
                        <locale android:name="en-US"/>
                        <locale android:name="zh-TW"/>
                        <locale android:name="pt"/>
                        <locale android:name="fr"/>
                        <locale android:name="zh-Hans-SG"/>
                    </locale-config>
                """.trimIndent()
            )

    private val lib1 =
        MinimalSubProject.lib("com.example.lib1")

    private val lib2 =
        MinimalSubProject.lib("com.example.lib2")

    @get:Rule
    val project = builder()
        .fromTestApp(
            MultiModuleTestProject.builder()
                .subproject(":app", app)
                .subproject(":lib1", lib1)
                .subproject(":lib2", lib2)
                .dependency(app, lib1)
                .dependency(lib1, lib2)
                .build()
        ).create()

    private fun addLocaleForVariantDimension(
        project: GradleTestProject,
        locale: Locale?,
        variantDimension: String = "main",
        addResFile: Boolean = true
    ) {
        val file =
            if (locale == DEFAULT) {
                project.file("src/${variantDimension}/res/values/strings.xml")
            } else {
                project.file("src/${variantDimension}/res/values-${locale.code}/strings.xml")
            }
        val text = locale?.text ?: "en-US"

        file.parentFile.mkdirs()
        if (addResFile) {
            file.writeText(
                // language=xml
                """
                <?xml version="1.0" encoding="utf-8"?>
                <resources>
                    <string name="test">"Hello $text"</string>
                </resources>
                """.trimIndent()
            )
        }
    }

    private fun GradleTestProject.withUserLocaleConfig(): GradleTestProject {
        TestFileUtils.searchAndReplace(
            this.getSubproject("app").file("src/main/AndroidManifest.xml"),
            "<application />",
            "<application android:localeConfig=\"@xml/user_locale_config\"/>"
        )
        return this
    }

    private fun GradleTestProject.withLocales(
        appLocales: List<Locale?>,
        lib1Locales: List<Locale?>,
        lib2Locales: List<Locale?>
    ): GradleTestProject {
        appLocales.forEach {
            addLocaleForVariantDimension(this.getSubproject("app"), it)
        }
        lib1Locales.forEach {
            addLocaleForVariantDimension(this.getSubproject("lib1"), it)
        }
        lib2Locales.forEach {
            addLocaleForVariantDimension(this.getSubproject("lib2"), it)
        }
        return this
    }

    private fun buildDsl(
        generateLocaleConfig: Boolean,
        defaultLocale: String? = "en-US",
        addFlavor: Boolean = false,
        addResourcesProperties: Boolean = true
    ) {
        var dslString =
            // language=groovy
            """

                android {
                    androidResources {
                        generateLocaleConfig $generateLocaleConfig
                    }
                }

            """.trimIndent()
        if (addFlavor)  {
            // language=groovy
            dslString += """
                android.flavorDimensions "language"
                android.productFlavors {
                        tokyo {
                            dimension "language"
                        }
                        london {
                            dimension "language"
                        }
                }
                """.trimIndent()
        }

        project.getSubproject("app").buildFile.appendText(dslString)

        if (addResourcesProperties) {
            var fileText = ""
            if (defaultLocale != null) {
                fileText =
                    """
                        unqualifiedResLocale=$defaultLocale
                    """.trimIndent()
            }

            project.getSubproject("app").file("src/main/res/resources.properties")
                .writeText(fileText)
        }
    }

    private fun localeListFromFile(file: File): List<String> {
        return file.readLines()
    }

    private fun localeListFromXml(xml: File): List<String> {
        val locales = mutableListOf<String>()
        xml.readLines().forEach {
            if (it.trim().startsWith("<locale android:name")) locales.add(it.split("\"")[1])
        }
        return locales
    }

    private fun assertLocaleList(subproject: String, variant: String): IterableSubject {
        return Truth.assertThat(
            localeListFromFile(
                project.getSubproject(subproject).file("$localeListPath/$variant/supported_locales.txt"))
        )
    }

    private fun assertLocaleConfig(variant: String): IterableSubject {
        return Truth.assertThat(
            localeListFromXml(
                project.getSubproject("app").file("$localeConfigPath/$variant/xml/$LOCALE_CONFIG_FILE_NAME.xml"))
        )
    }

    @Test
    fun `Test with default behavior locale config is not generated`() {
        // no DSL

        val result = project.withLocales(
            appLocales = listOf(DEFAULT, ES, ZH, EN_GB),
            lib1Locales = listOf(EN_US, ES, RU),
            lib2Locales = listOf(PT)
        ).executor().run("assembleDebug")

        Truth.assertThat(result.didWorkTasks).doesNotContain(":app:generateDebugLocaleConfig")

        PathSubject.assertThat(project.getSubproject("app").file(localeConfigPath))
            .doesNotExist()
        PathSubject.assertThat(project.getSubproject("app").file(localeListPath))
            .doesNotExist()
        PathSubject.assertThat(project.getSubproject("lib1").file(localeListPath))
            .doesNotExist()
        PathSubject.assertThat(project.getSubproject("lib2").file(localeListPath))
            .doesNotExist()
        PathSubject.assertThat(project.getSubproject("app")
            .file("$mergedManifestPath/debug/AndroidManifest.xml"))
            .doesNotContain("android:localeConfig")
    }

    @Test
    fun `Test with feature off user locale config is not changed and locale config is not generated`() {
        buildDsl(generateLocaleConfig = false)

        val result = project.withLocales(
            appLocales = listOf(DEFAULT, ES, ZH, EN_GB),
            lib1Locales = listOf(EN_US, ES, RU),
            lib2Locales = listOf()
        ).withUserLocaleConfig().executor().run("assembleDebug")

        Truth.assertThat(result.didWorkTasks).doesNotContain(":app:generateDebugLocaleConfig")
        PathSubject.assertThat(project.getSubproject("app").file(localeConfigPath))
            .doesNotExist()
        PathSubject.assertThat(project.getSubproject("app").file(localeListPath))
            .doesNotExist()
        PathSubject.assertThat(project.getSubproject("lib1").file(localeListPath))
            .doesNotExist()
        PathSubject.assertThat(project.getSubproject("lib2").file(localeListPath))
            .doesNotExist()
        val mergedManifest = project.getSubproject("app")
            .file("$mergedManifestPath/debug/AndroidManifest.xml")
        PathSubject.assertThat(mergedManifest)
            .contains("""android:localeConfig="@xml/user_locale_config"""")
        PathSubject.assertThat(mergedManifest)
            .doesNotContain(LOCALE_CONFIG_FILE_NAME)
    }

    // Test that locale lists are created in app and lib
    // Test that locale config xml is created in app only
    // Test that generated locale config with no user generated alternative is present in manifest
    @Test
    fun `Test task runs and xml and locale lists are generated`() {
        buildDsl(generateLocaleConfig = true)

        val result = project.withLocales(
            appLocales = listOf(DEFAULT, ES, ZH, EN_GB),
            lib1Locales = listOf(EN_US, ES, RU),
            lib2Locales = listOf(PT)
        ).executor().run("assembleDebug")

        Truth.assertThat(result.didWorkTasks).contains(":app:generateDebugLocaleConfig")
        // Test that all expected files are generated
        PathSubject.assertThat(project.getSubproject("app").file(localeConfigPath)).exists()
        PathSubject.assertThat(project.getSubproject("app").file(localeListPath)).exists()
        PathSubject.assertThat(project.getSubproject("lib1").file(localeListPath)).exists()
        PathSubject.assertThat(project.getSubproject("lib2").file(localeListPath)).exists()

        // Test that manifest change is present
        val mergedManifest = project.getSubproject("app")
            .file("$mergedManifestPath/debug/AndroidManifest.xml")
        PathSubject.assertThat(mergedManifest)
            .contains("""android:localeConfig="@xml/$LOCALE_CONFIG_FILE_NAME""")
        PathSubject.assertThat(mergedManifest)
            .doesNotContain("""android:localeConfig="@xml/user_locale_config""")

        // Test that xml is not generated in libs
        PathSubject.assertThat(project.getSubproject("lib1")
            .file("build/generated/res/localeConfig")).doesNotExist()
        PathSubject.assertThat(project.getSubproject("lib2")
            .file("build/generated/res/localeConfig")).doesNotExist()
    }

    // Test that all locales are present in final xml (including non-overlapping fallback locale)
    @Test
    fun `Test locales contain all supported locales`() {
        buildDsl(generateLocaleConfig = true, defaultLocale = "de-DE")

        project.withLocales(
            appLocales = listOf(DEFAULT, ES, ZH, EN_GB),
            lib1Locales = listOf(RU),
            lib2Locales = listOf(PT)
        ).execute("assembleDebug")

        assertLocaleList("app", "debug")
            .containsExactly("de-DE", "es-ES","zh-Hans-SG","en-GB")
        assertLocaleList("lib1", "debug")
            .containsExactly("ru-RU")
        assertLocaleList("lib2", "debug")
            .containsExactly("pt-BR")
        // Final xml adds default locale (de-DE)
        assertLocaleConfig("debug")
            .containsExactly("de-DE", "es-ES","zh-Hans-SG","en-GB", "ru-RU", "pt-BR")
    }

    @Test
    fun `Test locales are not duplicated`() {
        buildDsl(generateLocaleConfig = true)

        project.withLocales(
            appLocales = listOf(DEFAULT, ES, ZH, EN_GB),
            lib1Locales = listOf(ES, RU), // Duplicate ES
            lib2Locales = listOf(PT, EN_US) // Duplicate EN_US (default)
        ).execute("assembleDebug")

        assertLocaleList("app", "debug")
            .containsExactly("en-US", "es-ES","zh-Hans-SG","en-GB")
        assertLocaleList("lib1", "debug")
            .containsExactly("es-ES", "ru-RU")
        assertLocaleList("lib2", "debug")
            .containsExactly("pt-BR", "en-US")
        assertLocaleConfig("debug")
            .containsExactly("en-US", "es-ES", "zh-Hans-SG","en-GB", "ru-RU", "pt-BR")
    }

    @Test
    fun `Test user locale config produces conflict`() {
        buildDsl(generateLocaleConfig = true)

        val result = project.withLocales(
            appLocales = listOf(DEFAULT, ES, ZH, EN_GB),
            lib1Locales = listOf(EN_US, ES, RU),
            lib2Locales = listOf()
        ).withUserLocaleConfig().executor().expectFailure().run("assembleDebug")

        ScannerSubject.assertThat(result.stderr).contains(
            "Locale config generation was requested but user locale config is present in manifest"
        )
    }

    @Test
    fun `Test invalid default locale`() {
        buildDsl(generateLocaleConfig = true, defaultLocale = "testLocale")

        val result = project.withLocales(
            appLocales = listOf(DEFAULT),
            lib1Locales = listOf(),
            lib2Locales = listOf()
        ).executor().expectFailure().run("assembleDebug")

        ScannerSubject.assertThat(result.stderr).contains(
            "The default locale \"testLocale\" from the file " +
            "\"${project.getSubproject("app").file("src/main/res/resources.properties").path}\" " +
            "is invalid."
        )
    }

    @Test
    fun `Test fallback locale is mandatory`() {
        buildDsl(generateLocaleConfig = true, defaultLocale = null)

        val result = project.withLocales(
            appLocales = listOf(DEFAULT),
            lib1Locales = listOf(),
            lib2Locales = listOf()
        ).executor().expectFailure().run("assembleDebug")

        ScannerSubject.assertThat(result.stderr).contains("No locale is set for unqualified res.")
    }

    @Test
    fun `Test missing resources properties file`() {
        buildDsl(generateLocaleConfig = true, addResourcesProperties = false)

        val result = project.withLocales(
            appLocales = listOf(DEFAULT),
            lib1Locales = listOf(),
            lib2Locales = listOf()
        ).executor().expectFailure().run("assembleDebug")

        ScannerSubject.assertThat(result.stderr).contains("No resources.properties file found.")
    }

    @Test
    fun `Test multiple resources properties files error`() {
        buildDsl(generateLocaleConfig = true)

        project.getSubproject("app").buildFile.appendText("""
            android.sourceSets.main.res.srcDirs = ['src/main/res', 'src/main/res1']
        """.trimIndent())

        val newResourcesPropertiesFile =
            project.getSubproject("app").file("src/main/res1/resources.properties")

        FileUtils.createFile(newResourcesPropertiesFile,
            """
                unqualifiedResLocale=es-ES
            """.trimIndent()
        )

        val result = project.withLocales(
            appLocales = listOf(DEFAULT),
            lib1Locales = listOf(DEFAULT),
            lib2Locales = listOf(DEFAULT)
        ).executor().expectFailure().run("assembleDebug")

        ScannerSubject.assertThat(result.stderr).contains(
            "Multiple resources.properties files found with different unqualifiedResLocale values.")
    }

    @Test
    fun `Test error when using resource configurations`() {
        buildDsl(generateLocaleConfig = true)

        project.getSubproject("app").buildFile.appendText("""
            android.defaultConfig.resourceConfigurations += ["en"]
        """.trimIndent())

        val result = project.executor().expectFailure().run("assembleDebug")

        ScannerSubject.assertThat(result.stderr).contains(
            "You cannot specify languages in resource configurations when " +
            "automatic locale generation is enabled. To use resource configurations, " +
            "please provide the locale config manually: " +
            "https://d.android.com/r/tools/locale-config")
    }

    @Test
    fun `Test that locale config xml is in apk res`() {
        buildDsl(generateLocaleConfig = true)

        project.withLocales(
            appLocales = listOf(DEFAULT),
            lib1Locales = listOf(DEFAULT),
            lib2Locales = listOf(DEFAULT)
        ).execute("assembleDebug")

        ZipFileSubject.assertThat(
            project.getSubproject("app").file("build/outputs/apk/debug/app-debug.apk")) {
            it.contains("res/xml/$LOCALE_CONFIG_FILE_NAME.xml")
        }
    }

    @Test
    fun `Test that locale config xml is in bundle res`() {
        buildDsl(generateLocaleConfig = true)

        project.withLocales(
            appLocales = listOf(DEFAULT),
            lib1Locales = listOf(DEFAULT),
            lib2Locales = listOf(DEFAULT)
        ).execute("bundleDebug")

        ZipFileSubject.assertThat(
            project.getSubproject("app").file("build/outputs/bundle/debug/app-debug.aab")) {
            it.contains("base/res/xml/$LOCALE_CONFIG_FILE_NAME.xml")
        }
    }

    @Test
    fun `Test build flavor res are included`() {
        buildDsl(generateLocaleConfig = true, addFlavor = true)

        addLocaleForVariantDimension(project.getSubproject("app"), JP, "tokyo")
        addLocaleForVariantDimension(project.getSubproject("app"), EN_GB, "london")

        project.withLocales(
            appLocales = listOf(DEFAULT),
            lib1Locales = listOf(ES),
            lib2Locales = listOf(PT)
        ).execute("assembleDebug")

        // london flavor res should not be included
        assertLocaleList("app", "tokyoDebug").containsExactly("en-US", "jp-JP")
        assertLocaleConfig("tokyo/debug").containsExactly("en-US", "es-ES", "pt-BR", "jp-JP")
    }

    @Test
    fun `Test emptyResFoldersAreIgnored`() {
        buildDsl(generateLocaleConfig = true)

        addLocaleForVariantDimension(project.getSubproject("app"), JP, addResFile = false)
        project.withLocales(
            appLocales = listOf(DEFAULT),
            lib1Locales = listOf(ES),
            lib2Locales = listOf(PT)
        ).execute("assembleDebug")

        assertLocaleList("app", "debug").containsExactly("en-US")
        assertLocaleConfig("debug").containsExactly("en-US", "es-ES", "pt-BR")
    }

    @Test
    fun `Test AAR dependency locales not present in app locale config`() {
        buildDsl(generateLocaleConfig = true)

        val libAarDir = File(project.projectDir, "lib1-aar").also { it.mkdirs() }
        File(libAarDir, "build.gradle").writeText(
            """
                configurations.maybeCreate("default")
                artifacts.add("default", file('lib1.aar'))
            """.trimIndent()
        )
        project.withLocales(
            appLocales = listOf(DEFAULT),
            lib1Locales = listOf(ES),
            lib2Locales = listOf(PT)
        ).executor().run(":lib1:assembleDebug")

        project.getSubproject("lib1")
            .getAar("debug") { aar ->
                FileUtils.copyFile(aar.file.toFile(), File(libAarDir, "lib1.aar"))
            }

        TestFileUtils.searchAndReplace(
            project.getSubproject("app").buildFile,
            "implementation project(':lib1')",
            "implementation project(':lib1-aar')",
        )
        TestFileUtils.appendToFile(project.settingsFile, "include ':lib1-aar'")

        project.withLocales(
            appLocales = listOf(DEFAULT),
            lib1Locales = listOf(ES),
            lib2Locales = listOf(PT)
        ).execute("assembleDebug")

        assertLocaleConfig("debug").containsExactly("en-US")
    }
}