Age | Commit message (Collapse) | Author |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
No significant changes except for debuggers.
LGTM=nigeltao
R=nigeltao
CC=golang-codereviews
https://codereview.appspot.com/166720043
|
|
LGTM=gmlewis
R=gmlewis
CC=golang-codereviews
https://codereview.appspot.com/160730043
|
|
This only implements marshaling. Unmarshaling is much fiddlier,
and it's not even clear that people care about that, so I'm punting
it to a later date.
LGTM=gmlewis
R=gmlewis
CC=golang-codereviews
https://codereview.appspot.com/156950045
|
|
LGTM=gmlewis
R=gmlewis
CC=golang-codereviews
https://codereview.appspot.com/159790043
|
|
fields.
This is a bit of an edge case. All other valid defaults appear as
non-empty strings, but we need to distinguish [default=""] for string/bytes
to uphold the SetDefaults contract.
LGTM=djd
R=djd
CC=golang-codereviews
https://codereview.appspot.com/125100044
|
|
int32 needs special handling; negative values need to be sign-extended,
so need to be converted from uint32 back to int32 before converting to
uint64 for the varint encoding step (yielding 10 bytes).
uint32 is simpler and stays as just encoding the bit pattern,
and thus never takes more than 5 bytes.
This permits upgrading int32 fields to int64, and matches C++.
LGTM=nigeltao
R=nigeltao
CC=golang-codereviews
https://codereview.appspot.com/114190043
|
|
We were emitting an obsolete function and missing a couple of real methods.
LGTM=nigeltao
R=nigeltao
CC=golang-codereviews
https://codereview.appspot.com/111470043
|
|
LGTM=nigeltao
R=nigeltao
CC=golang-codereviews
https://codereview.appspot.com/101370050
|
|
It used to be used for a MarshalJSON method on enum types,
but we no longer generate them.
LGTM=r
R=r
CC=golang-codereviews
https://codereview.appspot.com/85240045
|
|
These kinds of comments in .proto files usually aren't there
but if they are then they are valuable to have in the generated code.
LGTM=r
R=r
CC=golang-codereviews
https://codereview.appspot.com/65860043
|
|
Most people won't see these, but they improve how proto packages are rendered by godoc.
R=r
CC=golang-codereviews
https://codereview.appspot.com/51030043
|
|
This will results in JSON output using numbers for enum values, which
is consistent with the default behaviour of other languages.
UnmarshalJSON is left to handle both numeric and symbolic values.
R=r
CC=golang-dev
https://codereview.appspot.com/14601045
|
|
first enum value, not zero.
This makes Go consistent with C++/Java/Python.
Fixes #43.
R=r
CC=golang-dev
https://codereview.appspot.com/13501049
|
|
Fixes #42.
R=r
CC=golang-dev
https://codereview.appspot.com/12767050
|
|
R=r
CC=golang-dev
https://codereview.appspot.com/12436045
|
|
This doesn't use every comment, but just the ones that I thought
would be most useful to someone reading the generated code, namely
those attached to these things:
- messages
- message fields
- enums
- enum values
R=r
CC=golang-dev
https://codereview.appspot.com/11889044
|
|
Regenerating descriptor.pb.go also lays the path for using SourceCodeInfo in the code generator.
R=r
CC=golang-dev
https://codereview.appspot.com/11893043
|
|
This maintains the semantics that unmarshaling the concatenation of two
encoded messages is equivalent to merging those messages.
R=r
CC=golang-dev
https://codereview.appspot.com/10409046
|
|
R=r
CC=golang-dev
https://codereview.appspot.com/9117043
|
|
getters.
Also make receiver names idiomatic.
R=r
CC=golang-dev
https://codereview.appspot.com/7922045
|
|
R=adg
CC=golang-dev
https://codereview.appspot.com/7395047
|
|
R=adg
CC=golang-dev
https://codereview.appspot.com/7225068
|
|
Also add some struct field tags to work with go1.1.
R=nigeltao
CC=golang-dev
https://codereview.appspot.com/6980045
|
|
R=iant
CC=golang-dev
https://codereview.appspot.com/6883048
|
|
R=iant
CC=golang-dev
https://codereview.appspot.com/6894046
|
|
Correct copyright notice to "The Go Authors" throughout.
R=rsc, bradfitz
CC=golang-dev
http://codereview.appspot.com/6845101
|
|
They no longer get XXX_unrecognized fields, nor satisfy the proto.Message interface.
R=nigeltao, r
CC=golang-dev
http://codereview.appspot.com/6829043
|
|
message method name.
R=r
CC=golang-dev
http://codereview.appspot.com/6568051
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/6552062
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/6525044
|
|
Also a bunch of other trivial updates.
R=r
CC=golang-dev
http://codereview.appspot.com/6501064
|
|
R=adg
CC=golang-dev
http://codereview.appspot.com/6464064
|
|
R=adg
CC=golang-dev
http://codereview.appspot.com/6454155
|
|
R=r, rsc
CC=golang-dev
http://codereview.appspot.com/6458072
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/6458071
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/6351110
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/6356055
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/6369043
|
|
- Support single quoted strings.
- Allow declaring import path to hint at a package name.
R=r
CC=golang-dev
http://codereview.appspot.com/6366043
|
|
Every generated protocol buffer type now implements the proto.Message interface,
which means we can add some compile-time type safety throughout the API
as well as drop a bunch of error cases.
R=r, rsc
CC=golang-dev
http://codereview.appspot.com/6298073
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/6188053
|
|
Also picks up a tweak to the JSON tags of the XXX_ fields.
R=r
CC=golang-dev
http://codereview.appspot.com/6175045
|