diff options
| author | Alan Donovan <adonovan@google.com> | 2015-09-01 22:23:24 +0000 |
|---|---|---|
| committer | android-build-merger <android-build-merger@google.com> | 2015-09-01 22:23:24 +0000 |
| commit | df23645cfe5acc4e2ebde630396b3532c9a326f7 (patch) | |
| tree | 5f98bf6bdbd45552e72d6f589caf19c519a31c70 | |
| parent | 89bc6a7fff1f9a0c359546bb0b9a47c65381a6e6 (diff) | |
| parent | 8ccf558e8ad400746c297c66f6493427d382cfe4 (diff) | |
| download | tools-df23645cfe5acc4e2ebde630396b3532c9a326f7.tar.gz | |
cmd/callgraph: update flag docstring
automerge: 8ccf558
* commit '8ccf558e8ad400746c297c66f6493427d382cfe4':
cmd/callgraph: update flag docstring
| -rw-r--r-- | cmd/callgraph/main.go | 2 | ||||
| -rw-r--r-- | go/callgraph/static/static.go | 2 |
2 files changed, 3 insertions, 1 deletions
diff --git a/cmd/callgraph/main.go b/cmd/callgraph/main.go index 2aa9739..29179dd 100644 --- a/cmd/callgraph/main.go +++ b/cmd/callgraph/main.go @@ -42,7 +42,7 @@ import ( ) var algoFlag = flag.String("algo", "rta", - `Call graph construction algorithm, one of "rta" or "pta"`) + `Call graph construction algorithm (static, cha, rta, pta)`) var testFlag = flag.Bool("test", false, "Loads test code (*_test.go) for imported packages") diff --git a/go/callgraph/static/static.go b/go/callgraph/static/static.go index ebb183b..709bb7b 100644 --- a/go/callgraph/static/static.go +++ b/go/callgraph/static/static.go @@ -15,6 +15,8 @@ func CallGraph(prog *ssa.Program) *callgraph.Graph { cg := callgraph.New(nil) // TODO(adonovan) eliminate concept of rooted callgraph // TODO(adonovan): opt: use only a single pass over the ssa.Program. + // TODO(adonovan): opt: this is slower than RTA (perhaps because + // the lower precision means so many edges are allocated)! for f := range ssautil.AllFunctions(prog) { fnode := cg.CreateNode(f) for _, b := range f.Blocks { |