summaryrefslogtreecommitdiff
path: root/platform/platform-impl/src/com/intellij/openapi/options/ex/ConfigurableExtensionPointUtil.java
diff options
context:
space:
mode:
Diffstat (limited to 'platform/platform-impl/src/com/intellij/openapi/options/ex/ConfigurableExtensionPointUtil.java')
-rw-r--r--platform/platform-impl/src/com/intellij/openapi/options/ex/ConfigurableExtensionPointUtil.java17
1 files changed, 7 insertions, 10 deletions
diff --git a/platform/platform-impl/src/com/intellij/openapi/options/ex/ConfigurableExtensionPointUtil.java b/platform/platform-impl/src/com/intellij/openapi/options/ex/ConfigurableExtensionPointUtil.java
index 429a55b2b809..ca72bf30c541 100644
--- a/platform/platform-impl/src/com/intellij/openapi/options/ex/ConfigurableExtensionPointUtil.java
+++ b/platform/platform-impl/src/com/intellij/openapi/options/ex/ConfigurableExtensionPointUtil.java
@@ -48,7 +48,7 @@ public class ConfigurableExtensionPointUtil {
}
}
- final Map<String, ConfigurableWrapper> idToConfigurable = new HashMap<String, ConfigurableWrapper>();
+ final Map<String, ConfigurableWrapper> idToConfigurable = new LinkedHashMap<String, ConfigurableWrapper>();
for (ConfigurableEP<Configurable> ep : extensions) {
final Configurable configurable = ConfigurableWrapper.wrapConfigurable(ep);
if (isSuppressed(configurable, filter)) continue;
@@ -75,16 +75,13 @@ public class ConfigurableExtensionPointUtil {
}
}
}
- //leave only roots (i.e. configurables without parents)
- for (final Iterator<String> iterator = idToConfigurable.keySet().iterator(); iterator.hasNext(); ) {
- final String key = iterator.next();
- final ConfigurableWrapper wrapper = idToConfigurable.get(key);
- final String parentId = wrapper.getParentId();
- if (parentId != null && idToConfigurable.containsKey(parentId)) {
- iterator.remove(); // remove only processed parents
+ // add roots only (i.e. configurables without parents)
+ for (ConfigurableWrapper wrapper : idToConfigurable.values()) {
+ String parentId = wrapper.getParentId();
+ if (parentId == null || !idToConfigurable.containsKey(parentId)) {
+ result.add(wrapper);
}
}
- ContainerUtil.addAll(result, idToConfigurable.values());
return result;
}
@@ -164,7 +161,7 @@ public class ConfigurableExtensionPointUtil {
@NotNull
private static <T extends Configurable> T findConfigurable(ConfigurableEP<Configurable>[] extensions, Class<T> configurableClass) {
for (ConfigurableEP<Configurable> extension : extensions) {
- if (extension.providerClass != null || extension.instanceClass != null || extension.implementationClass != null) {
+ if (extension.canCreateConfigurable()) {
final Configurable configurable = extension.createConfigurable();
if (configurableClass.isInstance(configurable)) {
return configurableClass.cast(configurable);