1 files changed, 103 insertions, 0 deletions
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/performance/CallToSimpleSetterInClassInspectionBase.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/performance/CallToSimpleSetterInClassInspectionBase.java
new file mode 100644
index 000000000000..6e6512a8866a
--- /dev/null
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/performance/CallToSimpleSetterInClassInspectionBase.java
@@ -0,0 +1,103 @@
+/*
+ * Copyright 2000-2014 JetBrains s.r.o.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.siyeh.ig.performance;
+
+import com.intellij.psi.*;
+import com.intellij.psi.search.searches.OverridingMethodsSearch;
+import com.intellij.psi.util.PropertyUtil;
+import com.intellij.util.Query;
+import com.siyeh.InspectionGadgetsBundle;
+import com.siyeh.ig.BaseInspection;
+import com.siyeh.ig.BaseInspectionVisitor;
+import com.siyeh.ig.psiutils.ClassUtils;
+import org.jetbrains.annotations.NotNull;
+
+public class CallToSimpleSetterInClassInspectionBase extends BaseInspection {
+  @SuppressWarnings("UnusedDeclaration")
+  public boolean ignoreSetterCallsOnOtherObjects = false;
+  @SuppressWarnings("UnusedDeclaration")
+  public boolean onlyReportPrivateSetter = false;
+
+  @Override
+  @NotNull
+  public String getID() {
+    return "CallToSimpleSetterFromWithinClass";
+  }
+
+  @Override
+  @NotNull
+  public String getDisplayName() {
+    return InspectionGadgetsBundle.message("call.to.simple.setter.in.class.display.name");
+  }
+
+  @Override
+  @NotNull
+  public String buildErrorString(Object... infos) {
+    return InspectionGadgetsBundle.message("call.to.simple.setter.in.class.problem.descriptor");
+  }
+
+  @Override
+  public BaseInspectionVisitor buildVisitor() {
+    return new CallToSimpleSetterInClassVisitor();
+  }
+
+  private class CallToSimpleSetterInClassVisitor extends BaseInspectionVisitor {
+
+    @Override
+    public void visitMethodCallExpression(@NotNull PsiMethodCallExpression call) {
+      super.visitMethodCallExpression(call);
+      final PsiClass containingClass = ClassUtils.getContainingClass(call);
+      if (containingClass == null) {
+        return;
+      }
+      final PsiMethod method = call.resolveMethod();
+      if (method == null) {
+        return;
+      }
+      if (!containingClass.equals(method.getContainingClass())) {
+        return;
+      }
+      final PsiReferenceExpression methodExpression = call.getMethodExpression();
+      final PsiExpression qualifier = methodExpression.getQualifierExpression();
+      if (qualifier != null && !(qualifier instanceof PsiThisExpression)) {
+        if (ignoreSetterCallsOnOtherObjects) {
+          return;
+        }
+        final PsiType type = qualifier.getType();
+        if (!(type instanceof PsiClassType)) {
+          return;
+        }
+        final PsiClassType classType = (PsiClassType)type;
+        final PsiClass qualifierClass = classType.resolve();
+        if (!containingClass.equals(qualifierClass)) {
+          return;
+        }
+      }
+      if (!PropertyUtil.isSimpleSetter(method)) {
+        return;
+      }
+      if (onlyReportPrivateSetter && !method.hasModifierProperty(PsiModifier.PRIVATE)) {
+        return;
+      }
+      final Query<PsiMethod> query = OverridingMethodsSearch.search(method, true);
+      final PsiMethod overridingMethod = query.findFirst();
+      if (overridingMethod != null) {
+        return;
+      }
+      registerMethodCallError(call);
+    }
+  }
+}