diff options
Diffstat (limited to 'plugins/InspectionGadgets/test/com/siyeh/igtest/bugs')
4 files changed, 27 insertions, 25 deletions
diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/ResultSetIndexZeroInspection.java b/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/ResultSetIndexZeroInspection.java deleted file mode 100644 index cbb5e0eaf8a8..000000000000 --- a/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/ResultSetIndexZeroInspection.java +++ /dev/null @@ -1,14 +0,0 @@ -package com.siyeh.igtest.bugs; - -import java.sql.ResultSet; -import java.sql.SQLException; - -public class ResultSetIndexZeroInspection { - private static final int COLUMN_INDEX = 0; - - public void foo(ResultSet resultSet) throws SQLException { - resultSet.getInt(0); - resultSet.getInt(COLUMN_INDEX); - resultSet.getInt(3); - } -} diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/result_set_index_zero/ResultSetIndexZero.java b/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/result_set_index_zero/ResultSetIndexZero.java new file mode 100644 index 000000000000..de087faef79e --- /dev/null +++ b/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/result_set_index_zero/ResultSetIndexZero.java @@ -0,0 +1,21 @@ +import java.sql.PreparedStatement; +import java.sql.ResultSet; +import java.sql.SQLException; + +public class ResultSetIndexZero { + private static final int COLUMN_INDEX = 0; + + public void foo(ResultSet resultSet) throws SQLException { + resultSet.getInt(<warning descr="Use of index '0' in JDBC ResultSet">0</warning>); + resultSet.getInt(<warning descr="Use of index '0' in JDBC ResultSet">COLUMN_INDEX</warning>); + resultSet.getInt(3); + } + + void foo(PreparedStatement ps) throws SQLException { + ps.setQueryTimeout(0); + ps.setFetchDirection(0); + ps.setFetchSize(0); + ps.setMaxFieldSize(0); + ps.setMaxRows(0); + } +} diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/string_equality/StringEquality.java b/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/string_equality/StringEquality.java index d32c969b9261..17c4b5127c3b 100644 --- a/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/string_equality/StringEquality.java +++ b/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/string_equality/StringEquality.java @@ -4,7 +4,11 @@ public class StringEquality { void foo(String s, String t) { final boolean a = s == null; - final boolean b = t == s; - final boolean c = t == + final boolean b = t <warning descr="String values are compared using '==', not 'equals()'">==</warning> s; + final boolean c = t ==<EOLError descr="Expression expected"></EOLError><EOLError descr="';' expected"></EOLError> + } + + void notEquals(String s, String t) { + boolean a = s <warning descr="String values are compared using '!=', not 'equals()'">!=</warning> t; } } diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/string_equality/expected.xml b/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/string_equality/expected.xml deleted file mode 100644 index 0eb665c7cff4..000000000000 --- a/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/string_equality/expected.xml +++ /dev/null @@ -1,9 +0,0 @@ -<?xml version="1.0" encoding="UTF-8"?> -<problems> - <problem> - <file>StringEquality.java</file> - <line>7</line> - <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">String comparison using '==', instead of 'equals()'</problem_class> - <description>String values are compared using <code>==</code>, not '.equals()' #loc</description> - </problem> -</problems>
\ No newline at end of file |