diff options
Diffstat (limited to 'plugins/InspectionGadgets/test')
13 files changed, 94 insertions, 48 deletions
diff --git a/plugins/InspectionGadgets/test/com/siyeh/igfixes/style/replace_with_string/MethodCallOnString.after.java b/plugins/InspectionGadgets/test/com/siyeh/igfixes/style/replace_with_string/MethodCallOnString.after.java new file mode 100644 index 000000000000..4ced8b802fc5 --- /dev/null +++ b/plugins/InspectionGadgets/test/com/siyeh/igfixes/style/replace_with_string/MethodCallOnString.after.java @@ -0,0 +1,5 @@ +public class MethodCallOnString { + public static void main(String... args) { + int length = "ABC".length(); + } +}
\ No newline at end of file diff --git a/plugins/InspectionGadgets/test/com/siyeh/igfixes/style/replace_with_string/MethodCallOnString.java b/plugins/InspectionGadgets/test/com/siyeh/igfixes/style/replace_with_string/MethodCallOnString.java new file mode 100644 index 000000000000..2ff02036eced --- /dev/null +++ b/plugins/InspectionGadgets/test/com/siyeh/igfixes/style/replace_with_string/MethodCallOnString.java @@ -0,0 +1,6 @@ +public class MethodCallOnString { + public static void main(String... args) { + StringBuilder theBuilder<caret> = new StringBuilder("ABC"); + int length = theBuilder.toString().length(); + } +}
\ No newline at end of file diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/abstraction/declare_collection_as_interface/DeclareCollectionAsInterface.java b/plugins/InspectionGadgets/test/com/siyeh/igtest/abstraction/declare_collection_as_interface/DeclareCollectionAsInterface.java index e5c11992d86c..f21cc080de25 100644 --- a/plugins/InspectionGadgets/test/com/siyeh/igtest/abstraction/declare_collection_as_interface/DeclareCollectionAsInterface.java +++ b/plugins/InspectionGadgets/test/com/siyeh/igtest/abstraction/declare_collection_as_interface/DeclareCollectionAsInterface.java @@ -60,4 +60,14 @@ public class DeclareCollectionAsInterface <warning descr="Declaration of 'HashSet' should probably be weakened to 'java.util.Set'">HashSet</warning><String> set = new HashSet<>(); set.add("foo"); } + + public static Properties stringToProperties(String propertiesAsString) { return null; } + public static Properties stringToProperties2(String propertiesAsString) { return null; } + public static Properties stringToProperties3(String propertiesAsString) { return null; } + + void m() { + stringToProperties(""); + <error descr="Incompatible types. Found: 'java.util.Properties', required: 'java.lang.String'">String s = stringToProperties2("");</error> + <error descr="Incompatible types. Found: 'java.util.Properties', required: 'java.lang.String'">s = stringToProperties3("")</error>; + } } diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/abstraction/weaken_type/AutoClosableTest.java b/plugins/InspectionGadgets/test/com/siyeh/igtest/abstraction/weaken_type/AutoClosableTest.java index 3d9b0a2fd811..7c96abd2260c 100644 --- a/plugins/InspectionGadgets/test/com/siyeh/igtest/abstraction/weaken_type/AutoClosableTest.java +++ b/plugins/InspectionGadgets/test/com/siyeh/igtest/abstraction/weaken_type/AutoClosableTest.java @@ -31,13 +31,13 @@ class AutoClosableTest2 public static class Bar extends Foo {} public static void test() { - try (Bar bar = new Bar()) { + try (Bar <warning descr="Type of variable 'bar' may be weakened to 'com.siyeh.igtest.abstraction.weaken_type.AutoClosableTest2.Foo'">bar</warning> = new Bar()) { bar.go(); } } void dodo() throws java.io.IOException { - try (java.io.Reader reader = new java.io.FileReader("/home/steve/foo.txt")) { + try (java.io.Reader <warning descr="Type of variable 'reader' may be weakened to 'java.io.Closeable'">reader</warning> = new java.io.FileReader("/home/steve/foo.txt")) { System.out.println(reader); } } diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/abstraction/weaken_type/NumberAdderDemo.java b/plugins/InspectionGadgets/test/com/siyeh/igtest/abstraction/weaken_type/NumberAdderDemo.java index 0a009777a810..4b3547198e83 100644 --- a/plugins/InspectionGadgets/test/com/siyeh/igtest/abstraction/weaken_type/NumberAdderDemo.java +++ b/plugins/InspectionGadgets/test/com/siyeh/igtest/abstraction/weaken_type/NumberAdderDemo.java @@ -1,6 +1,6 @@ -package com.siyeh.igtest.abstraction.weaken_type; +package weaken_type; -import com.siyeh.igtest.abstraction.weaken_type.sub.NumberAdderExtension; +import weaken_type.sub.NumberAdderExtension; public class NumberAdderDemo { diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/abstraction/weaken_type/TypeMayBeWeakened.java b/plugins/InspectionGadgets/test/com/siyeh/igtest/abstraction/weaken_type/TypeMayBeWeakened.java index aeb2e1a5f811..370aba53a19c 100644 --- a/plugins/InspectionGadgets/test/com/siyeh/igtest/abstraction/weaken_type/TypeMayBeWeakened.java +++ b/plugins/InspectionGadgets/test/com/siyeh/igtest/abstraction/weaken_type/TypeMayBeWeakened.java @@ -52,7 +52,7 @@ public class TypeMayBeWeakened { foo(new WeakBoolean()); } - void foo(WeakBoolean b) { + void foo(WeakBoolean <warning descr="Type of parameter 'b' may be weakened to 'java.lang.Object'">b</warning>) { System.out.println("b: " + b); } @@ -65,7 +65,7 @@ public class TypeMayBeWeakened { FileInputStream fis=new FileInputStream("/etc/modules"); } catch(FileNotFoundException fnfex) { - IllegalArgumentException iaex=new IllegalArgumentException("Exception Message"); + IllegalArgumentException <warning descr="Type of variable 'iaex' may be weakened to 'java.lang.RuntimeException'">iaex</warning>=new IllegalArgumentException("Exception Message"); iaex.initCause(fnfex); throw iaex; } @@ -82,7 +82,7 @@ public class TypeMayBeWeakened { void foo() { Test f = new Test(); f.x++; } } - void listy(ArrayList list) { + void listy(ArrayList <warning descr="Type of parameter 'list' may be weakened to 'java.lang.Iterable'">list</warning>) { for (Object o : list) { } @@ -130,7 +130,7 @@ class MyClass { public MyClass(java.util.Date date, String[] classNames) {} - static MyClass readMyClass(final ObjectInputStream objectInput) { + static MyClass readMyClass(final ObjectInputStream <warning descr="Type of parameter 'objectInput' may be weakened to 'com.siyeh.igtest.abstraction.weaken_type.DataInput'">objectInput</warning>) { final long time = objectInput.readLong(); final int size = objectInput.readInt(); final String[] classNames = new String[size]; @@ -150,4 +150,16 @@ abstract class ObjectInputStream implements DataInput { public String readUTF() { return null; } -}
\ No newline at end of file +} +class Test implements Foo2 { + void test(Test <warning descr="Type of parameter 't' may be weakened to 'com.siyeh.igtest.abstraction.weaken_type.Foo2'">t</warning>) { + t.bar(); + } + public void bar() { + } +} +@Deprecated +interface Foo { + void bar(); +} +interface Foo2 extends Foo {}
\ No newline at end of file diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/abstraction/weaken_type/sub/NumberAdder.java b/plugins/InspectionGadgets/test/com/siyeh/igtest/abstraction/weaken_type/sub/NumberAdder.java deleted file mode 100644 index 8f15c784c12a..000000000000 --- a/plugins/InspectionGadgets/test/com/siyeh/igtest/abstraction/weaken_type/sub/NumberAdder.java +++ /dev/null @@ -1,9 +0,0 @@ -package com.siyeh.igtest.abstraction.weaken_type.sub; - -/** - * Created by IntelliJ IDEA. User: HONOURK Date: 21-Aug-2008 Time: 12:15:41 To change this template - * use File | Settings | File Templates. - */ -public interface NumberAdder { - int doSomething(); -} diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/abstraction/weaken_type/sub/NumberAdderExtension.java b/plugins/InspectionGadgets/test/com/siyeh/igtest/abstraction/weaken_type/sub/NumberAdderExtension.java deleted file mode 100644 index 21bdf2988a11..000000000000 --- a/plugins/InspectionGadgets/test/com/siyeh/igtest/abstraction/weaken_type/sub/NumberAdderExtension.java +++ /dev/null @@ -1,12 +0,0 @@ -package com.siyeh.igtest.abstraction.weaken_type.sub; - -/** - * Created by IntelliJ IDEA. User: HONOURK Date: 21-Aug-2008 Time: 12:15:41 To change this template - * use File | Settings | File Templates. - */ -public class NumberAdderExtension extends NumberAdderImpl { - @Override - public int getNumberOne() { - return super.getNumberOne(); - } -} diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/abstraction/weaken_type/sub/NumberAdderImpl.java b/plugins/InspectionGadgets/test/com/siyeh/igtest/abstraction/weaken_type/sub/NumberAdderImpl.java deleted file mode 100644 index 669373d0342f..000000000000 --- a/plugins/InspectionGadgets/test/com/siyeh/igtest/abstraction/weaken_type/sub/NumberAdderImpl.java +++ /dev/null @@ -1,13 +0,0 @@ -package com.siyeh.igtest.abstraction.weaken_type.sub; - -public class NumberAdderImpl implements NumberAdder { - - public int doSomething() { - return getNumberOne() + 1; - } - - protected int getNumberOne() { - return 1; - } -} - diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/castConflictingInstanceof/orInstanceofOrInstanceof/OrInstanceofOrInstanceof.java b/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/castConflictingInstanceof/orInstanceofOrInstanceof/OrInstanceofOrInstanceof.java new file mode 100644 index 000000000000..228fe5c10117 --- /dev/null +++ b/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/castConflictingInstanceof/orInstanceofOrInstanceof/OrInstanceofOrInstanceof.java @@ -0,0 +1,30 @@ +package com.siyeh.igtest.bugs.castConflictingInstanceof.andAnd; + +class Test { + + public void test(Object o) + { + + if (!(o instanceof Number) || + ((Number)o).intValue() == 0 || + !(o instanceof Integer) || + ((Integer) o).byteValue() == 9) { + System.out.println(); + } + + if (!(o instanceof Number) || + ((Number)o).intValue() == 0 || + !(o instanceof Integer) || + !(o instanceof Number) || + ((Integer) o).byteValue() == 9) { + System.out.println(); + } + + if (!(o instanceof Integer) || + ((Number)o).intValue() == 0 || + !(o instanceof Number) || + ((Integer) o).byteValue() == 9) { + System.out.println(); + } + } +} diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/castConflictingInstanceof/orInstanceofOrInstanceof/expected.xml b/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/castConflictingInstanceof/orInstanceofOrInstanceof/expected.xml new file mode 100644 index 000000000000..e8f00e82629f --- /dev/null +++ b/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/castConflictingInstanceof/orInstanceofOrInstanceof/expected.xml @@ -0,0 +1,4 @@ +<?xml version="1.0" encoding="UTF-8"?> +<problems> + +</problems>
\ No newline at end of file diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/mismatched_array_read_write/MismatchedArrayReadWrite.java b/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/mismatched_array_read_write/MismatchedArrayReadWrite.java index beed034bc1ba..33683aaa4d1f 100644 --- a/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/mismatched_array_read_write/MismatchedArrayReadWrite.java +++ b/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/mismatched_array_read_write/MismatchedArrayReadWrite.java @@ -183,4 +183,17 @@ class Ferrari458Spider implements java.io.Serializable { private static final java.io.ObjectStreamField[] serialPersistentFields = { new java.io.ObjectStreamField("b", String.class) }; +} + +class TestIDEA128098 { + private static final String[] CONSTANT_ARRAY = new String[]{""}; // warning is on this constant + + + enum SomeEnum { + ITEM( CONSTANT_ARRAY); + private final String[] myPatterns; + SomeEnum(String... patterns) { + myPatterns = patterns; + } + } }
\ No newline at end of file diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/style/simplifiable_annotation/SimplifiableAnnotation.java b/plugins/InspectionGadgets/test/com/siyeh/igtest/style/simplifiable_annotation/SimplifiableAnnotation.java index b40289507a08..1fe15e0f3eeb 100644 --- a/plugins/InspectionGadgets/test/com/siyeh/igtest/style/simplifiable_annotation/SimplifiableAnnotation.java +++ b/plugins/InspectionGadgets/test/com/siyeh/igtest/style/simplifiable_annotation/SimplifiableAnnotation.java @@ -2,8 +2,8 @@ package com.siyeh.igtest.style.simplifiable_annotation; public class SimplifiableAnnotation { - <warning descr="Annotation '@ SuppressWarnings(value = \\"blabla\\")' can be simplified">@ SuppressWarnings(value = "blabla")</warning> - <warning descr="Annotation '@ Deprecated()' can be simplified">@ Deprecated()</warning> + @<warning descr="Unnecessary whitespace in annotation"> </warning>SuppressWarnings(<warning descr="Unnecessary 'value =' in annotation">value = </warning>"blabla") + @<warning descr="Unnecessary whitespace in annotation"> </warning>Deprecated<warning descr="Unnecessary '()' in annotation">()</warning> Object foo() { return null; } @@ -14,8 +14,8 @@ public class SimplifiableAnnotation { @interface ArrayAnnotation { String[] array(); } -<warning descr="Annotation '@ValueAnnotation({\\"the value\\"})' can be simplified">@ValueAnnotation({"the value"})</warning> -<warning descr="Annotation '@ArrayAnnotation(array = {\\"first\\"})' can be simplified">@ArrayAnnotation(array = {"first"})</warning> +@ValueAnnotation(<warning descr="Unnecessary '{' in annotation">{</warning>"the value"<warning descr="Unnecessary '}' in annotation">}</warning>) +@ArrayAnnotation(array = <warning descr="Unnecessary '{' in annotation">{</warning>"first"<warning descr="Unnecessary '}' in annotation">}</warning>) class MyClass { @ <error descr="'value' missing though required">ValueAnnotation</error> @@ -23,7 +23,7 @@ class MyClass { return -1; } - <warning descr="Annotation '@Two(i={1}, j = 2)' can be simplified">@Two(i={1}, j = 2)</warning> + @Two(i=<warning descr="Unnecessary '{' in annotation">{</warning>1<warning descr="Unnecessary '}' in annotation">}</warning>, j = 2) String s; } @interface Two { |