diff options
Diffstat (limited to 'plugins/svn4idea/src/org/jetbrains/idea/svn/history/LoadedRevisionsCache.java')
-rw-r--r-- | plugins/svn4idea/src/org/jetbrains/idea/svn/history/LoadedRevisionsCache.java | 30 |
1 files changed, 10 insertions, 20 deletions
diff --git a/plugins/svn4idea/src/org/jetbrains/idea/svn/history/LoadedRevisionsCache.java b/plugins/svn4idea/src/org/jetbrains/idea/svn/history/LoadedRevisionsCache.java index 5da830f0ca87..7e1c9d155a0e 100644 --- a/plugins/svn4idea/src/org/jetbrains/idea/svn/history/LoadedRevisionsCache.java +++ b/plugins/svn4idea/src/org/jetbrains/idea/svn/history/LoadedRevisionsCache.java @@ -22,13 +22,13 @@ import com.intellij.openapi.diagnostic.Logger; import com.intellij.openapi.project.Project; import com.intellij.openapi.util.Disposer; import com.intellij.openapi.vcs.RepositoryLocation; -import com.intellij.openapi.vcs.VcsException; import com.intellij.openapi.vcs.changes.committed.ChangesBunch; +import com.intellij.openapi.vcs.changes.committed.CommittedChangesAdapter; import com.intellij.openapi.vcs.changes.committed.CommittedChangesCache; -import com.intellij.openapi.vcs.changes.committed.CommittedChangesListener; import com.intellij.openapi.vcs.versionBrowser.CommittedChangeList; import com.intellij.util.containers.SoftHashMap; import com.intellij.util.messages.MessageBusConnection; +import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.Nullable; import java.util.*; @@ -51,7 +51,9 @@ public class LoadedRevisionsCache implements Disposable { myMap = (ApplicationManager.getApplication().isUnitTestMode()) ? new HashMap<String, Bunch>() : new SoftHashMap<String, Bunch>(); myConnection = project.getMessageBus().connect(); - myConnection.subscribe(CommittedChangesCache.COMMITTED_TOPIC, new CommittedChangesListener() { + myConnection.subscribe(CommittedChangesCache.COMMITTED_TOPIC, new CommittedChangesAdapter() { + + @Override public void changesLoaded(final RepositoryLocation location, final List<CommittedChangeList> changes) { ApplicationManager.getApplication().invokeLater(new Runnable() { public void run() { @@ -60,20 +62,6 @@ public class LoadedRevisionsCache implements Disposable { } }); } - - @Override - public void changesCleared() { - } - - @Override - public void presentationChanged() { - } - - public void incomingChangesUpdated(@Nullable final List<CommittedChangeList> receivedChanges) { - } - - public void refreshErrorStatusChanged(@Nullable final VcsException lastError) { - } }); Disposer.register(myProject, this); setRefreshTime(0); @@ -90,18 +78,20 @@ public class LoadedRevisionsCache implements Disposable { myRefreshTime = refreshTime; } } - - private void debugInfo(final List<CommittedChangeList> data, final boolean consistentWithPrevious, final Bunch bindTo) { + + private static void debugInfo(@NotNull List<CommittedChangeList> data, final boolean consistentWithPrevious, final Bunch bindTo) { LOG.debug(">>> cache internal >>> consistent: " + consistentWithPrevious + " bindTo: " + bindTo + " oldest list: " + data.get(data.size() - 1).getNumber() + ", youngest list: " + data.get(0).getNumber()); } public void dispose() { + // TODO: Seems that dispose could be removed as connection will be disposed anyway on project dispose and clearing map is not necessary myConnection.disconnect(); myMap.clear(); } - private List<List<CommittedChangeList>> split(final List<CommittedChangeList> list, final int size) { + @NotNull + private static List<List<CommittedChangeList>> split(final List<CommittedChangeList> list, final int size) { final int listSize = list.size(); if (listSize < size) { return Collections.singletonList(list); |