blob: 02c674233767046faecc1b63e662b0110a5bef64 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
|
/*
* Copyright 2003-2011 Dave Griffith, Bas Leijdekkers
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.siyeh.ig.bugs;
import com.intellij.codeInspection.ProblemDescriptor;
import com.intellij.openapi.project.Project;
import com.intellij.psi.*;
import com.intellij.psi.util.InheritanceUtil;
import com.intellij.util.IncorrectOperationException;
import com.siyeh.HardcodedMethodConstants;
import com.siyeh.InspectionGadgetsBundle;
import com.siyeh.ig.BaseInspection;
import com.siyeh.ig.BaseInspectionVisitor;
import com.siyeh.ig.InspectionGadgetsFix;
import com.siyeh.ig.PsiReplacementUtil;
import com.siyeh.ig.psiutils.TypeUtils;
import org.jetbrains.annotations.NonNls;
import org.jetbrains.annotations.NotNull;
public class UseOfPropertiesAsHashtableInspection extends BaseInspection {
@Override
@NotNull
public String getDisplayName() {
return InspectionGadgetsBundle.message(
"properties.object.as.hashtable.display.name");
}
@Override
@NotNull
public String buildErrorString(Object... infos) {
return InspectionGadgetsBundle.message(
"properties.object.as.hashtable.problem.descriptor");
}
@Override
protected InspectionGadgetsFix buildFix(Object... infos) {
final PsiMethodCallExpression methodCallExpression =
(PsiMethodCallExpression)infos[0];
final String methodName =
methodCallExpression.getMethodExpression().getReferenceName();
final boolean put = HardcodedMethodConstants.PUT.equals(methodName);
if (!(put || HardcodedMethodConstants.GET.equals(methodName))) {
return null;
}
final PsiExpressionList argumentList =
methodCallExpression.getArgumentList();
final PsiExpression[] arguments = argumentList.getExpressions();
for (PsiExpression argument : arguments) {
final PsiType type = argument.getType();
if (type == null ||
!type.equalsToText(CommonClassNames.JAVA_LANG_STRING)) {
return null;
}
}
return new UseOfPropertiesAsHashtableFix(put);
}
private static class UseOfPropertiesAsHashtableFix
extends InspectionGadgetsFix {
private final boolean put;
public UseOfPropertiesAsHashtableFix(boolean put) {
this.put = put;
}
@NotNull
@Override
public String getName() {
if (put) {
return InspectionGadgetsBundle.message(
"properties.object.as.hashtable.set.quickfix");
}
else {
return InspectionGadgetsBundle.message(
"properties.object.as.hashtable.get.quickfix");
}
}
@NotNull
@Override
public String getFamilyName() {
return "Fix property access";
}
@Override
protected void doFix(Project project, ProblemDescriptor descriptor)
throws IncorrectOperationException {
final PsiElement element = descriptor.getPsiElement();
final PsiElement parent = element.getParent();
final PsiElement grandParent = parent.getParent();
if (!(grandParent instanceof PsiMethodCallExpression)) {
return;
}
final PsiMethodCallExpression methodCallExpression =
(PsiMethodCallExpression)grandParent;
final PsiReferenceExpression methodExpression =
methodCallExpression.getMethodExpression();
@NonNls final StringBuilder newExpression = new StringBuilder();
final PsiExpression qualifierExpression =
methodExpression.getQualifierExpression();
if (qualifierExpression != null) {
newExpression.append(qualifierExpression.getText());
newExpression.append('.');
}
if (put) {
newExpression.append("setProperty(");
}
else {
newExpression.append("getProperty(");
}
final PsiExpressionList argumentList =
methodCallExpression.getArgumentList();
final PsiExpression[] arguments = argumentList.getExpressions();
boolean first = true;
for (PsiExpression argument : arguments) {
if (!first) {
newExpression.append(',');
}
else {
first = false;
}
newExpression.append(argument.getText());
}
newExpression.append(')');
PsiReplacementUtil.replaceExpression(methodCallExpression, newExpression.toString());
}
}
@Override
public BaseInspectionVisitor buildVisitor() {
return new UseOfPropertiesAsHashtableVisitor();
}
private static class UseOfPropertiesAsHashtableVisitor
extends BaseInspectionVisitor {
@Override
public void visitMethodCallExpression(
@NotNull PsiMethodCallExpression expression) {
super.visitMethodCallExpression(expression);
final PsiReferenceExpression methodExpression =
expression.getMethodExpression();
final String methodName = methodExpression.getReferenceName();
if (!(HardcodedMethodConstants.PUT.equals(methodName) ||
HardcodedMethodConstants.PUTALL.equals(methodName) ||
HardcodedMethodConstants.GET.equals(methodName))) {
return;
}
final PsiMethod method = expression.resolveMethod();
if (method == null) {
return;
}
final PsiClass containingClass = method.getContainingClass();
if (containingClass == null) {
return;
}
if (!InheritanceUtil.isInheritor(containingClass,
"java.util.Hashtable")) {
return;
}
final PsiExpression qualifier =
methodExpression.getQualifierExpression();
if (qualifier == null) {
return;
}
if (!TypeUtils.expressionHasTypeOrSubtype(qualifier,
CommonClassNames.JAVA_UTIL_PROPERTIES)) {
return;
}
registerMethodCallError(expression, expression);
}
}
}
|
