1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
|
/*
* Copyright 2003-2008 Dave Griffith, Bas Leijdekkers
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.siyeh.ig.inheritance;
import com.intellij.openapi.progress.ProgressManager;
import com.intellij.openapi.util.Pair;
import com.intellij.psi.*;
import com.intellij.psi.search.SearchScope;
import com.intellij.psi.search.searches.ClassInheritorsSearch;
import com.intellij.psi.util.MethodSignature;
import com.intellij.psi.util.MethodSignatureUtil;
import com.intellij.psi.util.TypeConversionUtil;
import com.siyeh.InspectionGadgetsBundle;
import com.siyeh.ig.BaseInspection;
import com.siyeh.ig.BaseInspectionVisitor;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
import java.util.Collection;
import java.util.List;
public class AbstractMethodWithMissingImplementationsInspection
extends BaseInspection {
@Override
@NotNull
public String getDisplayName() {
return InspectionGadgetsBundle.message(
"abstract.method.with.missing.implementations.display.name");
}
@Override
@NotNull
public String buildErrorString(Object... infos) {
return InspectionGadgetsBundle.message(
"abstract.method.with.missing.implementations.problem.descriptor");
}
@Override
public BaseInspectionVisitor buildVisitor() {
return new AbstractMethodWithMissingImplementationsVisitor();
}
private static class AbstractMethodWithMissingImplementationsVisitor
extends BaseInspectionVisitor {
@Override
public void visitMethod(PsiMethod method) {
super.visitMethod(method);
if (method.getNameIdentifier() == null) {
return;
}
final PsiClass containingClass = method.getContainingClass();
if (containingClass == null) {
return;
}
if (!containingClass.isInterface() ||
!method.hasModifierProperty(PsiModifier.ABSTRACT)) {
return;
}
final InheritorFinder inheritorFinder =
new InheritorFinder(containingClass);
for (final PsiClass inheritor : inheritorFinder.getInheritors()) {
if (!inheritor.isInterface() &&
!inheritor.hasModifierProperty(PsiModifier.ABSTRACT)) {
if (!hasMatchingImplementation(inheritor, method)) {
registerMethodError(method);
return;
}
}
}
}
private static boolean hasMatchingImplementation(
@NotNull PsiClass aClass,
@NotNull PsiMethod method) {
final PsiMethod overridingMethod =
findOverridingMethod(aClass, method);
if (overridingMethod == null ||
overridingMethod.hasModifierProperty(PsiModifier.STATIC)) {
return false;
}
if (!method.hasModifierProperty(PsiModifier.PACKAGE_LOCAL)) {
return true;
}
final PsiClass superClass = method.getContainingClass();
final PsiManager manager = overridingMethod.getManager();
final JavaPsiFacade facade =
JavaPsiFacade.getInstance(manager.getProject());
return facade.arePackagesTheSame(superClass, aClass);
}
/**
* @param method the method of which to find an override.
* @param aClass subclass to find the method in.
* @return the overriding method.
*/
@Nullable
private static PsiMethod findOverridingMethod(
PsiClass aClass, @NotNull PsiMethod method) {
final PsiClass superClass = method.getContainingClass();
if (aClass.equals(superClass)) {
return null;
}
final PsiSubstitutor substitutor =
TypeConversionUtil.getSuperClassSubstitutor(superClass,
aClass, PsiSubstitutor.EMPTY);
final MethodSignature signature = method.getSignature(substitutor);
final List<Pair<PsiMethod, PsiSubstitutor>> pairs =
aClass.findMethodsAndTheirSubstitutorsByName(
signature.getName(), true);
for (Pair<PsiMethod, PsiSubstitutor> pair : pairs) {
final PsiMethod overridingMethod = pair.first;
if (overridingMethod.hasModifierProperty(PsiModifier.ABSTRACT)) {
continue;
}
final PsiClass containingClass =
overridingMethod.getContainingClass();
if (containingClass.isInterface()) {
continue;
}
final PsiSubstitutor overridingSubstitutor = pair.second;
final MethodSignature foundMethodSignature =
overridingMethod.getSignature(overridingSubstitutor);
if (MethodSignatureUtil.isSubsignature(signature,
foundMethodSignature) && overridingMethod != method) {
return overridingMethod;
}
}
return null;
}
}
private static class InheritorFinder implements Runnable {
private final PsiClass aClass;
private Collection<PsiClass> inheritors = null;
InheritorFinder(PsiClass aClass) {
this.aClass = aClass;
}
@Override
public void run() {
final SearchScope searchScope = aClass.getUseScope();
inheritors = ClassInheritorsSearch.search(aClass, searchScope, true)
.findAll();
}
public Collection<PsiClass> getInheritors() {
final ProgressManager progressManager =
ProgressManager.getInstance();
// do not display progress
progressManager.runProcess(this, null);
return inheritors;
}
}
}
|
