blob: a2a3b12bd8de99cb171a3b977479e6a6c50c5315 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
|
/*
* Copyright 2000-2014 JetBrains s.r.o.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.siyeh.ig.internationalization;
import com.intellij.psi.*;
import com.siyeh.InspectionGadgetsBundle;
import com.siyeh.ig.BaseInspection;
import com.siyeh.ig.BaseInspectionVisitor;
import org.jetbrains.annotations.Nls;
import org.jetbrains.annotations.NonNls;
import org.jetbrains.annotations.NotNull;
/**
* @author Bas Leijdekkers
*/
public class ImplicitDefaultCharsetUsageInspection extends BaseInspection {
@Nls
@NotNull
@Override
public String getDisplayName() {
return InspectionGadgetsBundle.message("implicit.default.charset.usage.display.name");
}
@NotNull
@Override
protected String buildErrorString(Object... infos) {
if (infos[0] instanceof PsiNewExpression) {
return InspectionGadgetsBundle.message("implicit.default.charset.usage.constructor.problem.descriptor");
}
else {
return InspectionGadgetsBundle.message("implicit.default.charset.usage.problem.descriptor");
}
}
@Override
public BaseInspectionVisitor buildVisitor() {
return new ImplicitDefaultCharsetUsageVisitor();
}
private static class ImplicitDefaultCharsetUsageVisitor extends BaseInspectionVisitor {
@Override
public void visitMethodCallExpression(PsiMethodCallExpression expression) {
super.visitMethodCallExpression(expression);
final PsiReferenceExpression methodExpression = expression.getMethodExpression();
@NonNls final String name = methodExpression.getReferenceName();
if (!"getBytes".equals(name)) {
return;
}
final PsiMethod method = expression.resolveMethod();
if (method == null) {
return;
}
final PsiParameterList parameterList = method.getParameterList();
if (parameterList.getParametersCount() == 1) {
return;
}
final PsiClass aClass = method.getContainingClass();
if (aClass == null) {
return;
}
final String qName = aClass.getQualifiedName();
if (!CommonClassNames.JAVA_LANG_STRING.equals(qName)) {
return;
}
registerMethodCallError(expression, expression);
}
@Override
public void visitNewExpression(PsiNewExpression expression) {
super.visitNewExpression(expression);
final PsiMethod constructor = expression.resolveConstructor();
if (constructor == null) {
return;
}
final PsiClass aClass = constructor.getContainingClass();
if (aClass == null) {
return;
}
final PsiParameterList parameterList = constructor.getParameterList();
final int count = parameterList.getParametersCount();
if (count == 0) {
return;
}
final PsiParameter[] parameters = parameterList.getParameters();
final String qName = aClass.getQualifiedName();
if (CommonClassNames.JAVA_LANG_STRING.equals(qName)) {
if (!parameters[0].getType().equalsToText("byte[]") || hasCharsetType(parameters[count - 1])) {
return;
}
}
else if ("java.io.InputStreamReader".equals(qName) ||
"java.io.OutputStreamWriter".equals(qName) ||
"java.io.PrintStream".equals(qName)) {
if (hasCharsetType(parameters[count - 1])) {
return;
}
}
else if ("java.io.PrintWriter".equals(qName)) {
if (count > 1 && hasCharsetType(parameters[count - 1]) || parameters[0].getType().equalsToText("java.io.Writer")) {
return;
}
}
else if ("java.util.Formatter".equals(qName)) {
if (count > 1 && hasCharsetType(parameters[1])) {
return;
}
final PsiType firstType = parameters[0].getType();
if (!firstType.equalsToText(CommonClassNames.JAVA_LANG_STRING) && !firstType.equalsToText("java.io.File") &&
!firstType.equalsToText("java.io.OutputStream")) {
return;
}
}
else if ("java.util.Scanner".equals(qName)) {
if (count > 1 && hasCharsetType(parameters[1])) {
return;
}
final PsiType firstType = parameters[0].getType();
if (!firstType.equalsToText("java.io.InputStream") && !firstType.equalsToText("java.io.File") &&
!firstType.equalsToText("java.nio.file.Path") && !firstType.equalsToText("java.nio.channels.ReadableByteChannel")) {
return;
}
}
else if (!"java.io.FileReader".equals(qName) && !"java.io.FileWriter".equals(qName)) {
return;
}
registerNewExpressionError(expression, expression);
}
private static boolean hasCharsetType(PsiVariable variable) {
final PsiType lastType = variable.getType();
return lastType.equalsToText(CommonClassNames.JAVA_LANG_STRING) ||
lastType.equalsToText("java.nio.charset.Charset");
}
}
}
|
