blob: cbbd14eab21bcf5702514a8858cd3328961fa057 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
|
/*
* Copyright 2000-2013 JetBrains s.r.o.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.siyeh.ig.junit;
import com.intellij.psi.*;
import com.intellij.psi.util.InheritanceUtil;
import com.siyeh.InspectionGadgetsBundle;
import com.siyeh.ig.BaseInspectionVisitor;
import com.siyeh.ig.naming.ConventionInspection;
import com.siyeh.ig.psiutils.TestUtils;
import org.jetbrains.annotations.NotNull;
public class JUnitTestClassNamingConventionInspectionBase extends ConventionInspection {
private static final int DEFAULT_MIN_LENGTH = 8;
private static final int DEFAULT_MAX_LENGTH = 64;
@Override
@NotNull
public String getDisplayName() {
return InspectionGadgetsBundle.message(
"junit.test.class.naming.convention.display.name");
}
@Override
protected boolean buildQuickFixesOnlyForOnTheFlyErrors() {
return true;
}
@Override
@NotNull
public String buildErrorString(Object... infos) {
final String className = (String)infos[0];
if (className.length() < getMinLength()) {
return InspectionGadgetsBundle.message(
"junit.test.class.naming.convention.problem.descriptor.short");
}
else if (className.length() > getMaxLength()) {
return InspectionGadgetsBundle.message(
"junit.test.class.naming.convention.problem.descriptor.long");
}
return InspectionGadgetsBundle.message(
"junit.test.class.naming.convention.problem.descriptor.regex.mismatch",
getRegex());
}
@Override
protected String getDefaultRegex() {
return "[A-Z][A-Za-z\\d]*Test";
}
@Override
protected int getDefaultMinLength() {
return DEFAULT_MIN_LENGTH;
}
@Override
protected int getDefaultMaxLength() {
return DEFAULT_MAX_LENGTH;
}
@Override
public BaseInspectionVisitor buildVisitor() {
return new NamingConventionsVisitor();
}
private class NamingConventionsVisitor extends BaseInspectionVisitor {
@Override
public void visitElement(PsiElement element) {
if (!(element instanceof PsiClass)) {
super.visitElement(element);
return;
}
PsiClass aClass = (PsiClass)element;
if (aClass.isInterface() || aClass.isEnum() ||
aClass.isAnnotationType()) {
return;
}
if (aClass instanceof PsiTypeParameter) {
return;
}
if (aClass.hasModifierProperty(PsiModifier.ABSTRACT)) {
return;
}
if (!InheritanceUtil.isInheritor(aClass,
"junit.framework.TestCase")) {
if (!hasJUnit4TestMethods(aClass)) {
return;
}
}
final String name = aClass.getName();
if (name == null) {
return;
}
if (isValid(name)) {
return;
}
registerClassError(aClass, name);
}
private boolean hasJUnit4TestMethods(@NotNull PsiClass aClass) {
//use this if this method turns out to have bad performance:
//if (!TestUtils.isTest(aClass)) {
// return false;
//}
final PsiMethod[] methods = aClass.getMethods();
for (PsiMethod method : methods) {
if (TestUtils.isJUnit4TestMethod(method)) {
return true;
}
}
return false;
}
}
}
|
