blob: 02d8cd5b7c8ecacb0c30ff06b7d7bd95592d78f6 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
|
/*
* Copyright 2003-2011 Dave Griffith, Bas Leijdekkers
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.siyeh.ig.junit;
import com.intellij.codeInsight.AnnotationUtil;
import com.intellij.psi.*;
import com.intellij.psi.util.InheritanceUtil;
import com.siyeh.InspectionGadgetsBundle;
import com.siyeh.ig.BaseInspection;
import com.siyeh.ig.BaseInspectionVisitor;
import com.siyeh.ig.psiutils.TestUtils;
import org.jetbrains.annotations.NonNls;
import org.jetbrains.annotations.NotNull;
public class TestMethodIsPublicVoidNoArgInspection extends BaseInspection {
@Override
@NotNull
public String getDisplayName() {
return InspectionGadgetsBundle.message(
"test.method.is.public.void.no.arg.display.name");
}
@Override
@NotNull
public String getID() {
return "TestMethodWithIncorrectSignature";
}
@Override
@NotNull
public String buildErrorString(Object... infos) {
final boolean isStatic = ((Boolean)infos[1]).booleanValue();
if (isStatic) {
return InspectionGadgetsBundle.message(
"test.method.is.public.void.no.arg.problem.descriptor3");
}
final boolean takesArguments = ((Boolean)infos[0]).booleanValue();
if (takesArguments) {
return InspectionGadgetsBundle.message(
"test.method.is.public.void.no.arg.problem.descriptor1");
}
else {
return InspectionGadgetsBundle.message(
"test.method.is.public.void.no.arg.problem.descriptor2");
}
}
@Override
public BaseInspectionVisitor buildVisitor() {
return new TestMethodIsPublicVoidNoArgVisitor();
}
private static class TestMethodIsPublicVoidNoArgVisitor
extends BaseInspectionVisitor {
@Override
public void visitMethod(@NotNull PsiMethod method) {
//note: no call to super;
@NonNls final String methodName = method.getName();
if (!methodName.startsWith("test") &&
!TestUtils.isJUnit4TestMethod(method)) {
return;
}
final PsiType returnType = method.getReturnType();
if (returnType == null) {
return;
}
final PsiParameterList parameterList = method.getParameterList();
final boolean takesArguments;
final boolean isStatic;
if (parameterList.getParametersCount() == 0) {
takesArguments = false;
isStatic = method.hasModifierProperty(PsiModifier.STATIC);
if (!isStatic && returnType.equals(PsiType.VOID) &&
method.hasModifierProperty(PsiModifier.PUBLIC)) {
return;
}
}
else {
isStatic = false;
takesArguments = true;
}
final PsiClass targetClass = method.getContainingClass();
if (!AnnotationUtil.isAnnotated(method, "org.junit.Test", true)) {
if (targetClass == null ||
!InheritanceUtil.isInheritor(targetClass,
"junit.framework.TestCase")) {
return;
}
}
registerMethodError(method, Boolean.valueOf(takesArguments),
Boolean.valueOf(isStatic));
}
}
}
|
