1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
|
/*
* Copyright 2003-2012 Dave Griffith, Bas Leijdekkers
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.siyeh.ig.numeric;
import com.intellij.codeInspection.ui.SingleCheckboxOptionsPanel;
import com.intellij.psi.*;
import com.intellij.psi.util.PsiTreeUtil;
import com.siyeh.InspectionGadgetsBundle;
import com.siyeh.ig.BaseInspection;
import com.siyeh.ig.BaseInspectionVisitor;
import com.siyeh.ig.psiutils.ClassUtils;
import com.siyeh.ig.psiutils.ExpressionUtils;
import com.siyeh.ig.psiutils.MethodUtils;
import org.jetbrains.annotations.NotNull;
import javax.swing.*;
import java.util.HashMap;
import java.util.Map;
public class CastThatLosesPrecisionInspection extends BaseInspection {
/**
* @noinspection StaticCollection
*/
private static final Map<PsiType, Integer> typePrecisions = new HashMap<PsiType, Integer>(7);
static {
typePrecisions.put(PsiType.BYTE, 1);
typePrecisions.put(PsiType.CHAR, 2);
typePrecisions.put(PsiType.SHORT, 2);
typePrecisions.put(PsiType.INT, 3);
typePrecisions.put(PsiType.LONG, 4);
typePrecisions.put(PsiType.FLOAT, 5);
typePrecisions.put(PsiType.DOUBLE, 6);
}
@SuppressWarnings({"PublicField"})
public boolean ignoreIntegerCharCasts = false;
@Override
@NotNull
public String getID() {
return "NumericCastThatLosesPrecision";
}
@Override
@NotNull
public String getDisplayName() {
return InspectionGadgetsBundle.message(
"cast.that.loses.precision.display.name");
}
@Override
@NotNull
public String buildErrorString(Object... infos) {
final PsiType operandType = (PsiType)infos[0];
return InspectionGadgetsBundle.message("cast.that.loses.precision.problem.descriptor", operandType.getPresentableText());
}
@Override
public JComponent createOptionsPanel() {
return new SingleCheckboxOptionsPanel(InspectionGadgetsBundle.message("cast.that.loses.precision.option"),
this, "ignoreIntegerCharCasts");
}
@Override
public BaseInspectionVisitor buildVisitor() {
return new CastThatLosesPrecisionVisitor();
}
private class CastThatLosesPrecisionVisitor
extends BaseInspectionVisitor {
@Override
public void visitTypeCastExpression(@NotNull PsiTypeCastExpression expression) {
final PsiType castType = expression.getType();
if (!ClassUtils.isPrimitiveNumericType(castType)) {
return;
}
final PsiExpression operand = expression.getOperand();
if (operand == null) {
return;
}
final PsiType operandType = operand.getType();
if (!ClassUtils.isPrimitiveNumericType(operandType)) {
return;
}
if (hasLowerPrecision(operandType, castType)) {
return;
}
if (ignoreIntegerCharCasts) {
if (PsiType.INT.equals(operandType) && PsiType.CHAR.equals(castType)) {
return;
}
}
if (PsiType.LONG.equals(operandType) && PsiType.INT.equals(castType)) {
final PsiMethod method = PsiTreeUtil.getParentOfType(expression, PsiMethod.class, true, PsiClass.class);
if (MethodUtils.isHashCode(method)) {
return;
}
}
Object result = ExpressionUtils.computeConstantExpression(operand);
if (result instanceof Character) {
result = Integer.valueOf(((Character)result).charValue());
}
if (result instanceof Number) {
final Number number = (Number)result;
if (valueIsContainableInType(number, castType)) {
return;
}
}
final PsiTypeElement castTypeElement = expression.getCastType();
if (castTypeElement == null) {
return;
}
registerError(castTypeElement, operandType);
}
private boolean hasLowerPrecision(PsiType operandType, PsiType castType) {
final Integer operandPrecision = typePrecisions.get(operandType);
final Integer castPrecision = typePrecisions.get(castType);
return operandPrecision.intValue() <= castPrecision.intValue();
}
private boolean valueIsContainableInType(Number value, PsiType type) {
final long longValue = value.longValue();
final double doubleValue = value.doubleValue();
if (PsiType.BYTE.equals(type)) {
return longValue >= (long)Byte.MIN_VALUE &&
longValue <= (long)Byte.MAX_VALUE &&
doubleValue >= (double)Byte.MIN_VALUE &&
doubleValue <= (double)Byte.MAX_VALUE;
}
else if (PsiType.CHAR.equals(type)) {
return longValue >= (long)Character.MIN_VALUE &&
longValue <= (long)Character.MAX_VALUE &&
doubleValue >= (double)Character.MIN_VALUE &&
doubleValue <= (double)Character.MAX_VALUE;
}
else if (PsiType.SHORT.equals(type)) {
return longValue >= (long)Short.MIN_VALUE &&
longValue <= (long)Short.MAX_VALUE &&
doubleValue >= (double)Short.MIN_VALUE &&
doubleValue <= (double)Short.MAX_VALUE;
}
else if (PsiType.INT.equals(type)) {
return longValue >= (long)Integer.MIN_VALUE &&
longValue <= (long)Integer.MAX_VALUE &&
doubleValue >= (double)Integer.MIN_VALUE &&
doubleValue <= (double)Integer.MAX_VALUE;
}
else if (PsiType.LONG.equals(type)) {
return longValue >= Long.MIN_VALUE &&
longValue <= Long.MAX_VALUE &&
doubleValue >= (double)Long.MIN_VALUE &&
doubleValue <= (double)Long.MAX_VALUE;
}
else if (PsiType.FLOAT.equals(type)) {
return doubleValue == value.floatValue();
}
else if (PsiType.DOUBLE.equals(type)) {
return true;
}
return false;
}
}
}
|
