blob: 57659d05923ac2003f9837529846425fb0c383c9 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
|
/*
* Copyright 2000-2013 JetBrains s.r.o.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.siyeh.ig.style;
import com.intellij.psi.*;
import com.intellij.psi.util.PropertyUtil;
import com.intellij.psi.util.PsiTreeUtil;
import com.siyeh.InspectionGadgetsBundle;
import com.siyeh.ig.BaseInspection;
import com.siyeh.ig.BaseInspectionVisitor;
import com.siyeh.ig.psiutils.ExpressionUtils;
import org.jetbrains.annotations.NotNull;
public class NestedMethodCallInspectionBase extends BaseInspection {
/**
* @noinspection PublicField
*/
public boolean m_ignoreFieldInitializations = true;
@SuppressWarnings("PublicField")
public boolean ignoreStaticMethods = false;
@SuppressWarnings("PublicField")
public boolean ignoreGetterCalls = false;
@Override
@NotNull
public String getDisplayName() {
return InspectionGadgetsBundle.message("nested.method.call.display.name");
}
@Override
@NotNull
protected String buildErrorString(Object... infos) {
return InspectionGadgetsBundle.message("nested.method.call.problem.descriptor");
}
@Override
public BaseInspectionVisitor buildVisitor() {
return new NestedMethodCallVisitor();
}
@Override
protected boolean buildQuickFixesOnlyForOnTheFlyErrors() {
return true;
}
private class NestedMethodCallVisitor extends BaseInspectionVisitor {
@Override
public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expression) {
super.visitMethodCallExpression(expression);
PsiExpression outerExpression = expression;
while (outerExpression != null && outerExpression.getParent() instanceof PsiExpression) {
outerExpression = (PsiExpression)outerExpression.getParent();
}
if (outerExpression == null) {
return;
}
final PsiElement parent = outerExpression.getParent();
if (!(parent instanceof PsiExpressionList)) {
return;
}
final PsiElement grandParent = parent.getParent();
if (!(grandParent instanceof PsiCallExpression)) {
return;
}
if (ExpressionUtils.isConstructorInvocation(grandParent)) {
//ignore nested method calls at the start of a constructor,
//where they can't be extracted
return;
}
if (m_ignoreFieldInitializations) {
final PsiElement field = PsiTreeUtil.getParentOfType(expression, PsiField.class);
if (field != null) {
return;
}
}
final PsiMethod method = expression.resolveMethod();
if (method == null) {
return;
}
if (ignoreStaticMethods || ignoreGetterCalls) {
if (ignoreStaticMethods && method.hasModifierProperty(PsiModifier.STATIC)) {
return;
}
if (ignoreGetterCalls && PropertyUtil.isSimpleGetter(method)) {
return;
}
}
registerMethodCallError(expression);
}
}
}
|
