1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
|
/*
* Copyright 2010-2014 Bas Leijdekkers
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.siyeh.ig.style;
import com.intellij.codeInspection.CleanupLocalInspectionTool;
import com.intellij.codeInspection.ProblemDescriptor;
import com.intellij.codeInspection.ProblemHighlightType;
import com.intellij.codeInspection.ui.SingleCheckboxOptionsPanel;
import com.intellij.openapi.project.Project;
import com.intellij.psi.*;
import com.intellij.psi.util.PsiTreeUtil;
import com.intellij.util.IncorrectOperationException;
import com.siyeh.InspectionGadgetsBundle;
import com.siyeh.ig.BaseInspection;
import com.siyeh.ig.BaseInspectionVisitor;
import com.siyeh.ig.InspectionGadgetsFix;
import com.siyeh.ig.psiutils.ImportUtils;
import org.jetbrains.annotations.Nls;
import org.jetbrains.annotations.NotNull;
import javax.swing.*;
public class UnnecessarilyQualifiedInnerClassAccessInspection extends BaseInspection implements CleanupLocalInspectionTool {
@SuppressWarnings({"PublicField"})
public boolean ignoreReferencesNeedingImport = false;
@Nls
@NotNull
@Override
public String getDisplayName() {
return InspectionGadgetsBundle.message(
"unnecessarily.qualified.inner.class.access.display.name");
}
@NotNull
@Override
protected String buildErrorString(Object... infos) {
final PsiClass aClass = (PsiClass)infos[0];
return InspectionGadgetsBundle.message(
"unnecessarily.qualified.inner.class.access.problem.descriptor",
aClass.getName());
}
@Override
public JComponent createOptionsPanel() {
return new SingleCheckboxOptionsPanel(
InspectionGadgetsBundle.message(
"unnecessarily.qualified.inner.class.access.option"),
this, "ignoreReferencesNeedingImport");
}
@Override
protected InspectionGadgetsFix buildFix(Object... infos) {
return new UnnecessarilyQualifiedInnerClassAccessFix();
}
private static class UnnecessarilyQualifiedInnerClassAccessFix
extends InspectionGadgetsFix {
@Override
@NotNull
public String getFamilyName() {
return getName();
}
@Override
@NotNull
public String getName() {
return InspectionGadgetsBundle.message(
"unnecessarily.qualified.inner.class.access.quickfix");
}
@Override
protected void doFix(Project project, ProblemDescriptor descriptor)
throws IncorrectOperationException {
final PsiElement element = descriptor.getPsiElement();
final PsiElement parent = element.getParent();
if (!(parent instanceof PsiJavaCodeReferenceElement)) {
return;
}
final PsiJavaCodeReferenceElement referenceElement =
(PsiJavaCodeReferenceElement)parent;
final PsiElement target = referenceElement.resolve();
if (!(target instanceof PsiClass)) {
return;
}
final PsiClass aClass = (PsiClass)target;
ImportUtils.addImportIfNeeded(aClass, element);
element.delete();
}
}
@Override
public BaseInspectionVisitor buildVisitor() {
return new UnnecessarilyQualifiedInnerClassAccessVisitor();
}
private class UnnecessarilyQualifiedInnerClassAccessVisitor
extends BaseInspectionVisitor {
@Override
public void visitReferenceElement(
PsiJavaCodeReferenceElement reference) {
super.visitReferenceElement(reference);
final PsiElement qualifier = reference.getQualifier();
if (!(qualifier instanceof PsiJavaCodeReferenceElement)) {
return;
}
if (isInImportOrPackage(reference)) {
return;
}
final PsiJavaCodeReferenceElement referenceElement =
(PsiJavaCodeReferenceElement)qualifier;
final PsiReferenceParameterList parameterList =
referenceElement.getParameterList();
if (parameterList != null &&
parameterList.getTypeParameterElements().length > 0) {
return;
}
final PsiElement qualifierTarget = referenceElement.resolve();
if (!(qualifierTarget instanceof PsiClass)) {
return;
}
final PsiClass referenceClass =
PsiTreeUtil.getParentOfType(reference, PsiClass.class);
if (referenceClass == null) {
return;
}
if (!referenceClass.equals(qualifierTarget) ||
PsiTreeUtil.isAncestor(referenceClass.getModifierList(),
reference, true)) {
if (ignoreReferencesNeedingImport &&
(PsiTreeUtil.isAncestor(referenceClass, qualifierTarget,
true) ||
!PsiTreeUtil.isAncestor(qualifierTarget,
referenceClass, true))) {
return;
}
}
final PsiElement target = reference.resolve();
if (!(target instanceof PsiClass)) {
return;
}
final PsiClass aClass = (PsiClass)target;
final PsiClass containingClass = aClass.getContainingClass();
if (containingClass == null) {
return;
}
if (!containingClass.equals(qualifierTarget)) {
return;
}
final String shortName = aClass.getName();
if (!isReferenceToTarget(shortName, aClass, reference)) {
return;
}
registerError(qualifier, ProblemHighlightType.LIKE_UNUSED_SYMBOL, aClass);
}
@Override
public void visitReferenceExpression(
PsiReferenceExpression expression) {
visitReferenceElement(expression);
}
private boolean isReferenceToTarget(String referenceText, @NotNull PsiClass target, PsiElement context) {
final PsiJavaCodeReferenceElement reference =
JavaPsiFacade.getElementFactory(target.getProject()).createReferenceFromText(referenceText, context);
final JavaResolveResult[] results = reference.multiResolve(false);
if (results.length == 0) {
return true;
}
if (results.length > 1) {
return false;
}
final JavaResolveResult result = results[0];
return result.isAccessible() && target.equals(result.getElement());
}
private boolean isInImportOrPackage(PsiElement element) {
while (element instanceof PsiJavaCodeReferenceElement) {
element = element.getParent();
if (element instanceof PsiImportStatementBase ||
element instanceof PsiPackageStatement ||
element instanceof PsiImportStaticReferenceElement) {
return true;
}
}
return false;
}
}
}
|
