1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
|
/*
* Copyright 2003-2010 Dave Griffith, Bas Leijdekkers
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.siyeh.ig.style;
import com.intellij.codeInspection.CleanupLocalInspectionTool;
import com.intellij.codeInspection.ProblemDescriptor;
import com.intellij.codeInspection.ui.SingleCheckboxOptionsPanel;
import com.intellij.openapi.project.Project;
import com.intellij.psi.*;
import com.intellij.psi.util.PsiTreeUtil;
import com.intellij.util.IncorrectOperationException;
import com.siyeh.InspectionGadgetsBundle;
import com.siyeh.ig.BaseInspection;
import com.siyeh.ig.BaseInspectionVisitor;
import com.siyeh.ig.InspectionGadgetsFix;
import com.siyeh.ig.psiutils.VariableSearchUtils;
import org.jetbrains.annotations.NotNull;
import javax.swing.*;
public class UnnecessaryBlockStatementInspection extends BaseInspection implements CleanupLocalInspectionTool {
@SuppressWarnings({"PublicField"})
public boolean ignoreSwitchBranches = false;
@Override
@NotNull
public String getID() {
return "UnnecessaryCodeBlock";
}
@Override
@NotNull
public String getDisplayName() {
return InspectionGadgetsBundle.message(
"unnecessary.code.block.display.name");
}
@Override
@NotNull
public String buildErrorString(Object... infos) {
return InspectionGadgetsBundle.message(
"unnecessary.block.statement.problem.descriptor");
}
@Override
public JComponent createOptionsPanel() {
return new SingleCheckboxOptionsPanel(
InspectionGadgetsBundle.message("ignore.branches.of.switch.statements"),
this, "ignoreSwitchBranches");
}
@Override
public BaseInspectionVisitor buildVisitor() {
return new UnnecessaryBlockStatementVisitor();
}
@Override
public InspectionGadgetsFix buildFix(Object... infos) {
return new UnnecessaryBlockFix();
}
private static class UnnecessaryBlockFix extends InspectionGadgetsFix {
@Override
@NotNull
public String getName() {
return InspectionGadgetsBundle.message(
"unnecessary.code.block.unwrap.quickfix");
}
@NotNull
@Override
public String getFamilyName() {
return getName();
}
@Override
public void doFix(Project project, ProblemDescriptor descriptor)
throws IncorrectOperationException {
final PsiElement leftBrace = descriptor.getPsiElement();
final PsiElement parent = leftBrace.getParent();
if (!(parent instanceof PsiCodeBlock)) {
return;
}
final PsiCodeBlock block = (PsiCodeBlock)parent;
final PsiBlockStatement blockStatement =
(PsiBlockStatement)block.getParent();
final PsiElement[] children = block.getChildren();
if (children.length > 2) {
final PsiElement element = blockStatement.getParent();
element.addRangeBefore(children[1],
children[children.length - 2], blockStatement);
}
blockStatement.delete();
}
}
private class UnnecessaryBlockStatementVisitor
extends BaseInspectionVisitor {
@Override
public void visitBlockStatement(
PsiBlockStatement blockStatement) {
super.visitBlockStatement(blockStatement);
if (ignoreSwitchBranches) {
final PsiElement prevStatement =
PsiTreeUtil.skipSiblingsBackward(blockStatement,
PsiWhiteSpace.class);
if (prevStatement instanceof PsiSwitchLabelStatement) {
return;
}
}
final PsiElement parent = blockStatement.getParent();
if (!(parent instanceof PsiCodeBlock)) {
return;
}
final PsiCodeBlock codeBlock = blockStatement.getCodeBlock();
final PsiJavaToken brace = codeBlock.getLBrace();
if (brace == null) {
return;
}
final PsiCodeBlock parentBlock = (PsiCodeBlock)parent;
if (parentBlock.getStatements().length > 1 &&
VariableSearchUtils.containsConflictingDeclarations(
codeBlock, parentBlock)) {
return;
}
registerError(brace);
final PsiJavaToken rbrace = codeBlock.getRBrace();
if (rbrace != null) {
registerError(rbrace);
}
}
}
}
|
