1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
|
/*
* Copyright 2003-2007 Dave Griffith, Bas Leijdekkers
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.siyeh.ig.controlflow;
import com.intellij.codeInspection.ui.SingleCheckboxOptionsPanel;
import com.intellij.psi.*;
import com.intellij.psi.tree.IElementType;
import com.siyeh.InspectionGadgetsBundle;
import com.siyeh.ig.BaseInspection;
import com.siyeh.ig.BaseInspectionVisitor;
import com.siyeh.ig.psiutils.EquivalenceChecker;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
import javax.swing.*;
import java.util.Arrays;
import java.util.HashSet;
import java.util.Set;
public class DuplicateConditionInspection extends BaseInspection {
/**
* @noinspection PublicField
*/
public boolean ignoreMethodCalls = false;
// This is a dirty fix of 'squared' algorithm performance issue.
private static final int LIMIT_DEPTH = 20;
@NotNull
public String getDisplayName() {
return InspectionGadgetsBundle.message(
"duplicate.condition.display.name");
}
@NotNull
protected String buildErrorString(Object... infos) {
return InspectionGadgetsBundle.message(
"duplicate.condition.problem.descriptor");
}
@Nullable
public JComponent createOptionsPanel() {
return new SingleCheckboxOptionsPanel(
InspectionGadgetsBundle.message(
"duplicate.condition.ignore.method.calls.option"),
this, "ignoreMethodCalls");
}
public BaseInspectionVisitor buildVisitor() {
return new DuplicateConditionVisitor();
}
private class DuplicateConditionVisitor
extends BaseInspectionVisitor {
@Override
public void visitIfStatement(@NotNull PsiIfStatement statement) {
super.visitIfStatement(statement);
final PsiElement parent = statement.getParent();
if (parent instanceof PsiIfStatement) {
final PsiIfStatement parentStatement = (PsiIfStatement)parent;
final PsiStatement elseBranch = parentStatement.getElseBranch();
if (statement.equals(elseBranch)) {
return;
}
}
final Set<PsiExpression> conditions = new HashSet<PsiExpression>();
collectConditionsForIfStatement(statement, conditions, 0);
final int numConditions = conditions.size();
if (numConditions < 2) {
return;
}
final PsiExpression[] conditionArray =
conditions.toArray(new PsiExpression[numConditions]);
final boolean[] matched = new boolean[conditionArray.length];
Arrays.fill(matched, false);
for (int i = 0; i < conditionArray.length; i++) {
if (matched[i]) {
continue;
}
final PsiExpression condition = conditionArray[i];
for (int j = i + 1; j < conditionArray.length; j++) {
if (matched[j]) {
continue;
}
final PsiExpression testCondition = conditionArray[j];
final boolean areEquivalent =
EquivalenceChecker.expressionsAreEquivalent(
condition, testCondition);
if (areEquivalent) {
matched[i] = true;
matched[j] = true;
if (ignoreMethodCalls &&
containsMethodCallExpression(testCondition)) {
break;
}
registerError(testCondition);
if (!matched[i]) {
registerError(condition);
}
}
}
}
}
private void collectConditionsForIfStatement(
PsiIfStatement statement, Set<PsiExpression> conditions, int depth) {
if (depth > LIMIT_DEPTH) return;
final PsiExpression condition = statement.getCondition();
collectConditionsForExpression(condition, conditions);
final PsiStatement branch = statement.getElseBranch();
if (branch instanceof PsiIfStatement) {
collectConditionsForIfStatement((PsiIfStatement)branch,
conditions, depth + 1);
}
}
private void collectConditionsForExpression(
PsiExpression condition, Set<PsiExpression> conditions) {
if (condition == null) {
return;
}
if (condition instanceof PsiParenthesizedExpression) {
final PsiParenthesizedExpression parenthesizedExpression =
(PsiParenthesizedExpression)condition;
final PsiExpression contents =
parenthesizedExpression.getExpression();
collectConditionsForExpression(contents, conditions);
return;
}
if (condition instanceof PsiBinaryExpression) {
final PsiBinaryExpression binaryExpression =
(PsiBinaryExpression)condition;
final IElementType tokenType = binaryExpression.getOperationTokenType();
if (JavaTokenType.OROR.equals(tokenType)) {
final PsiExpression lhs = binaryExpression.getLOperand();
collectConditionsForExpression(lhs, conditions);
final PsiExpression rhs = binaryExpression.getROperand();
collectConditionsForExpression(rhs, conditions);
return;
}
}
conditions.add(condition);
}
private boolean containsMethodCallExpression(PsiElement element) {
if (element instanceof PsiMethodCallExpression) {
return true;
}
final PsiElement[] children = element.getChildren();
for (PsiElement child : children) {
if (containsMethodCallExpression(child)) {
return true;
}
}
return false;
}
}
}
|
