blob: b98a32051bb3837dee55129336a85c53652f84cc (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
|
/*
* Copyright 2003-2013 Dave Griffith, Bas Leijdekkers
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.siyeh.ig.controlflow;
import com.intellij.codeInspection.ProblemDescriptor;
import com.intellij.codeInspection.ui.SingleCheckboxOptionsPanel;
import com.intellij.openapi.project.Project;
import com.intellij.psi.*;
import com.intellij.psi.util.PsiTreeUtil;
import com.intellij.util.IncorrectOperationException;
import com.siyeh.InspectionGadgetsBundle;
import com.siyeh.ig.BaseInspection;
import com.siyeh.ig.BaseInspectionVisitor;
import com.siyeh.ig.InspectionGadgetsFix;
import com.siyeh.ig.psiutils.ControlFlowUtils;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
import javax.swing.*;
import java.util.regex.Pattern;
public class FallthruInSwitchStatementInspection extends BaseInspection {
@NotNull
public String getDisplayName() {
return InspectionGadgetsBundle.message("fallthru.in.switch.statement.display.name");
}
@NotNull
public String getID() {
return "fallthrough";
}
@NotNull
protected String buildErrorString(Object... infos) {
return InspectionGadgetsBundle.message("fallthru.in.switch.statement.problem.descriptor");
}
@Nullable
protected InspectionGadgetsFix buildFix(Object... infos) {
return new FallthruInSwitchStatementFix();
}
public BaseInspectionVisitor buildVisitor() {
return new FallthroughInSwitchStatementVisitor();
}
private static class FallthruInSwitchStatementFix extends InspectionGadgetsFix {
@NotNull
public String getName() {
return InspectionGadgetsBundle.message("fallthru.in.switch.statement.quickfix");
}
protected void doFix(Project project, ProblemDescriptor descriptor) {
final PsiSwitchLabelStatement labelStatement = (PsiSwitchLabelStatement)descriptor.getPsiElement();
final JavaPsiFacade psiFacade = JavaPsiFacade.getInstance(project);
final PsiElementFactory factory = psiFacade.getElementFactory();
final PsiStatement breakStatement = factory.createStatementFromText("break;", labelStatement);
final PsiElement parent = labelStatement.getParent();
parent.addBefore(breakStatement, labelStatement);
}
}
private static class FallthroughInSwitchStatementVisitor extends BaseInspectionVisitor {
private static final Pattern commentPattern = Pattern.compile("(?i)falls?\\s*thro?u");
@Override
public void visitSwitchStatement(@NotNull PsiSwitchStatement statement) {
super.visitSwitchStatement(statement);
final PsiCodeBlock body = statement.getBody();
if (body == null) {
return;
}
final PsiStatement[] statements = body.getStatements();
for (int i = 1; i < statements.length; i++) {
final PsiStatement child = statements[i];
if (!(child instanceof PsiSwitchLabelStatement)) {
continue;
}
final PsiElement previousSibling = PsiTreeUtil.skipSiblingsBackward(child, PsiWhiteSpace.class);
if (previousSibling instanceof PsiComment) {
final PsiComment comment = (PsiComment)previousSibling;
final String commentText = comment.getText();
if (commentPattern.matcher(commentText).find()) {
continue;
}
}
final PsiStatement previousStatement = PsiTreeUtil.getPrevSiblingOfType(child, PsiStatement.class);
if (ControlFlowUtils.statementMayCompleteNormally(previousStatement)) {
registerError(child);
}
}
}
}
}
|
