blob: 98669f9bb982244a5e226e3219d222c255643bee (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
|
/*
* Copyright 2003-2013 Dave Griffith, Bas Leijdekkers
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.siyeh.ig.controlflow;
import com.intellij.psi.*;
import com.siyeh.InspectionGadgetsBundle;
import com.siyeh.ig.BaseInspection;
import com.siyeh.ig.BaseInspectionVisitor;
import org.jetbrains.annotations.NotNull;
import java.util.HashSet;
import java.util.Set;
public class SwitchStatementWithConfusingDeclarationInspection extends BaseInspection {
@NotNull
public String getID() {
return "LocalVariableUsedAndDeclaredInDifferentSwitchBranches";
}
@NotNull
public String getDisplayName() {
return InspectionGadgetsBundle.message("switch.statement.with.confusing.declaration.display.name");
}
@NotNull
protected String buildErrorString(Object... infos) {
return InspectionGadgetsBundle.message("switch.statement.with.confusing.declaration.problem.descriptor");
}
public BaseInspectionVisitor buildVisitor() {
return new SwitchStatementWithConfusingDeclarationVisitor();
}
private static class SwitchStatementWithConfusingDeclarationVisitor extends BaseInspectionVisitor {
@Override
public void visitSwitchStatement(@NotNull PsiSwitchStatement statement) {
final PsiCodeBlock body = statement.getBody();
if (body == null) {
return;
}
final Set<PsiLocalVariable> variablesInPreviousBranches = new HashSet<PsiLocalVariable>(5);
final Set<PsiLocalVariable> variablesInCurrentBranch = new HashSet<PsiLocalVariable>(5);
final PsiStatement[] statements = body.getStatements();
final LocalVariableAccessVisitor visitor = new LocalVariableAccessVisitor(variablesInPreviousBranches);
for (final PsiStatement child : statements) {
if (child instanceof PsiDeclarationStatement) {
final PsiDeclarationStatement declarationStatement = (PsiDeclarationStatement)child;
final PsiElement[] declaredElements = declarationStatement.getDeclaredElements();
for (final PsiElement declaredElement : declaredElements) {
if (declaredElement instanceof PsiLocalVariable) {
final PsiLocalVariable localVariable = (PsiLocalVariable)declaredElement;
variablesInCurrentBranch.add(localVariable);
}
}
}
else if (child instanceof PsiBreakStatement) {
variablesInPreviousBranches.addAll(variablesInCurrentBranch);
variablesInCurrentBranch.clear();
}
child.accept(visitor);
}
}
class LocalVariableAccessVisitor extends JavaRecursiveElementVisitor {
private final Set<PsiLocalVariable> myVariablesInPreviousBranches;
public LocalVariableAccessVisitor(Set<PsiLocalVariable> variablesInPreviousBranches) {
myVariablesInPreviousBranches = variablesInPreviousBranches;
}
@Override
public void visitReferenceExpression(@NotNull PsiReferenceExpression referenceExpression) {
super.visitReferenceExpression(referenceExpression);
final PsiExpression qualifier = referenceExpression.getQualifierExpression();
if (qualifier != null) {
return;
}
final PsiElement element = referenceExpression.resolve();
if (!(element instanceof PsiLocalVariable)) {
return;
}
final PsiLocalVariable accessedVariable = (PsiLocalVariable)element;
if (myVariablesInPreviousBranches.contains(accessedVariable)) {
myVariablesInPreviousBranches.remove(accessedVariable);
registerVariableError(accessedVariable);
}
}
}
}
}
|
