1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
|
/*
* Copyright 2003-2012 Dave Griffith, Bas Leijdekkers
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.siyeh.ig.style;
import com.intellij.codeInspection.ProblemDescriptor;
import com.intellij.codeInspection.ui.MultipleCheckboxOptionsPanel;
import com.intellij.openapi.project.Project;
import com.intellij.psi.*;
import com.siyeh.InspectionGadgetsBundle;
import com.siyeh.ig.BaseInspection;
import com.siyeh.ig.BaseInspectionVisitor;
import com.siyeh.ig.InspectionGadgetsFix;
import com.siyeh.ig.psiutils.ParenthesesUtils;
import org.jetbrains.annotations.NotNull;
import javax.swing.*;
public class UnnecessaryParenthesesInspection extends BaseInspection {
@SuppressWarnings({"PublicField"})
public boolean ignoreClarifyingParentheses = false;
@SuppressWarnings({"PublicField"})
public boolean ignoreParenthesesOnConditionals = false;
@SuppressWarnings("PublicField")
public boolean ignoreParenthesesOnLambdaParameter = false;
@Override
@NotNull
public String getDisplayName() {
return InspectionGadgetsBundle.message("unnecessary.parentheses.display.name");
}
@Override
@NotNull
protected String buildErrorString(Object... infos) {
return InspectionGadgetsBundle.message("unnecessary.parentheses.problem.descriptor");
}
@Override
public JComponent createOptionsPanel() {
final MultipleCheckboxOptionsPanel optionsPanel = new MultipleCheckboxOptionsPanel(this);
optionsPanel.addCheckbox(InspectionGadgetsBundle.message("unnecessary.parentheses.option"), "ignoreClarifyingParentheses");
optionsPanel.addCheckbox(InspectionGadgetsBundle.message("unnecessary.parentheses.conditional.option"),
"ignoreParenthesesOnConditionals");
optionsPanel.addCheckbox("Ignore parentheses around single no formal type lambda parameter", "ignoreParenthesesOnLambdaParameter");
return optionsPanel;
}
@Override
public BaseInspectionVisitor buildVisitor() {
return new UnnecessaryParenthesesVisitor();
}
private class UnnecessaryParenthesesFix extends InspectionGadgetsFix {
@NotNull
public String getName() {
return InspectionGadgetsBundle.message("unnecessary.parentheses.remove.quickfix");
}
@Override
public void doFix(Project project, ProblemDescriptor descriptor) {
final PsiElement element = descriptor.getPsiElement();
if (element instanceof PsiParameterList) {
final PsiElementFactory factory = JavaPsiFacade.getElementFactory(element.getProject());
final PsiParameterList parameterList = (PsiParameterList)element;
final String text = parameterList.getParameters()[0].getName() + "->{}";
final PsiLambdaExpression expression = (PsiLambdaExpression)factory.createExpressionFromText(text, element);
element.replace(expression.getParameterList());
} else {
ParenthesesUtils.removeParentheses((PsiExpression)element, ignoreClarifyingParentheses);
}
}
}
@Override
public InspectionGadgetsFix buildFix(Object... infos) {
return new UnnecessaryParenthesesFix();
}
private class UnnecessaryParenthesesVisitor extends BaseInspectionVisitor {
@Override
public void visitParameterList(PsiParameterList list) {
super.visitParameterList(list);
if (!ignoreParenthesesOnLambdaParameter && list.getParent() instanceof PsiLambdaExpression && list.getParametersCount() == 1) {
final PsiParameter parameter = list.getParameters()[0];
if (parameter.getTypeElement() == null && list.getFirstChild() != parameter && list.getLastChild() != parameter) {
registerError(list);
}
}
}
@Override
public void visitParenthesizedExpression(PsiParenthesizedExpression expression) {
final PsiElement parent = expression.getParent();
final PsiExpression child = expression.getExpression();
if (child == null) {
return;
}
if (!(parent instanceof PsiExpression) || parent instanceof PsiParenthesizedExpression
|| parent instanceof PsiArrayAccessExpression || parent instanceof PsiArrayInitializerExpression) {
registerError(expression);
return;
}
final int parentPrecedence = ParenthesesUtils.getPrecedence((PsiExpression)parent);
final int childPrecedence = ParenthesesUtils.getPrecedence(child);
if (parentPrecedence > childPrecedence) {
if (ignoreClarifyingParentheses) {
if (child instanceof PsiPolyadicExpression) {
if (parent instanceof PsiPolyadicExpression ||
parent instanceof PsiConditionalExpression ||
parent instanceof PsiInstanceOfExpression) {
return;
}
}
else if (child instanceof PsiInstanceOfExpression) {
return;
}
}
if (ignoreParenthesesOnConditionals) {
if (parent instanceof PsiConditionalExpression) {
final PsiConditionalExpression conditionalExpression = (PsiConditionalExpression)parent;
final PsiExpression condition = conditionalExpression.getCondition();
if (expression == condition) {
return;
}
}
}
registerError(expression);
return;
}
if (parentPrecedence == childPrecedence) {
if (!ParenthesesUtils.areParenthesesNeeded(expression, ignoreClarifyingParentheses)) {
registerError(expression);
return;
}
}
super.visitParenthesizedExpression(expression);
}
}
}
|
