blob: 527a239422f917823ec79728e0bd813e7986e644 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
|
/*
* Copyright 2008 Bas Leijdekkers
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.siyeh.ig.threading;
import com.intellij.psi.*;
import com.intellij.psi.util.PsiTreeUtil;
import com.siyeh.ig.BaseInspection;
import com.siyeh.ig.BaseInspectionVisitor;
import com.siyeh.InspectionGadgetsBundle;
import org.jetbrains.annotations.Nls;
import org.jetbrains.annotations.NotNull;
public class SynchronizationOnLocalVariableOrMethodParameterInspection
extends BaseInspection {
@SuppressWarnings({"PublicField"})
public boolean reportLocalVariables = true;
@SuppressWarnings({"PublicField"})
public boolean reportMethodParameters = true;
@Nls
@NotNull
public String getDisplayName() {
return InspectionGadgetsBundle.message(
"synchronization.on.local.variable.or.method.parameter.display.name");
}
public boolean isEnabledByDefault() {
return true;
}
@NotNull
protected String buildErrorString(Object... infos) {
final Boolean localVariable = (Boolean)infos[0];
if (localVariable.booleanValue()) {
return InspectionGadgetsBundle.message(
"synchronization.on.local.variable.problem.descriptor");
}
else {
return InspectionGadgetsBundle.message(
"synchronization.on.method.parameter.problem.descriptor");
}
}
public BaseInspectionVisitor buildVisitor() {
return new SynchronizationOnLocalVariableVisitor();
}
private class SynchronizationOnLocalVariableVisitor
extends BaseInspectionVisitor {
public void visitSynchronizedStatement(
PsiSynchronizedStatement statement) {
super.visitSynchronizedStatement(statement);
if (!reportLocalVariables && !reportMethodParameters) {
return;
}
final PsiExpression lockExpression = statement.getLockExpression();
if (!(lockExpression instanceof PsiReferenceExpression)) {
return;
}
final PsiReferenceExpression referenceExpression =
(PsiReferenceExpression)lockExpression;
if (referenceExpression.isQualified()) {
return;
}
boolean localVariable = false;
final PsiElement target = referenceExpression.resolve();
if (target instanceof PsiLocalVariable) {
if (!reportLocalVariables) {
return;
}
localVariable = true;
}
else if (target instanceof PsiParameter) {
final PsiParameter parameter = (PsiParameter)target;
final PsiElement scope = parameter.getDeclarationScope();
if (scope instanceof PsiMethod) {
if (!reportMethodParameters) {
return;
}
}
else {
if (!reportLocalVariables) {
return;
}
localVariable = true;
}
}
else {
return;
}
final PsiClass parentClass =
PsiTreeUtil.getParentOfType(statement, PsiClass.class);
if (!PsiTreeUtil.isAncestor(parentClass, target, true)) {
// different class, probably different thread.
return;
}
registerError(referenceExpression, Boolean.valueOf(localVariable));
}
}
}
|
