1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
|
package com.siyeh.ig.logging;
import com.intellij.codeInspection.LocalInspectionTool;
import com.siyeh.ig.LightInspectionTestCase;
public class PlaceholderCountMatchesArgumentCountInspectionTest extends LightInspectionTestCase {
@Override
protected LocalInspectionTool getInspection() {
return new PlaceholderCountMatchesArgumentCountInspection();
}
@Override
protected String[] getEnvironmentClasses() {
return new String[]{
"package org.slf4j; public interface Logger { void info(String format, Object... arguments); }",
"package org.slf4j; public class LoggerFactory { public static Logger getLogger(Class clazz) { return null; }}"};
}
public void testNoWarn() {
doTest("import org.slf4j.*;\n" +
"class X {\n" +
" void foo() {\n" +
" Logger logger = LoggerFactory.getLogger(X.class);\n" +
" logger.info(\"string {}\", 1);\n" +
" }\n" +
"}"
);
}
public void testMorePlaceholders() {
doTest("import org.slf4j.*;\n" +
"class X {\n" +
" void foo() {\n" +
" Logger logger = LoggerFactory.getLogger(X.class);\n" +
" logger./*'info()' call has fewer arguments (1) than placeholders (2)*/info/**/(\"string {}{}\", 1);\n" +
" }\n" +
"}"
);
}
public void testFewerPlaceholders() {
doTest("import org.slf4j.*;\n" +
"class X {\n" +
" void foo() {\n" +
" Logger logger = LoggerFactory.getLogger(X.class);\n" +
" logger./*'info()' call has more arguments (1) than placeholders (0)*/info/**/(\"string\", 1);\n" +
" }\n" +
"}"
);
}
public void testThrowable() {
doTest("import org.slf4j.*;\n" +
"class X {\n" +
" void foo() {\n" +
" Logger logger = LoggerFactory.getLogger(X.class);\n" +
" logger.info(\"string {}\", 1, new RuntimeException());\n" +
" }\n" +
"}"
);
}
public void testMultiCatch() {
doTest("import org.slf4j.*;\n" +
"class X {\n" +
" private static final Logger logger = LoggerFactory.getLogger( X.class );\n" +
" public void multiCatch() {\n" +
" try {\n" +
" method();\n" +
" } catch ( FirstException|SecondException e ) {\n" +
" logger.info( \"failed with first or second\", e );\n" +
" }\n" +
" }\n" +
" public void method() throws FirstException, SecondException {}\n" +
" public static class FirstException extends Exception { }\n" +
" public static class SecondException extends Exception { }\n" +
"}");
}
public void testNoSlf4j() {
doTest("class FalsePositiveSLF4J {\n" +
" public void method( DefinitelyNotSLF4J definitelyNotSLF4J ) {\n" +
" definitelyNotSLF4J.info( \"not a trace message\", \"not a trace parameter\" );\n" +
" }\n" +
" public interface DefinitelyNotSLF4J {\n" +
" void info( String firstParameter, Object secondParameter );\n" +
" }\n" +
"}");
}
public void testArrayArgument() {
doTest("import org.slf4j.*;" +
"class X {" +
" Logger LOG = LoggerFactory.getLogger( X.class );" +
" void m(String a, int b, Object c) {" +
" LOG.info(\"schnizzle {} for blurb {} in quark {}\", new Object[] {a, b, c});" +
" }" +
"}");
}
public void testUncountableArray() {
doTest("import org.slf4j.*;" +
"class X {" +
" Logger LOG = LoggerFactory.getLogger( X.class );" +
" void m(Object[] objects) {" +
" LOG.info(\"deep cover {} quantum disstressor {} at light speed {}\", objects);" +
" }" +
"}");
}
}
|
