blob: 74162fe82c34c2c34ecad0cb590f56ae5a7463ba (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
|
/*
* Copyright 2000-2014 JetBrains s.r.o.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.jetbrains.plugins.groovy.codeInspection.bugs;
import com.intellij.codeInspection.ProblemDescriptor;
import com.intellij.openapi.diagnostic.Logger;
import com.intellij.openapi.project.Project;
import com.intellij.psi.PsiElement;
import com.intellij.psi.codeStyle.JavaCodeStyleManager;
import com.intellij.util.IncorrectOperationException;
import org.jetbrains.annotations.Nls;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.plugins.groovy.codeInspection.BaseInspection;
import org.jetbrains.plugins.groovy.codeInspection.BaseInspectionVisitor;
import org.jetbrains.plugins.groovy.codeInspection.GroovyFix;
import org.jetbrains.plugins.groovy.codeInspection.GroovyInspectionBundle;
import org.jetbrains.plugins.groovy.dsl.psi.PsiClassCategory;
import org.jetbrains.plugins.groovy.lang.psi.GroovyPsiElementFactory;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.expressions.GrExpression;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.expressions.GrNewExpression;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.typedef.GrTypeDefinition;
import org.jetbrains.plugins.groovy.lang.psi.api.types.GrCodeReferenceElement;
import org.jetbrains.plugins.groovy.lang.psi.util.GroovyCommonClassNames;
/**
* @author Max Medvedev
*/
public class NewInstanceOfSingletonInspection extends BaseInspection {
private static final Logger LOG = Logger.getInstance(NewInstanceOfSingletonInspection.class);
@NotNull
@Override
protected BaseInspectionVisitor buildVisitor() {
return new BaseInspectionVisitor() {
@Override
public void visitNewExpression(GrNewExpression newExpression) {
super.visitNewExpression(newExpression);
final GrCodeReferenceElement refElement = newExpression.getReferenceElement();
if (refElement == null) return;
if (newExpression.getArrayDeclaration() != null) return;
final PsiElement resolved = refElement.resolve();
if (resolved instanceof GrTypeDefinition &&
PsiClassCategory.hasAnnotation((GrTypeDefinition)resolved, GroovyCommonClassNames.GROOVY_LANG_SINGLETON)) {
registerError(newExpression, GroovyInspectionBundle.message("new.instance.of.singleton"));
}
}
};
}
@Override
public boolean isEnabledByDefault() {
return true;
}
@Override
protected GroovyFix buildFix(@NotNull final PsiElement location) {
final GrCodeReferenceElement refElement = ((GrNewExpression)location).getReferenceElement();
LOG.assertTrue(refElement != null);
final GrTypeDefinition singleton = (GrTypeDefinition)refElement.resolve();
LOG.assertTrue(singleton != null);
return new GroovyFix() {
@Override
protected void doFix(Project project, ProblemDescriptor descriptor) throws IncorrectOperationException {
final GrExpression instanceRef =
GroovyPsiElementFactory.getInstance(project).createExpressionFromText(singleton.getQualifiedName() + ".instance");
final GrExpression replaced = ((GrNewExpression)location).replaceWithExpression(instanceRef, true);
JavaCodeStyleManager.getInstance(project).shortenClassReferences(replaced);
}
@NotNull
@Override
public String getName() {
return GroovyInspectionBundle.message("replace.new.expression.with.0.instance", singleton.getName());
}
};
}
@Nls
@NotNull
@Override
public String getGroupDisplayName() {
return CONFUSING_CODE_CONSTRUCTS;
}
@Override
protected String buildErrorString(Object... args) {
return (String)args[0];
}
@Nls
@NotNull
@Override
public String getDisplayName() {
return "New instance of class annotated with @groovy.lang.Singleton";
}
}
|
