blob: 4dd95e9e3b618cd53afd9e98c65d46384c09568e (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
|
/*
* Copyright 2007-2008 Dave Griffith
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.jetbrains.plugins.groovy.codeInspection.confusing;
import com.intellij.psi.PsiElement;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.plugins.groovy.codeInspection.BaseInspection;
import org.jetbrains.plugins.groovy.codeInspection.BaseInspectionVisitor;
import org.jetbrains.plugins.groovy.lang.psi.GroovyPsiElement;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.*;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.blocks.GrOpenBlock;
import org.jetbrains.plugins.groovy.lang.psi.util.PsiUtil;
public class GroovyEmptyStatementBodyInspection extends BaseInspection {
@Override
@NotNull
public String getDisplayName() {
return "Statement with empty body";
}
@Override
@NotNull
public String getGroupDisplayName() {
return CONFUSING_CODE_CONSTRUCTS;
}
@Override
public boolean isEnabledByDefault() {
return true;
}
@Override
public String buildErrorString(Object... args) {
if (args[0] instanceof GrIfStatement) {
return "'#ref' statement has empty branch";
}
else {
return "'#ref' statement has empty body";
}
}
@Override
public BaseInspectionVisitor buildVisitor() {
return new Visitor();
}
private static class Visitor extends BaseInspectionVisitor {
@Override
public void visitWhileStatement(@NotNull GrWhileStatement statement) {
super.visitWhileStatement(statement);
final GrStatement body = statement.getBody();
if (body == null) {
return;
}
if (!isEmpty(body)) {
return;
}
registerStatementError(statement, statement);
}
@Override
public void visitForStatement(@NotNull GrForStatement statement) {
super.visitForStatement(statement);
final GrStatement body = statement.getBody();
if (body == null) {
return;
}
if (!isEmpty(body)) {
return;
}
registerStatementError(statement, statement);
}
@Override
public void visitIfStatement(@NotNull GrIfStatement statement) {
super.visitIfStatement(statement);
final GrStatement thenBranch = statement.getThenBranch();
if (thenBranch != null) {
if (isEmpty(thenBranch)) {
registerStatementError(statement, statement);
return;
}
}
final GrStatement elseBranch = statement.getElseBranch();
if (elseBranch != null) {
if (isEmpty(elseBranch)) {
registerStatementError(statement, statement);
}
}
}
private static boolean isEmpty(GroovyPsiElement body) {
if (!(body instanceof GrBlockStatement)) {
return false;
}
final GrBlockStatement block = (GrBlockStatement)body;
final GrOpenBlock openBlock = block.getBlock();
final PsiElement brace = openBlock.getLBrace();
if (brace == null) return false;
final PsiElement nextNonWhitespace = PsiUtil.skipWhitespaces(brace.getNextSibling(), true);
return nextNonWhitespace == openBlock.getRBrace();
}
}
}
|
