blob: 3d09c275ee3fa2968edf370d66001c18646c81f4 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
|
/*
* Copyright 2000-2014 JetBrains s.r.o.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.jetbrains.plugins.groovy.codeInspection.confusing;
import com.intellij.psi.PsiElement;
import com.intellij.psi.PsiType;
import com.intellij.psi.tree.IElementType;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.plugins.groovy.codeInspection.BaseInspection;
import org.jetbrains.plugins.groovy.codeInspection.BaseInspectionVisitor;
import org.jetbrains.plugins.groovy.lang.lexer.GroovyTokenTypes;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.expressions.GrBinaryExpression;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.expressions.GrExpression;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.expressions.GrParenthesizedExpression;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.expressions.GrUnaryExpression;
import java.util.HashSet;
import java.util.Set;
import static com.intellij.psi.CommonClassNames.JAVA_LANG_STRING;
public class GroovyOverlyComplexArithmeticExpressionInspectionBase extends BaseInspection {
private static final int TERM_LIMIT = 3;
/**
* @noinspection PublicField,WeakerAccess
*/
public int m_limit = TERM_LIMIT;
@Override
@NotNull
public String getDisplayName() {
return "Overly complex arithmetic expression";
}
@Override
@NotNull
public String getGroupDisplayName() {
return CONFUSING_CODE_CONSTRUCTS;
}
private int getLimit() {
return m_limit;
}
@Override
protected String buildErrorString(Object... args) {
return "Overly complex arithmetic expression #loc";
}
@Override
public BaseInspectionVisitor buildVisitor() {
return new Visitor();
}
private class Visitor extends BaseInspectionVisitor {
private final Set<IElementType> arithmeticTokens = new HashSet<IElementType>(5);
{
arithmeticTokens.add(GroovyTokenTypes.mPLUS);
arithmeticTokens.add(GroovyTokenTypes.mMINUS);
arithmeticTokens.add(GroovyTokenTypes.mSTAR);
arithmeticTokens.add(GroovyTokenTypes.mDIV);
arithmeticTokens.add(GroovyTokenTypes.mMOD);
}
@Override
public void visitBinaryExpression(@NotNull GrBinaryExpression expression) {
super.visitBinaryExpression(expression);
checkExpression(expression);
}
@Override
public void visitUnaryExpression(@NotNull GrUnaryExpression expression) {
super.visitUnaryExpression(expression);
checkExpression(expression);
}
@Override
public void visitParenthesizedExpression(GrParenthesizedExpression expression) {
super.visitParenthesizedExpression(expression);
checkExpression(expression);
}
private void checkExpression(GrExpression expression) {
if (isParentArithmetic(expression)) {
return;
}
if (!isArithmetic(expression)) {
return;
}
if (containsStringConcatenation(expression)) {
return;
}
final int numTerms = countTerms(expression);
if (numTerms <= getLimit()) {
return;
}
registerError(expression);
}
private int countTerms(GrExpression expression) {
if (expression == null) {
return 0;
}
if (!isArithmetic(expression)) {
return 1;
}
if (expression instanceof GrBinaryExpression) {
final GrBinaryExpression binaryExpression = (GrBinaryExpression) expression;
final GrExpression lhs = binaryExpression.getLeftOperand();
final GrExpression rhs = binaryExpression.getRightOperand();
return countTerms(lhs) + countTerms(rhs);
} else if (expression instanceof GrUnaryExpression) {
final GrUnaryExpression unaryExpression = (GrUnaryExpression) expression;
final GrExpression operand = unaryExpression.getOperand();
return countTerms(operand);
} else if (expression instanceof GrParenthesizedExpression) {
final GrParenthesizedExpression parenthesizedExpression = (GrParenthesizedExpression) expression;
final GrExpression contents = parenthesizedExpression.getOperand();
return countTerms(contents);
}
return 1;
}
private boolean isParentArithmetic(GrExpression expression) {
final PsiElement parent = expression.getParent();
if (!(parent instanceof GrExpression)) {
return false;
}
return isArithmetic((GrExpression) parent);
}
private boolean isArithmetic(GrExpression expression) {
if (expression instanceof GrBinaryExpression) {
final GrBinaryExpression binaryExpression = (GrBinaryExpression) expression;
final IElementType sign = binaryExpression.getOperationTokenType();
return arithmeticTokens.contains(sign);
} else if (expression instanceof GrUnaryExpression) {
final GrUnaryExpression unaryExpression = (GrUnaryExpression) expression;
final IElementType sign = unaryExpression.getOperationTokenType();
return arithmeticTokens.contains(sign);
} else if (expression instanceof GrParenthesizedExpression) {
final GrParenthesizedExpression parenthesizedExpression = (GrParenthesizedExpression) expression;
final GrExpression contents = parenthesizedExpression.getOperand();
return isArithmetic(contents);
}
return false;
}
private boolean containsStringConcatenation(GrExpression expression) {
if (isString(expression)) {
return true;
}
if (expression instanceof GrBinaryExpression) {
final GrBinaryExpression binaryExpression = (GrBinaryExpression) expression;
final GrExpression lhs = binaryExpression.getLeftOperand();
if (containsStringConcatenation(lhs)) {
return true;
}
final GrExpression rhs = binaryExpression.getRightOperand();
return containsStringConcatenation(rhs);
} else if (expression instanceof GrUnaryExpression) {
final GrUnaryExpression unaryExpression = (GrUnaryExpression) expression;
final GrExpression operand = unaryExpression.getOperand();
return containsStringConcatenation(operand);
} else if (expression instanceof GrParenthesizedExpression) {
final GrParenthesizedExpression parenthesizedExpression = (GrParenthesizedExpression) expression;
final GrExpression contents = parenthesizedExpression.getOperand();
return containsStringConcatenation(contents);
}
return false;
}
private boolean isString(GrExpression expression) {
if (expression == null) {
return false;
}
final PsiType type = expression.getType();
if (type == null) {
return false;
}
return type.equalsToText(JAVA_LANG_STRING);
}
}
}
|
