blob: d03f36f9f1fa3d22eafbd3f61162badea7db9295 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
|
/*
* Copyright 2007-2008 Dave Griffith, Bas Leijdekkers
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.jetbrains.plugins.groovy.codeInspection.control;
import com.intellij.codeInspection.ProblemDescriptor;
import com.intellij.openapi.project.Project;
import com.intellij.psi.PsiElement;
import com.intellij.util.IncorrectOperationException;
import org.jetbrains.annotations.NonNls;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.plugins.groovy.codeInspection.BaseInspection;
import org.jetbrains.plugins.groovy.codeInspection.BaseInspectionVisitor;
import org.jetbrains.plugins.groovy.codeInspection.GroovyFix;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.GrIfStatement;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.GrStatement;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.expressions.GrExpression;
public class GroovyConstantIfStatementInspection extends BaseInspection {
@Override
@NotNull
public String getGroupDisplayName() {
return CONTROL_FLOW;
}
@Override
@NotNull
public String getDisplayName() {
return "Constant if statement";
}
@Override
public boolean isEnabledByDefault() {
return true;
}
@Override
@NotNull
protected String buildErrorString(Object... args) {
return "#ref statement can be simplified #loc";
}
@Override
public BaseInspectionVisitor buildVisitor() {
return new ConstantIfStatementVisitor();
}
@Override
public GroovyFix buildFix(PsiElement location) {
return new ConstantIfStatementFix();
}
private static class ConstantIfStatementFix extends GroovyFix {
@Override
@NotNull
public String getName() {
return "Simplify";
}
@Override
public void doFix(Project project, ProblemDescriptor descriptor)
throws IncorrectOperationException {
final PsiElement ifKeyword = descriptor.getPsiElement();
final GrIfStatement ifStatement = (GrIfStatement) ifKeyword.getParent();
assert ifStatement != null;
final GrStatement thenBranch = ifStatement.getThenBranch();
final GrStatement elseBranch = ifStatement.getElseBranch();
final GrExpression condition = ifStatement.getCondition();
// todo still needs some handling for conflicting declarations
if (isFalse(condition)) {
if (elseBranch != null) {
replaceStatement(ifStatement, (GrStatement)elseBranch.copy());
} else {
ifStatement.delete();
}
} else {
replaceStatement(ifStatement, (GrStatement)thenBranch.copy());
}
}
}
private static class ConstantIfStatementVisitor
extends BaseInspectionVisitor {
@Override
public void visitIfStatement(GrIfStatement statement) {
super.visitIfStatement(statement);
final GrExpression condition = statement.getCondition();
if (condition == null) {
return;
}
final GrStatement thenBranch = statement.getThenBranch();
if (thenBranch == null) {
return;
}
if (isTrue(condition) || isFalse(condition)) {
registerStatementError(statement);
}
}
}
private static boolean isFalse(GrExpression expression) {
@NonNls final String text = expression.getText();
return "false".equals(text);
}
private static boolean isTrue(GrExpression expression) {
@NonNls final String text = expression.getText();
return "true".equals(text);
}
}
|
