blob: d203771f827bac58763d3057f8b477cd266e2ae3 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
|
/*
* Copyright 2007-2013 Dave Griffith, Bas Leijdekkers
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.jetbrains.plugins.groovy.codeInspection.control;
import com.intellij.psi.PsiComment;
import com.intellij.psi.PsiElement;
import com.intellij.psi.PsiWhiteSpace;
import com.intellij.psi.util.PsiTreeUtil;
import org.jetbrains.annotations.Nls;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
import org.jetbrains.plugins.groovy.codeInspection.BaseInspection;
import org.jetbrains.plugins.groovy.codeInspection.BaseInspectionVisitor;
import org.jetbrains.plugins.groovy.codeInspection.utils.ControlFlowUtils;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.GrStatement;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.GrSwitchStatement;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.clauses.GrCaseSection;
import java.util.regex.Pattern;
public class GroovyFallthroughInspection extends BaseInspection {
@Override
@Nls
@NotNull
public String getGroupDisplayName() {
return CONTROL_FLOW;
}
@Override
@Nls
@NotNull
public String getDisplayName() {
return "Fall-through in switch statement";
}
@Override
@Nullable
protected String buildErrorString(Object... args) {
return "Fall-through in switch statement #loc";
}
@Override
public boolean isEnabledByDefault() {
return true;
}
@NotNull
@Override
public BaseInspectionVisitor buildVisitor() {
return new Visitor();
}
private static class Visitor extends BaseInspectionVisitor {
private static final Pattern commentPattern = Pattern.compile("(?i)falls?\\s*thro?u");
@Override
public void visitSwitchStatement(GrSwitchStatement switchStatement) {
super.visitSwitchStatement(switchStatement);
final GrCaseSection[] caseSections = switchStatement.getCaseSections();
for (int i = 1; i < caseSections.length; i++) {
final GrCaseSection caseSection = caseSections[i];
if (isCommented(caseSection)) {
continue;
}
final GrCaseSection previousCaseSection = caseSections[i - 1];
final GrStatement[] statements = previousCaseSection.getStatements();
if (statements.length == 0) {
registerError(caseSection.getFirstChild());
}
else {
final GrStatement lastStatement = statements[statements.length - 1];
if (ControlFlowUtils.statementMayCompleteNormally(lastStatement)) {
registerError(caseSection.getFirstChild());
}
}
}
}
private static boolean isCommented(GrCaseSection caseClause) {
final PsiElement element = PsiTreeUtil.skipSiblingsBackward(caseClause, PsiWhiteSpace.class);
if (!(element instanceof PsiComment)) {
return false;
}
final String commentText = element.getText();
return commentPattern.matcher(commentText).find();
}
}
}
|
