blob: a65f3b6f987a166fae99807e06df32e8251c78f4 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
|
/*
* Copyright 2007-2008 Dave Griffith
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.jetbrains.plugins.groovy.codeInspection.control;
import com.intellij.codeInspection.ProblemDescriptor;
import com.intellij.openapi.project.Project;
import com.intellij.psi.PsiElement;
import com.intellij.psi.PsiType;
import com.intellij.util.IncorrectOperationException;
import org.jetbrains.annotations.NonNls;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.plugins.groovy.codeInspection.BaseInspection;
import org.jetbrains.plugins.groovy.codeInspection.BaseInspectionVisitor;
import org.jetbrains.plugins.groovy.codeInspection.GroovyFix;
import org.jetbrains.plugins.groovy.lang.psi.util.ErrorUtil;
import org.jetbrains.plugins.groovy.lang.psi.impl.utils.BoolUtils;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.expressions.GrConditionalExpression;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.expressions.GrExpression;
public class GroovyTrivialConditionalInspection extends BaseInspection {
@Override
@NotNull
public String getDisplayName() {
return "Redundant conditional expression";
}
@Override
@NotNull
public String getGroupDisplayName() {
return CONTROL_FLOW;
}
@Override
public boolean isEnabledByDefault() {
return true;
}
@NotNull
@Override
public BaseInspectionVisitor buildVisitor() {
return new UnnecessaryConditionalExpressionVisitor();
}
@Override
public String buildErrorString(Object... args) {
final GrConditionalExpression exp = (GrConditionalExpression) args[0];
return "'" + exp.getText() + "' can be simplified to '" + calculateReplacementExpression(exp) + "' #loc";
}
private static String calculateReplacementExpression(GrConditionalExpression exp) {
final GrExpression thenExpression = exp.getThenBranch();
final GrExpression elseExpression = exp.getElseBranch();
final GrExpression condition = exp.getCondition();
if (isFalse(thenExpression) && isTrue(elseExpression)) {
return BoolUtils.getNegatedExpressionText(condition);
} else {
return condition.getText();
}
}
@Override
public GroovyFix buildFix(@NotNull PsiElement location) {
return new TrivialConditionalFix();
}
private static class TrivialConditionalFix extends GroovyFix {
@Override
@NotNull
public String getName() {
return "Simplify";
}
@Override
public void doFix(Project project, ProblemDescriptor descriptor)
throws IncorrectOperationException {
final GrConditionalExpression expression = (GrConditionalExpression) descriptor.getPsiElement();
final String newExpression = calculateReplacementExpression(expression);
replaceExpression(expression, newExpression);
}
}
private static class UnnecessaryConditionalExpressionVisitor
extends BaseInspectionVisitor {
@Override
public void visitConditionalExpression(GrConditionalExpression exp) {
super.visitConditionalExpression(exp);
final GrExpression condition = exp.getCondition();
final PsiType type = condition.getType();
if (type == null || !(PsiType.BOOLEAN.isAssignableFrom(type))) {
return;
}
if (ErrorUtil.containsError(exp)) return;
final GrExpression thenExpression = exp.getThenBranch();
if (thenExpression == null) {
return;
}
final GrExpression elseExpression = exp.getElseBranch();
if (elseExpression == null) {
return;
}
if ((isFalse(thenExpression) && isTrue(elseExpression))
|| (isTrue(thenExpression) && isFalse(elseExpression))) {
registerError(exp);
}
}
}
private static boolean isFalse(GrExpression expression) {
@NonNls final String text = expression.getText();
return "false".equals(text);
}
private static boolean isTrue(GrExpression expression) {
@NonNls final String text = expression.getText();
return "true".equals(text);
}
}
|
