blob: 293091e536f83c152bfc7918b9537ab947ed1ca7 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
|
/*
* Copyright 2007-2008 Dave Griffith
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.jetbrains.plugins.groovy.codeInspection.threading;
import com.intellij.psi.PsiClass;
import com.intellij.psi.PsiElement;
import com.intellij.psi.PsiField;
import com.intellij.psi.PsiModifier;
import com.intellij.psi.util.PsiTreeUtil;
import org.jetbrains.annotations.Nls;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.plugins.groovy.codeInspection.BaseInspection;
import org.jetbrains.plugins.groovy.codeInspection.BaseInspectionVisitor;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.GrSynchronizedStatement;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.expressions.GrExpression;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.expressions.GrReferenceExpression;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.typedef.members.GrMethod;
import org.jetbrains.plugins.groovy.lang.psi.util.PsiUtil;
public class GroovyAccessToStaticFieldLockedOnInstanceInspection
extends BaseInspection {
@Override
public boolean isEnabledByDefault() {
return true;
}
@Override
@Nls
@NotNull
public String getGroupDisplayName() {
return THREADING_ISSUES;
}
@Override
@NotNull
public String getDisplayName() {
return "Access to static field locked on instance data";
}
@Override
@NotNull
protected String buildErrorString(Object... infos) {
return "Access to static field <code>#ref</code> locked on instance data #loc";
}
@NotNull
@Override
public BaseInspectionVisitor buildVisitor() {
return new Visitor();
}
private static class Visitor
extends BaseInspectionVisitor {
@Override
public void visitReferenceExpression(
@NotNull GrReferenceExpression expression) {
super.visitReferenceExpression(expression);
boolean isLockedOnInstance = false;
boolean isLockedOnClass = false;
final GrMethod containingMethod =
PsiTreeUtil.getParentOfType(expression, GrMethod.class);
if (containingMethod != null &&
containingMethod.hasModifierProperty(
PsiModifier.SYNCHRONIZED)) {
if (containingMethod.hasModifierProperty(
PsiModifier.STATIC)) {
isLockedOnClass = true;
} else {
isLockedOnInstance = true;
}
}
PsiElement elementToCheck = expression;
while (true) {
final GrSynchronizedStatement syncStatement = PsiTreeUtil.getParentOfType(elementToCheck, GrSynchronizedStatement.class);
if (syncStatement == null) {
break;
}
final GrExpression lockExpression = syncStatement.getMonitor();
if (lockExpression instanceof GrReferenceExpression && PsiUtil.isThisReference(lockExpression)) {
isLockedOnInstance = true;
}
else if (lockExpression instanceof GrReferenceExpression) {
final GrReferenceExpression reference = (GrReferenceExpression) lockExpression;
final PsiElement referent = reference.resolve();
if (referent instanceof PsiField) {
final PsiField referentField = (PsiField) referent;
if (referentField.hasModifierProperty(PsiModifier.STATIC)) {
isLockedOnClass = true;
} else {
isLockedOnInstance = true;
}
}
}
elementToCheck = syncStatement;
}
if (!isLockedOnInstance || isLockedOnClass) {
return;
}
final PsiElement referent = expression.resolve();
if (!(referent instanceof PsiField)) {
return;
}
final PsiField referredField = (PsiField) referent;
if (!referredField.hasModifierProperty(PsiModifier.STATIC) ||
isConstant(referredField)) {
return;
}
final PsiClass containingClass = referredField.getContainingClass();
if (!PsiTreeUtil.isAncestor(containingClass, expression, false)) {
return;
}
registerError(expression);
}
private static boolean isConstant(PsiField field) {
return field.hasModifierProperty(PsiModifier.FINAL);
}
}
}
|
