blob: c1b829ecc21de630918cd34d91eb9e9f011a0844 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
|
/*
* Copyright 2007-2008 Dave Griffith
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.jetbrains.plugins.groovy.codeInspection.threading;
import com.intellij.codeInspection.ui.SingleCheckboxOptionsPanel;
import com.intellij.psi.PsiElement;
import com.intellij.psi.PsiField;
import com.intellij.psi.PsiModifier;
import org.jetbrains.annotations.Nls;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
import org.jetbrains.plugins.groovy.codeInspection.BaseInspection;
import org.jetbrains.plugins.groovy.codeInspection.BaseInspectionVisitor;
import org.jetbrains.plugins.groovy.codeInspection.utils.ControlFlowUtils;
import org.jetbrains.plugins.groovy.codeInspection.utils.EquivalenceChecker;
import org.jetbrains.plugins.groovy.codeInspection.utils.SideEffectChecker;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.GrIfStatement;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.GrStatement;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.GrSynchronizedStatement;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.blocks.GrCodeBlock;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.expressions.GrAssignmentExpression;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.expressions.GrExpression;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.expressions.GrReferenceExpression;
import javax.swing.*;
public class GroovyDoubleCheckedLockingInspection extends BaseInspection {
/**
* @noinspection PublicField,WeakerAccess
*/
public boolean ignoreOnVolatileVariables = false;
@Override
@Nls
@NotNull
public String getGroupDisplayName() {
return THREADING_ISSUES;
}
@Override
@NotNull
public String getDisplayName() {
return "Double-checked locking";
}
@Override
@NotNull
protected String buildErrorString(Object... infos) {
return "Double-checked locking #loc";
}
@Override
@Nullable
public JComponent createOptionsPanel() {
return new SingleCheckboxOptionsPanel("Ignore double-checked locking on volatile fields", this,
"ignoreOnVolatileVariables"
);
}
@NotNull
@Override
public BaseInspectionVisitor buildVisitor() {
return new DoubleCheckedLockingVisitor();
}
private class DoubleCheckedLockingVisitor
extends BaseInspectionVisitor {
@Override
public void visitIfStatement(@NotNull GrIfStatement statement) {
super.visitIfStatement(statement);
final GrExpression outerCondition = statement.getCondition();
if (outerCondition == null) {
return;
}
if (SideEffectChecker.mayHaveSideEffects(outerCondition)) {
return;
}
GrStatement thenBranch = statement.getThenBranch();
if (thenBranch == null) {
return;
}
thenBranch = ControlFlowUtils.stripBraces(thenBranch);
if (!(thenBranch instanceof GrSynchronizedStatement)) {
return;
}
final GrSynchronizedStatement syncStatement =
(GrSynchronizedStatement) thenBranch;
final GrCodeBlock body = syncStatement.getBody();
if (body == null) {
return;
}
final GrStatement[] statements = body.getStatements();
if (statements.length != 1) {
return;
}
if (!(statements[0] instanceof GrIfStatement)) {
return;
}
final GrIfStatement innerIf = (GrIfStatement) statements[0];
final GrExpression innerCondition = innerIf.getCondition();
if (innerCondition == null) {
return;
}
if (!EquivalenceChecker.expressionsAreEquivalent(innerCondition, outerCondition)) {
return;
}
if (ignoreOnVolatileVariables &&
ifStatementAssignsVolatileVariable(innerIf)) {
return;
}
registerStatementError(statement);
}
private boolean ifStatementAssignsVolatileVariable(
GrIfStatement statement) {
GrStatement innerThen = statement.getThenBranch();
innerThen = ControlFlowUtils.stripBraces(innerThen);
if (!(innerThen instanceof GrAssignmentExpression)) {
return false;
}
final GrAssignmentExpression assignmentExpression =
(GrAssignmentExpression) innerThen;
final GrExpression lhs =
assignmentExpression.getLValue();
if (!(lhs instanceof GrReferenceExpression)) {
return false;
}
final GrReferenceExpression referenceExpression =
(GrReferenceExpression) lhs;
final PsiElement element =
referenceExpression.resolve();
if (!(element instanceof PsiField)) {
return false;
}
final PsiField field = (PsiField) element;
return field.hasModifierProperty(PsiModifier.VOLATILE);
}
}
}
|
