blob: ccf799ddd86dd85fdcb61804739241697b00d9c5 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
|
/*
* Copyright 2007-2008 Dave Griffith
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.jetbrains.plugins.groovy.codeInspection.threading;
import com.intellij.psi.*;
import com.intellij.psi.util.PsiTreeUtil;
import org.jetbrains.annotations.Nls;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.plugins.groovy.codeInspection.BaseInspection;
import org.jetbrains.plugins.groovy.codeInspection.BaseInspectionVisitor;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.GrSynchronizedStatement;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.expressions.GrReferenceExpression;
import org.jetbrains.plugins.groovy.lang.psi.api.statements.typedef.members.GrMethod;
public class GroovyPublicFieldAccessedInSynchronizedContextInspection
extends BaseInspection {
@Override
@Nls
@NotNull
public String getGroupDisplayName() {
return THREADING_ISSUES;
}
@Override
@NotNull
public String getDisplayName() {
return "Non-private field accessed in synchronized context";
}
@Override
@NotNull
protected String buildErrorString(Object... infos) {
return "Non-private field <code>#ref</code> accessed in synchronized context #loc";
}
@NotNull
@Override
public BaseInspectionVisitor buildVisitor() {
return new PublicFieldAccessedInSynchronizedContextVisitor();
}
private static class PublicFieldAccessedInSynchronizedContextVisitor
extends BaseInspectionVisitor {
@Override
public void visitReferenceExpression(
@NotNull GrReferenceExpression expression) {
final PsiElement element = expression.resolve();
if (!(element instanceof PsiField)) {
return;
}
final PsiField field = (PsiField) element;
if (field.hasModifierProperty(PsiModifier.PRIVATE) ||
field.hasModifierProperty(PsiModifier.FINAL)) {
return;
}
if (!isInSynchronizedContext(expression)) {
return;
}
final PsiClass containingClass = field.getContainingClass();
if (containingClass.hasModifierProperty(PsiModifier.PRIVATE)) {
return;
}
registerError(expression);
}
private static boolean isInSynchronizedContext(PsiElement element) {
final PsiElement context =
PsiTreeUtil.getParentOfType(element, GrMethod.class,
GrSynchronizedStatement.class);
if (context instanceof GrSynchronizedStatement) {
return true;
}
if (context != null) {
final PsiModifierListOwner modifierListOwner =
(PsiModifierListOwner) context;
if (modifierListOwner.hasModifierProperty(
PsiModifier.SYNCHRONIZED)) {
return true;
}
}
return false;
}
}
}
|
