From 630e6d6877bf424e70519a612e1f059169c498ed Mon Sep 17 00:00:00 2001 From: Vadim Tryshev Date: Tue, 8 May 2018 18:59:18 -0700 Subject: Fixing app transition tests Using WINDOWS_DRAWN_DELAY where needed, switching from relying on Recents activity to the Launcher one. Removing cold launches in the beginning in removeAdditionalLaunchInfo. Bug: 72967764 Test: Running app transition tests locally Change-Id: Iec8c2ad2cdfc0fb2e570f114cd26897f3607e71f --- .../loganalysis/item/TransitionDelayItem.java | 22 ++++++++++++++++++++-- .../loganalysis/parser/EventsLogParser.java | 6 +++++- 2 files changed, 25 insertions(+), 3 deletions(-) diff --git a/src/com/android/loganalysis/item/TransitionDelayItem.java b/src/com/android/loganalysis/item/TransitionDelayItem.java index b91f926..6e09d4b 100644 --- a/src/com/android/loganalysis/item/TransitionDelayItem.java +++ b/src/com/android/loganalysis/item/TransitionDelayItem.java @@ -32,9 +32,17 @@ public class TransitionDelayItem extends GenericItem { public static final String TRANSITION_DELAY = "TRANSITION_DELAY"; /** Constant for JSON output */ public static final String DATE_TIME = "DATE_TIME"; + /** Constant for JSON output */ + public static final String WINDOW_DRAWN_DELAY = "WINDOW_DRAWN_DELAY"; - private static final Set ATTRIBUTES = new HashSet(Arrays.asList( - COMPONENT_NAME, START_WINDOW_DELAY, TRANSITION_DELAY, DATE_TIME)); + private static final Set ATTRIBUTES = + new HashSet( + Arrays.asList( + COMPONENT_NAME, + START_WINDOW_DELAY, + TRANSITION_DELAY, + DATE_TIME, + WINDOW_DRAWN_DELAY)); /** * The constructor for {@link TransitionDelayItem}. @@ -79,4 +87,14 @@ public class TransitionDelayItem extends GenericItem { public void setDateTime(String dateTime) { setAttribute(DATE_TIME, dateTime); } + + public Long getWindowDrawnDelay() { + return getAttribute(WINDOW_DRAWN_DELAY) != null + ? (Long) getAttribute(WINDOW_DRAWN_DELAY) + : null; + } + + public void setWindowDrawnDelay(long windowDrawnDelay) { + setAttribute(WINDOW_DRAWN_DELAY, windowDrawnDelay); + } } diff --git a/src/com/android/loganalysis/parser/EventsLogParser.java b/src/com/android/loganalysis/parser/EventsLogParser.java index b69948d..1e1803c 100644 --- a/src/com/android/loganalysis/parser/EventsLogParser.java +++ b/src/com/android/loganalysis/parser/EventsLogParser.java @@ -54,6 +54,7 @@ public class EventsLogParser implements IParser { private static final String TRANSITION_DELAY_KEY = "319"; private static final String STARTING_WINDOW_DELAY_KEY = "321"; private static final String COLD_LAUNCH_KEY = "945"; + private static final String WINDOWS_DRAWN_DELAY_KEY = "322"; @Override public IItem parse(List lines) { @@ -80,13 +81,16 @@ public class EventsLogParser implements IParser { TransitionDelayItem delayItem = new TransitionDelayItem(); if (null != transitionInfoMap.get(PACKAGE_KEY) && null != transitionInfoMap.get(ACTIVITY_KEY) - && null != transitionInfoMap.get(TRANSITION_DELAY_KEY)) { + && null != transitionInfoMap.get(TRANSITION_DELAY_KEY) + && null != transitionInfoMap.get(WINDOWS_DRAWN_DELAY_KEY)) { delayItem.setComponentName(transitionInfoMap.get(PACKAGE_KEY) + "/" + transitionInfoMap.get(ACTIVITY_KEY)); delayItem.setTransitionDelay(Long.parseLong(transitionInfoMap .get(TRANSITION_DELAY_KEY))); delayItem.setDateTime(String.format("%s %s", match.group(DATE), match.group(TIME))); + delayItem.setWindowDrawnDelay( + Long.parseLong(transitionInfoMap.get(WINDOWS_DRAWN_DELAY_KEY))); } if (transitionInfoMap.containsKey(COLD_LAUNCH_KEY)) { if (null != transitionInfoMap.get(STARTING_WINDOW_DELAY_KEY)) { -- cgit v1.2.3