aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-01-22Snap for 7095583 from 5197623930b8c7b7cad418f2bee37e233e50da90 to sc-releaseandroid-vts-12.0_r9android-vts-12.0_r8android-vts-12.0_r7android-vts-12.0_r6android-vts-12.0_r5android-vts-12.0_r4android-vts-12.0_r3android-vts-12.0_r2android-vts-12.0_r12android-vts-12.0_r11android-vts-12.0_r10android-vts-12.0_r1android-security-12.0.0_r60android-security-12.0.0_r59android-security-12.0.0_r58android-security-12.0.0_r57android-security-12.0.0_r56android-security-12.0.0_r55android-security-12.0.0_r54android-security-12.0.0_r53android-security-12.0.0_r52android-security-12.0.0_r51android-security-12.0.0_r50android-security-12.0.0_r49android-security-12.0.0_r48android-security-12.0.0_r47android-security-12.0.0_r46android-security-12.0.0_r45android-security-12.0.0_r44android-security-12.0.0_r43android-security-12.0.0_r42android-security-12.0.0_r41android-security-12.0.0_r40android-security-12.0.0_r39android-security-12.0.0_r38android-security-12.0.0_r37android-security-12.0.0_r36android-security-12.0.0_r35android-security-12.0.0_r34android-platform-12.0.0_r9android-platform-12.0.0_r8android-platform-12.0.0_r7android-platform-12.0.0_r6android-platform-12.0.0_r5android-platform-12.0.0_r4android-platform-12.0.0_r32android-platform-12.0.0_r31android-platform-12.0.0_r30android-platform-12.0.0_r3android-platform-12.0.0_r29android-platform-12.0.0_r28android-platform-12.0.0_r27android-platform-12.0.0_r26android-platform-12.0.0_r25android-platform-12.0.0_r24android-platform-12.0.0_r23android-platform-12.0.0_r22android-platform-12.0.0_r21android-platform-12.0.0_r20android-platform-12.0.0_r2android-platform-12.0.0_r19android-platform-12.0.0_r18android-platform-12.0.0_r17android-platform-12.0.0_r16android-platform-12.0.0_r15android-platform-12.0.0_r14android-platform-12.0.0_r13android-platform-12.0.0_r12android-platform-12.0.0_r11android-platform-12.0.0_r10android-platform-12.0.0_r1android-cts-12.0_r9android-cts-12.0_r8android-cts-12.0_r7android-cts-12.0_r6android-cts-12.0_r5android-cts-12.0_r4android-cts-12.0_r3android-cts-12.0_r2android-cts-12.0_r12android-cts-12.0_r11android-cts-12.0_r10android-cts-12.0_r1android-12.0.0_r9android-12.0.0_r8android-12.0.0_r34android-12.0.0_r33android-12.0.0_r31android-12.0.0_r30android-12.0.0_r3android-12.0.0_r25android-12.0.0_r2android-12.0.0_r11android-12.0.0_r10android-12.0.0_r1android12-tests-releaseandroid12-security-releaseandroid12-s5-releaseandroid12-s4-releaseandroid12-s3-releaseandroid12-s2-releaseandroid12-s1-releaseandroid12-releaseandroid12-platform-releaseandroid-build-team Robot
Change-Id: I40a0053d0e8aef27e8ef066e320a3256f38e6009
2021-01-21Add aidl-format as a new builtin hook am: 147b6c35e1android-mainline-12.0.0_r5android-mainline-12.0.0_r4android-mainline-12.0.0_r39android-mainline-12.0.0_r36android-mainline-12.0.0_r22android-mainline-12.0.0_r19android-12.0.0_r32android-12.0.0_r29android-12.0.0_r28android-12.0.0_r27android-12.0.0_r26android-12.0.0_r21android-12.0.0_r20android-12.0.0_r19android-12.0.0_r18android-12.0.0_r16android12-qpr1-releaseandroid12-qpr1-d-s3-releaseandroid12-qpr1-d-s2-releaseandroid12-qpr1-d-s1-releaseandroid12-qpr1-d-releaseandroid12-devandroid12--mainline-releaseJiyong Park
Original change: https://android-review.googlesource.com/c/platform/tools/repohooks/+/1553823 MUST ONLY BE SUBMITTED BY AUTOMERGER Change-Id: Ieb6bbd35340e91586d64ff522174c53a27016085
2021-01-21Add aidl-format as a new builtin hookJiyong Park
aidl-format formats AIDL files. Bug: 144540481 Test: Add `aidl_format = true` to /system/tools/aidl/REUPLOAD.cfg, make a poorly formatted change in one of the AIDL file in the repo. Creating a commit and executing `repo upload` caught it and did an automatic fixup. [FAILED] aidl_format FILES: ('tests/android/aidl/tests/ITestService.aidl',) 17,18d16 ... [RUNNING 5/5] aidl_format An automatic fix can be attempted for the "aidl_format" hook. Do you want to run it? (Yes/no)? yes Fix successfully applied. Amend the current commit before attempting to upload again. [FAILED] repohooks for platform/system/tools/aidl failed in 10.274s FATAL: Preupload failed due to above error(s). Change-Id: I3081360840dfbe989908cdffe189573799fc29ab
2021-01-07Snap for 7066627 from 5815ef836cf0f90a0f3ee7c4925cbe487d5d4e76 to sc-releaseandroid-build-team Robot
Change-Id: I0c8239db9b851ba4b08b4e04f3d6cfa6c3723f4a
2021-01-06pre-upload/pylint: drop support for Python 3.5 am: 2729e11af0Mike Frysinger
Original change: https://android-review.googlesource.com/c/platform/tools/repohooks/+/1373920 MUST ONLY BE SUBMITTED BY AUTOMERGER Change-Id: I8be1bd9e133bad65c2cf6a55ae3b60ef141d3200
2020-12-12pre-upload/pylint: drop support for Python 3.5Mike Frysinger
We've been emitting warnings about this for almost a year. Bug: None Test: `repo upload` still works w/Python 3.6 Change-Id: Iaead2a48ac125749176925302bf32e655384c965
2020-12-05Snap for 7013096 from ea6c7d7c9177be09d2386ae4adc319b62193b39c to sc-releaseandroid-build-team Robot
Change-Id: I3b55743ca59e0bb8a3d78558ab79146697e6a243
2020-12-05pre-upload: warn whenever a hook is too slow am: 8f1ceeb31dMike Frysinger
Original change: https://android-review.googlesource.com/c/platform/tools/repohooks/+/1515460 Change-Id: I7e38ffca92d04ddcce84ef12471dbbdb84ab4855
2020-12-02Snap for 7005317 from 9156aa854ca217f25838e4bdc05772c1533b503d to sc-releaseandroid-build-team Robot
Change-Id: I64b6b049c23b0414595ec3bbb7e9541e44abf651
2020-12-01pre-upload: warn whenever a hook is too slowMike Frysinger
Bug: None Test: added some slow hooks and reviewed the logged output Change-Id: I19b024e995b564a12d929db2c5cf15a3e5a4a2b6
2020-12-01drop file coding & print_function import am: 6c6f9ee983Mike Frysinger
Original change: https://android-review.googlesource.com/c/platform/tools/repohooks/+/1515081 Change-Id: Icb2d75c6ba4a2337f857540f83f94e8772821cd8
2020-12-01drop file coding & print_function importMike Frysinger
These are only used by Python 2 which we don't support. Bug: None Test: unittests pass Change-Id: If5f26ca655ce58a9968eaa624424cf5186cf9625
2020-11-20Snap for 6984833 from 5902ffe291567512c6f5dd8776a51089ee7fd4dc to sc-releaseandroid-build-team Robot
Change-Id: I3e1e41bf4c3d680dc8125f5a69dbd1f95c072324
2020-11-19Fix issue with triple quoted relnotes am: fc3ee954f2Nick Anthony
Original change: https://android-review.googlesource.com/c/platform/tools/repohooks/+/1504936 Change-Id: I7e8c7b223cd20bf54fbfc17ef6dc9f66cb3a3031
2020-11-19Fix issue with triple quoted relnotesNick Anthony
This accounts for the case where we use triple quotes, but check for singular quotes. Triple quotes are supported, so we need to make sure we account for them when checking correctness. This also fixes a triple quote use case that is technically correct, but not supported. Bug: 173702182 Test: ./hooks_unittest.py Change-Id: I0b6e6deeac0addc3939b27db36a6ba47ff4bd2da
2020-11-17Snap for 6976352 from 6b03658ce850c874d2c028000c4c9fd9277476a2 to sc-releaseandroid-build-team Robot
Change-Id: I174fc7f40d1fe674f79e8529695cc7d5c6530b6d
2020-11-16Add checking for unescaped quotes in a Relnote tag am: 2f5ba44e26Nick Anthony
Original change: https://android-review.googlesource.com/c/platform/tools/repohooks/+/1490697 Change-Id: I7734954e62f9a8b5ee53a064f341238b0af490e0
2020-11-06Add checking for unescaped quotes in a Relnote tagNick Anthony
Because we need the quotes to check for starting and ending Relnote tags, having unescaped quotes in the release note causes the parsing to truncate at that unescaped release note. So the following scenarios will now be disallowed: Relnote: There are "quotes" in this relnote. Relnote: "There are "quotes" in this relnote." Relnote: "There are unescaped quotes in the second half of this "sentence"." Bug: 172663867 Test: ./pre-upload.py Change-Id: Idc3769eab64aff7455453b9d50317e0d0cad2a44
2020-11-05Snap for 6953012 from 4b7a5e649c524544fbfc71095f41966f4d26bb92 to sc-releaseandroid-build-team Robot
Change-Id: I2e932f47cb1541e2a338b24d1f98301a740241d1
2020-11-04sixish: delete Python 2/3 compat module am: 737bf2785dMike Frysinger
Original change: https://android-review.googlesource.com/c/platform/tools/repohooks/+/1486482 Change-Id: I959401c88303f39673eb837873a9f2581a600c0c
2020-11-03sixish: delete Python 2/3 compat moduleMike Frysinger
We require Python 3 everywhere, so no point in this. Bug: None Test: unittests pass Change-Id: If47bc351829610f7d7677f5255dc433ca1294079
2020-10-21Snap for 6919011 from 3785f05256bf78719082cef93aaed3d08c1863d8 to sc-releaseandroid-build-team Robot
Change-Id: I7b26cb2dc11ee19641428bf06c2d99463d844889
2020-10-20Add support for automatic fixups to gofmt. am: 239625cee5Liz Kammer
Original change: https://android-review.googlesource.com/c/platform/tools/repohooks/+/1408931 Change-Id: Ieb4c41d997b5ddd49d9f58a1f257e56e53456dd0
2020-10-20Add support for automatic fixups to gofmt.androidx-print-releaseLiz Kammer
gofmt -w writes the gofmt result to the source file for the files that gofmt reports issues. Bug: 116112526 Test: ran hook for gofmt can now auto-fix formatting Change-Id: Ic676a588a567fbe5cf3f7a1411ac8048bde2af06
2020-09-18Snap for 6845284 from eb433868757764e154d396d3627417747db9a743 to sc-releaseandroid-build-team Robot
Change-Id: I8b68ac1121c2571f3f6f843c0fa3ebad89b98488
2020-09-17hooks: support Python 3.6 for ExclusionScope am: 573d316aa2android-mainline-11.0.0_r35android-11.0.0_r30android11-qpr1-c-releaseThiébaud Weksteen
Original change: https://android-review.googlesource.com/c/platform/tools/repohooks/+/1428528 Change-Id: Ie5f6a45ff10bffed2d6e1a2da1115cb2a8202c3a
2020-09-16hooks: support Python 3.6 for ExclusionScopeThiébaud Weksteen
re.Pattern was only introduced in Python 3.7. Test: ./pre-upload Bug: 168593718 Change-Id: I9dc685a8d1863808d9c475539a8f1fdbd96474d0
2020-09-10Snap for 6823668 from 9fed6d949cc19977ea51abd67579702cc59244da to sc-releaseandroid-build-team Robot
Change-Id: I3bb44596f9f8bcad7bf3e7e52995fdcf74e62456
2020-09-09tools: switch all our tools to python3 shebang am: 5be91ca1c2Mike Frysinger
Original change: https://android-review.googlesource.com/c/platform/tools/repohooks/+/1422908 Change-Id: I92a7234bfbfd5076856a51ccca953aa6889c4611
2020-09-09tools: switch all our tools to python3 shebangMike Frysinger
We did this for pylint already, so switch the rest too. Bug: None Test: running each tool with --help works Change-Id: I0c6156cbcfabf2ebb7874cbb8a52059b1a88dfcc
2020-09-09Snap for 6820723 from 09cc9a71c6836e421a6d40f4df52d2ce5a66a496 to sc-releaseandroid-build-team Robot
Change-Id: Id0c0092442d10282e2aef4140d51a5b367934c69
2020-09-08Add [Builtin Hooks Exclude Paths] section am: ea52820de8Thiébaud Weksteen
Original change: https://android-review.googlesource.com/c/platform/tools/repohooks/+/1395027 Change-Id: Ia33c2a2caf6d02259fb3b393157a08d7e5e64a3f
2020-09-03Snap for 6809790 from 5e2fb9aa23ecc7265773ee69a0d20830f52b81c9 to sc-releaseandroid-build-team Robot
Change-Id: I35431ec9ac6a5c004b9ec4a31fffed818c5f8f22
2020-09-02Add [Builtin Hooks Exclude Paths] sectionThiébaud Weksteen
There is currently no convenient option to enable a hook globally if some projects will fail the processing. The recommended setup is to enable the hook within each project's repository (using PREUPLOAD.cfg). This creates inconsistencies for large codebase. Adds a new configuration section to explicitly exclude some projects during the processing of a hook. The intent of this change is to enable rustfmt globally in AOSP, except for some paths (e.g. external/, vendor/). Test: Modified GLOBAL-PREUPLOAD.cfg to enable the new option, manually creates changes and review output of pre-upload.py Bug: 160223496 Change-Id: I94dbbf0ce2e6b58c4d4b4fc89c56a2a87543d878
2020-09-02drop python2 testing entirely am: ec4cdcbeeeMike Frysinger
Original change: https://android-review.googlesource.com/c/platform/tools/repohooks/+/1417624 Change-Id: I80c4a873c4e87b9936104d94e6723a72b3649341
2020-09-02drop python2 testing entirelyMike Frysinger
No point in linting or testing when the code forces Python 3.6+. Bug: None Test: `repo upload` still works Change-Id: I5af19b5dc70be3f5be99157d1fc4287e4437c553
2020-09-02Snap for 6806793 from 615f08ee34ad7db309ed6a19124010a78c86cc08 to sc-releaseandroid-build-team Robot
Change-Id: I7221bb9ee372c8203f65d09a7fc42aca31fbf471
2020-09-01config: refactor PreUploadSettingsTests am: 324296b110Thiébaud Weksteen
Original change: https://android-review.googlesource.com/c/platform/tools/repohooks/+/1413981 Change-Id: I929668c32fb13fa260cd12562f00b026fdff3d52
2020-09-01config: add {Local,Global}PreUploadFile classes am: c9ba009aabThiébaud Weksteen
Original change: https://android-review.googlesource.com/c/platform/tools/repohooks/+/1413980 Change-Id: Ie264829e1cbf047d0bc6af3cc021d42f4a304dc4
2020-09-01config: refactor PreUploadSettingsTestsThiébaud Weksteen
PreUploadFileTests and PreUploadSettingsTests share the same setup and teardown for writing configuration files. Extract that behaviour into a new class (FileTestsBase). Test: pre-upload.py Bug: 160223496 Change-Id: I8b572cdb0f43ae4557323a43a69e66ead67d87fe
2020-09-01config: add {Local,Global}PreUploadFile classesThiébaud Weksteen
Creates 2 new classes to differentiate local (PREUPLOAD.cfg) and global (GLOBAL-PREUPLOAD.cfg) files. While not useful yet, this allows to implement validation that is specific to local files. Ideally, PreUploadFile would be declared as @abstractclass but the support for py2/py3 makes this constraint tedious to implement. Test: pre-upload.py Bug: 160223496 Change-Id: I75e0e644f713002f1ba50a405965362c1c5a7589
2020-09-01Snap for 6803976 from 24a38ce5e7368039d36fc39f5c39468396974e2c to sc-releaseandroid-build-team Robot
Change-Id: Ibbb1b25116bbd29eac688754e0d4d685729c9d63
2020-08-31pre-upload: drop support for Python 2 am: 7698778fb0Mike Frysinger
Original change: https://android-review.googlesource.com/c/platform/tools/repohooks/+/1373921 Change-Id: I2f0e1d3939e10be0763b24ecc0b14118c1be048e
2020-08-31pre-upload: drop support for Python 2Mike Frysinger
Repo itself has been warning about Python 2 support for over a year, while pre-uplooad has been warning for about a month. We don't actually rip out any code (yet) to make sure this sticks in case we have to revert things temporarily. Bug: None Test: `repo upload` still works w/Python 3.6 Change-Id: Ia00bc3c9a59b0e6828df2691f47c6da94adb8038
2020-08-29Snap for 6799253 from 0569f18a26d4831ee75827b379fe90c3df9de097 to sc-releaseandroid-build-team Robot
Change-Id: If6d5ce038b557a6ce486ac35f274f08e8846d7f8
2020-08-27config: refactor file management am: 1baec120bfMike Frysinger
Original change: https://android-review.googlesource.com/c/platform/tools/repohooks/+/1409412 Change-Id: Id7ed769c4436ae3d316ad046d1c181fd316f60b3
2020-08-27config: refactor file managementMike Frysinger
The existing config management started out with just one file, but has grown to load & merge from multiple sources. Refactor classes to better reflect this: one class to represent a single file, and another to represent the union of them all. By itself, this isn't interesting. But it lays the groundwork to be able to load config files from subdirs instead of only one file per project. Bug: 160223496 Test: Unittests pass Change-Id: I522b18fa8bc31f787c92cf95db7da4168007915e
2020-08-27Snap for 6793027 from 425db52f349d233f4501180c8949bd6ba9f20b92 to sc-releaseandroid-build-team Robot
Change-Id: I74b95a4dfe2f231fdaa508f1a8c64b0c9a6ca7a5
2020-08-26config: add Python 3 compat APIs am: 41a1fd1aacMike Frysinger
Original change: https://android-review.googlesource.com/c/platform/tools/repohooks/+/1409411 Change-Id: I20b225c3916994aabf677b5fdc86c5f5dbdae60f
2020-08-26Snap for 6790374 from fd6d0e0b33455142503a39741c486ff26c6ba232 to sc-releaseandroid-build-team Robot
Change-Id: I6f64fe07bc14d1ba55231d322bfbe807a520a028