diff options
author | Siva Velusamy <vsiva@google.com> | 2013-09-19 14:53:58 -0700 |
---|---|---|
committer | Siva Velusamy <vsiva@google.com> | 2013-09-19 14:55:24 -0700 |
commit | 47d38c4b288905843e567b7271a7e9f6f8bde8c5 (patch) | |
tree | bed3a89a380afceef389426f7abde7249473ceac /ddms | |
parent | 109392967060e2a72dd37063e23f30b50676a733 (diff) | |
download | swt-47d38c4b288905843e567b7271a7e9f6f8bde8c5.tar.gz |
traceview: Change help text for tracing vs. sampling
Change-Id: Iec63922684d77a3511eb3627b23ed6d9876453e7
Diffstat (limited to 'ddms')
-rw-r--r-- | ddms/ddmuilib/src/main/java/com/android/ddmuilib/vmtrace/VmTraceOptionsDialog.java | 44 |
1 files changed, 22 insertions, 22 deletions
diff --git a/ddms/ddmuilib/src/main/java/com/android/ddmuilib/vmtrace/VmTraceOptionsDialog.java b/ddms/ddmuilib/src/main/java/com/android/ddmuilib/vmtrace/VmTraceOptionsDialog.java index b3cfb4e..fc4d78d 100644 --- a/ddms/ddmuilib/src/main/java/com/android/ddmuilib/vmtrace/VmTraceOptionsDialog.java +++ b/ddms/ddmuilib/src/main/java/com/android/ddmuilib/vmtrace/VmTraceOptionsDialog.java @@ -37,7 +37,7 @@ public class VmTraceOptionsDialog extends Dialog { private static final int DEFAULT_SAMPLING_INTERVAL_US = 1000; // Static variables that maintain state across invocations of the dialog - private static boolean sTracingEnabled = true; + private static boolean sTracingEnabled = false; private static int sSamplingIntervalUs = DEFAULT_SAMPLING_INTERVAL_US; public VmTraceOptionsDialog(Shell parentShell) { @@ -59,33 +59,17 @@ public class VmTraceOptionsDialog extends Dialog { c.setLayout(new GridLayout(2, false)); c.setLayoutData(new GridData(GridData.FILL_BOTH)); - final Button useTracingButton = new Button(c, SWT.RADIO); - useTracingButton.setText("Trace based profiling"); - useTracingButton.setSelection(sTracingEnabled); - GridData gd = new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING, - GridData.VERTICAL_ALIGN_CENTER, true, true, 2, 1); - useTracingButton.setLayoutData(gd); - - Label l = new Label(c, SWT.NONE); - l.setText("Trace based profiling works by tracing the entry and exit of every method.\n" - + "This gives an accurate view of the execution, but has a high overhead."); - gd = new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING, GridData.VERTICAL_ALIGN_CENTER, true, - true, 2, 1); - gd.horizontalIndent = horizontalIndent; - l.setLayoutData(gd); - final Button useSamplingButton = new Button(c, SWT.RADIO); useSamplingButton.setText("Sample based profiling"); useSamplingButton.setSelection(!sTracingEnabled); - gd = new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING, GridData.VERTICAL_ALIGN_CENTER, true, + GridData gd = new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING, GridData.VERTICAL_ALIGN_CENTER, true, true, 2, 1); useSamplingButton.setLayoutData(gd); - l = new Label(c, SWT.NONE); - l.setText("Sample based profiling works by interrupting the VM at a given frequency and " - + "collecting the call stacks at that time.\n" - + "This has a much lower overhead, but statistical sampling requires longer runs " - + "to obtain a representative sample."); + Label l = new Label(c, SWT.NONE); + l.setText("Sample based profiling works by interrupting the VM at a given frequency and \n" + + "collecting the call stacks at that time. The overhead is proportional to the \n" + + "sampling frequency."); gd = new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING, GridData.VERTICAL_ALIGN_CENTER, true, true, 2, 1); gd.horizontalIndent = horizontalIndent; @@ -122,6 +106,22 @@ public class VmTraceOptionsDialog extends Dialog { } }); + final Button useTracingButton = new Button(c, SWT.RADIO); + useTracingButton.setText("Trace based profiling"); + useTracingButton.setSelection(sTracingEnabled); + gd = new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING, + GridData.VERTICAL_ALIGN_CENTER, true, true, 2, 1); + useTracingButton.setLayoutData(gd); + + l = new Label(c, SWT.NONE); + l.setText("Trace based profiling works by tracing the entry and exit of every method.\n" + + "This captures the execution of all methods, no matter how small, and hence\n" + + "has a high overhead."); + gd = new GridData(GridData.HORIZONTAL_ALIGN_BEGINNING, GridData.VERTICAL_ALIGN_CENTER, true, + true, 2, 1); + gd.horizontalIndent = horizontalIndent; + l.setLayoutData(gd); + SelectionAdapter selectionAdapter = new SelectionAdapter() { @Override public void widgetSelected(SelectionEvent event) { |