aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJulien Desprez <jdesprez@google.com>2016-02-05 10:27:25 +0000
committerAndroid (Google) Code Review <android-gerrit@google.com>2016-02-05 10:27:25 +0000
commit9bae9bd9d95cb8bd11e61a040d07ff878755d4a2 (patch)
treee77384c052b1636e4450bb04757d8b5d14833436
parenta654ddb939a72159134fec7d6e470dfde8c4d8ac (diff)
parent1235ec3ba6579748490c189dccd3ed7604db86e6 (diff)
downloadtradefederation-9bae9bd9d95cb8bd11e61a040d07ff878755d4a2.tar.gz
Merge "Remove a duplicate device state check"
-rw-r--r--src/com/android/tradefed/device/WaitDeviceRecovery.java20
1 files changed, 11 insertions, 9 deletions
diff --git a/src/com/android/tradefed/device/WaitDeviceRecovery.java b/src/com/android/tradefed/device/WaitDeviceRecovery.java
index d1515c1b2..dd4a17578 100644
--- a/src/com/android/tradefed/device/WaitDeviceRecovery.java
+++ b/src/com/android/tradefed/device/WaitDeviceRecovery.java
@@ -196,16 +196,18 @@ public class WaitDeviceRecovery implements IDeviceRecovery {
Log.i(LOG_TAG, String.format(
"Device %s unresponsive. Rebooting...", monitor.getSerialNumber()));
rebootDevice(device);
+ IDevice newdevice = monitor.waitForDeviceOnline(mOnlineWaitTime);
+ if (newdevice == null) {
+ handleDeviceNotAvailable(monitor, false);
+ return;
+ }
+ if (monitor.waitForDeviceAvailable(mWaitTime) != null) {
+ return;
+ }
}
- IDevice newdevice = monitor.waitForDeviceOnline(mOnlineWaitTime);
- if (newdevice == null) {
- handleDeviceNotAvailable(monitor, false);
- return;
- }
- if (monitor.waitForDeviceAvailable(mWaitTime) == null) {
- throw new DeviceUnresponsiveException(String.format(
- "Device %s is online but unresponsive", monitor.getSerialNumber()));
- }
+ // If no reboot was done, waitForDeviceAvailable has already been checked.
+ throw new DeviceUnresponsiveException(String.format(
+ "Device %s is online but unresponsive", monitor.getSerialNumber()));
}
/**